Have arrays' drop_glue just unsize and call the slice version#155184
Draft
scottmcm wants to merge 10 commits intorust-lang:mainfrom
Draft
Have arrays' drop_glue just unsize and call the slice version#155184scottmcm wants to merge 10 commits intorust-lang:mainfrom
drop_glue just unsize and call the slice version#155184scottmcm wants to merge 10 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-run-make
Collaborator
|
|
scottmcm
added
I-heavy
scottmcm
commented
Apr 12, 2026
|
|
||
| // RAW: ; core::ptr::drop_glue::<[array_drop_glue::NeedsDrop; [[N:7|13|42]]]> | ||
| // RAW-NEXT: inlinehint | ||
| // RAW: call core::ptr::drop_glue::<[array_drop_glue::NeedsDrop]> |
Member
Author
There was a problem hiding this comment.
Compare nightly https://rust.godbolt.org/z/5Wv1q86ja with a loop in each of the three.
This comment has been minimized.
This comment has been minimized.
Member
|
💭 does it make sense to keep the array case separate for |
Member
Author
|
My understanding is that LLVM will very effectively inline those -- just like how we don't special case the array iterator for N ≤ 1 and still use the polymorphic version. Does make me ponder if we should have a separate general "hey, there's no |
scottmcm
force-pushed
the
intercept-array-drop-shim
branch
from
d1bdee8 to
2ae092a
Compare
rustbot
added
A-test-infra-minicore
scottmcm
removed
PG-exploit-mitigations
Contributor
|
☔ The latest upstream changes (presumably #155207) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's silly to emit two loops (because of the drop ladder -- just one in panic=abort) for every array length that's dropped when we can just polymorphize to the slice version.
Built atop #154327 to avoid conflicts later, so draft for now.
r? @WaffleLapkin