unsafe_binder: implement v0 symbol mangling#154524
unsafe_binder: implement v0 symbol mangling#154524GrigorenkoPV wants to merge 1 commit intorust-lang:mainfrom
unsafe_binder: implement v0 symbol mangling#154524Conversation
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
056837f to
1173efa
Compare
|
I'm not familiar with the process for modifying the mangling spec, but I'd guess this requires some kind of agreement from the Compiler team Maintainers (not just the members) and rustc book update. Hopefully we get lucky on reroll, otherwise I'll ask on Zulip. |
|
Can we reuse the same trick as #122106 (comment) ? Essentially turning unsafe binders into a magical symbol from libcore? Needs a bit more than what was done for f32, as there's data after that, but should be workable. I should totally do the same for pattern types. Happy to do that first to try it out unless you wanna give it a shot for unsafe binders |
|
If I understand correctly, the approach you are suggesting requires no changes to I don't think I have enough time to work on that in the coming days, so I'm okay with you trying pattern types first or maybe even taking over this one too if I'm still busy by then. Your recent PRs regarding pattern types were a nice reference for me while working on this one and while trying to take a stab at #154871 today. Unfortunately, the latter is still more than what I'm competent enough for. |
|
@GrigorenkoPV I'm happy to take this over at some point if you're busy. (I have an open item for me to go through and finish up the unsafe binders implementation.) |
|
I'll review that work. Marking this PR as blocked for now |
Tracking issue: #130516
Fixes #154367
rustc_demanglealso needs to be changed, but they are in a separate repo. I think I will put up a PR there once the suggested mangling is deemed OK.