Skip to content

miri/const eval: support MaybeDangling#150446

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
WaffleLapkin:miri-maybe-dangling
Mar 9, 2026
Merged

miri/const eval: support MaybeDangling#150446
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
WaffleLapkin:miri-maybe-dangling

Conversation

@WaffleLapkin
Copy link
Copy Markdown
Member

@WaffleLapkin WaffleLapkin commented Dec 27, 2025 •
edited by rustbot
Loading

View all comments

r? RalfJung

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Dec 27, 2025

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
theemathas
theemathas reviewed Dec 28, 2025
View reviewed changes
Comment thread compiler/rustc_const_eval/src/interpret/validity.rs Outdated
theemathas
theemathas reviewed Dec 28, 2025
View reviewed changes
Comment thread src/tools/miri/src/borrow_tracker/stacked_borrows/mod.rs Outdated
@theemathas
Copy link
Copy Markdown
Contributor

theemathas commented Dec 28, 2025

Does this have insta-stable behavior change for ManuallyDrop in consteval?

@WaffleLapkin WaffleLapkin marked this pull request as draft December 28, 2025 13:42
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2025
@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Dec 28, 2025

It should only affect the behavior of code that still has UB until MaybeDangling is stabilized.

@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Jan 4, 2026

It is very import that we land #150447 before landing this, to avoid a situation where we generate LLVM IR with UB but Miri reports no UB.

@RalfJung RalfJung added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 4, 2026
RalfJung
RalfJung reviewed Jan 4, 2026
View reviewed changes
Comment thread src/tools/miri/src/borrow_tracker/stacked_borrows/mod.rs
RalfJung
RalfJung reviewed Jan 4, 2026
View reviewed changes
Comment thread src/tools/miri/src/borrow_tracker/stacked_borrows/mod.rs
RalfJung
RalfJung reviewed Jan 4, 2026
View reviewed changes
Comment thread src/tools/miri/tests/pass/move_manually_drop.rs Outdated
@WaffleLapkin WaffleLapkin force-pushed the miri-maybe-dangling branch 2 times, most recently from e5b7d00 to 959b31b Compare February 26, 2026 14:28
@WaffleLapkin WaffleLapkin marked this pull request as ready for review February 26, 2026 16:28
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 26, 2026
@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented Feb 26, 2026

@RalfJung I think I've addressed the review comments and this is ready for review too :)

(still blocked on the compiler change though)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin WaffleLapkin force-pushed the miri-maybe-dangling branch 3 times, most recently from 7b01b7c to 4a26802 Compare March 6, 2026 16:38
@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented Mar 6, 2026

@RalfJung I think I addressed your nits, unless I missed something ^^'

RalfJung
RalfJung reviewed Mar 6, 2026
View reviewed changes
Comment thread src/tools/miri/tests/pass/both_borrows/maybe_dangling_shared_write.rs Outdated
Copy link
Copy Markdown
Member

@RalfJung RalfJung Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant for this to just be a new test in the other file -- no reason to split it up.

RalfJung
RalfJung reviewed Mar 6, 2026
View reviewed changes
Comment thread compiler/rustc_const_eval/src/interpret/validity.rs
@WaffleLapkin WaffleLapkin force-pushed the miri-maybe-dangling branch from 4a26802 to 76a750a Compare March 9, 2026 11:36
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 9, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented Mar 9, 2026

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2026
@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Mar 9, 2026

Awesome, thanks a lot!
@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Mar 9, 2026

📌 Commit 76a750a has been approved by RalfJung

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150446 - WaffleLapkin:miri-maybe-dangling, …
c1085a6 
…r=RalfJung

miri/const eval: support `MaybeDangling`

r? RalfJung
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150446 - WaffleLapkin:miri-maybe-dangling, …
23ccc57 
…r=RalfJung

miri/const eval: support `MaybeDangling`

r? RalfJung
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150446 - WaffleLapkin:miri-maybe-dangling, …
c5f755a 
…r=RalfJung

miri/const eval: support `MaybeDangling`

r? RalfJung
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 9, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Mar 9, 2026
@bors
Auto merge of #153617 - JonathanBrouwer:rollup-udG4Tzr, r=JonathanBro…
5de528f 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #147834 (Always make tuple elements a coercion site)
 - #150446 (miri/const eval: support `MaybeDangling`)
 - #153053 (stop marking `deref_patterns` as an incomplete feature)
 - #153398 (fix ICE in `const_c_variadic` when passing ZSTs)
rust-bors Bot pushed a commit that referenced this pull request Mar 9, 2026
@bors
Auto merge of #153617 - JonathanBrouwer:rollup-udG4Tzr, r=JonathanBro…
2d76d9b 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #147834 (Always make tuple elements a coercion site)
 - #150446 (miri/const eval: support `MaybeDangling`)
 - #153053 (stop marking `deref_patterns` as an incomplete feature)
 - #153398 (fix ICE in `const_c_variadic` when passing ZSTs)
@rust-bors rust-bors Bot merged commit 8fc4e47 into rust-lang:main Mar 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 9, 2026
rust-timer added a commit that referenced this pull request Mar 9, 2026
@rust-timer
Unrolled build for #150446
d44f7f2 
Rollup merge of #150446 - WaffleLapkin:miri-maybe-dangling, r=RalfJung

miri/const eval: support `MaybeDangling`

r? RalfJung
github-actions Bot pushed a commit to rust-lang/miri that referenced this pull request Mar 10, 2026
@bors
Auto merge of #153617 - JonathanBrouwer:rollup-udG4Tzr, r=JonathanBro…
88cf36a 
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#147834 (Always make tuple elements a coercion site)
 - rust-lang/rust#150446 (miri/const eval: support `MaybeDangling`)
 - rust-lang/rust#153053 (stop marking `deref_patterns` as an incomplete feature)
 - rust-lang/rust#153398 (fix ICE in `const_c_variadic` when passing ZSTs)
@RalfJung RalfJung mentioned this pull request Mar 10, 2026
Open
9 tasks
@WaffleLapkin WaffleLapkin deleted the miri-maybe-dangling branch March 10, 2026 17:12
@WaffleLapkin WaffleLapkin mentioned this pull request Apr 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung requested changes

@theemathas theemathas theemathas left review comments

Assignees

@RalfJung RalfJung

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

7 participants

@WaffleLapkin @rustbot @rust-log-analyzer @theemathas @RalfJung @apiraino @Kobzol