See through aggregates in GVN#116270
Merged
bors merged 28 commits intorust-lang:masterfrom Oct 29, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is extracted from #111344
The first 2 commit are cleanups to avoid repeated work. I propose to stop removing useless assignments as part of this pass, and let a later
SimplifyLocalsdo it. This makes tests easier to read (among others).The next 3 commits add a constant folding mechanism to the GVN pass, presented in #116012.
This pass is designed to only use global allocations, to avoid any risk of accidental modification of the stored state.The following commits implement opportunistic simplifications, in particular:
MyStruct { x: a }.xgets replaced bya, works with enums too;[a, b][0]becomesa;[a; N][x]becomesa;Fixes rust-lang/miri#3090
r? @oli-obk