Merged
Conversation
Append the keywords list to Include the raw borrow operator, stabilized in Rust 2024. https://doc.rust-lang.org/reference/expressions/operator-expr.html#raw-borrow-operators
jcs090218
approved these changes
Apr 13, 2026
Contributor
|
I'm confused about the choice of reference, which describes operator expressions not keywords. The keyword reference lists it as a "Weak Keyword". Which means it is only a keyword in certain contexts. If we see the list of weak keywords, except for And using font-lock for context sensitive highlighting seems like the wrong tool for the job. |
Member
|
Yeah, you are right. Probably need to take care in special cases like other weak keywords. |
skr4n
added a commit
to skr4n/rust-mode
that referenced
this pull request
Apr 14, 2026
This reverts commit 6482f56. The raw borrow operator is a weak keyword, as such, it must only be highlighted in the right context. Weak keywords: https://doc.rust-lang.org/reference/keywords.html#weak-keywords
Contributor
Author
|
My bad, thanks for pointing this out. |
psibi
pushed a commit
that referenced
this pull request
Apr 16, 2026
* Revert "Add keyword `raw` (#585)" This reverts commit 6482f56. The raw borrow operator is a weak keyword, as such, it must only be highlighted in the right context. Weak keywords: https://doc.rust-lang.org/reference/keywords.html#weak-keywords * Add `raw` borrow operator as a contextual keyword The `raw` borrow operator is a contextual keyword. Highlight it only in the context of borrows. ```rust let mut x = 5; // highlight "raw" here let a = &raw const x; let b = &raw mut x; // do not highlight "raw" here let raw = &x as *const _; let raw_mut = &x as *mut _; ``` Raw borrow operator: https://doc.rust-lang.org/reference/expressions/operator-expr.html#raw-borrow-operators Rust weak keywords: https://doc.rust-lang.org/reference/keywords.html#weak-keywords
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append the keywords list to Include the raw borrow operator, stabilized in Rust 2024.
https://doc.rust-lang.org/reference/expressions/operator-expr.html#raw-borrow-operators