Add variant of LocalPool with bound lifetime#2846
Open
haroldbruintjes wants to merge 1 commit intorust-lang:masterfrom
Open
Add variant of LocalPool with bound lifetime#2846haroldbruintjes wants to merge 1 commit intorust-lang:masterfrom
haroldbruintjes wants to merge 1 commit intorust-lang:masterfrom
Conversation
haroldbruintjes
force-pushed
the
boundlocalpool
branch
2 times, most recently
from
8a19658 to
81bcdac
Compare
Adds derivatives of LocalPool and BoundLocalSpawner with a generic lifetime parameter that replaces the previously used 'static, and aliases both types with a 'static parameter to the originals. Add a BoundLocalSpawn trait in a similar fashion. At the same time simplify the implementation of Spawn, LocalSpawn and BoundLocalSpawn to just work on any type implementing Deref to a type implementing a spawn trait.
haroldbruintjes
force-pushed
the
boundlocalpool
branch
from
81bcdac to
037ab88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies
LocalPoolto accept a generic lifetime parameter, and renames it toBoundLocalPoolparameter, withLocalPoolnow being an alias forBoundLocalPool<'static>. Associated types (IncomingandLocalSpawner) get the same treatment where applicable. Add additionalBoundLocalSpawnandBoundLocalSpawnExttraits that extend the unbound variants with functions spawning bound-lifetime tasks.The purpose of this is to enable the use of an executor that does not require the futures assigned to it to exist any longer than it does. Existing code should of course still just work as it is.
Somewhat tangentially related, the implementations for the various spawner traits have been consolidated to just require
Deref, but that need not be part of the same change and does break compatibility. I left it in as a suggestion, but I suspect that should be reverted :).