Remove ambiguity from feature flag with no dependencies.#3294
Open
kevincox wants to merge 1 commit intorust-lang:mainfrom
Open
Remove ambiguity from feature flag with no dependencies.#3294kevincox wants to merge 1 commit intorust-lang:mainfrom
kevincox wants to merge 1 commit intorust-lang:mainfrom
Conversation
For the longest time I thought that it meant that the feature flag was defined but unused, not enabling any features. I just realized that it was actually talking about dependencies. So I figured it was good to make this more clear to avoid other people being confused like I was.
github-actions
Bot
added
the
S-waiting-on-review
| </ul> | ||
| {%- else -%} | ||
| <p>This feature flag does not enable additional features.</p> | ||
| <p>This feature flag does not enable additional feature flags.</p> |
Member
There was a problem hiding this comment.
Features can be both a feature flag or an optional crate, so not sure it removes ambiguity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the longest time I thought that it meant that the feature flag was defined but unused, not enabling any features. I just realized that it was actually talking about dependencies. So I figured it was good to make this more clear to avoid other people being confused like I was.