Skip to content

reduce compression level inside zip files#3286

Merged
syphar merged 1 commit intorust-lang:mainfrom
syphar:zip-bz2
Apr 8, 2026
Merged

reduce compression level inside zip files#3286
syphar merged 1 commit intorust-lang:mainfrom
syphar:zip-bz2

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented Apr 8, 2026

I did some tests.

going from level 6 (the default) to level 3 gives us 25% performance improvement for 10% bigger zip files.

@syphar syphar requested a review from a team as a code owner April 8, 2026 13:04
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 8, 2026
@syphar syphar self-assigned this Apr 8, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member

Do you have the numbers for each level?

Also: is it more important to generate zip files faster or to reduce storage?

@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 8, 2026

Do you have the numbers for each level?

I did measurements for 6 (default), 3 (this value), and 1.
The improvement for 1 was much less than hoped, so I left it at 3.

Also: is it more important to generate zip files faster or to reduce storage?

Right now: faster zip files :)

@GuillaumeGomez
Copy link
Copy Markdown
Member

For posterity sake, might be worth having a nice table with each level impact on speed and size. Well, I love numbers but feel free to ignore me. 🤣

@syphar syphar merged commit c369cb5 into rust-lang:main Apr 8, 2026
14 checks passed
@syphar syphar deleted the zip-bz2 branch April 8, 2026 14:17
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Apr 8, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants