Skip to content

override build priorities for some workspaces#3284

Merged
syphar merged 2 commits intorust-lang:mainfrom
syphar:build-prio
Apr 7, 2026
Merged

override build priorities for some workspaces#3284
syphar merged 2 commits intorust-lang:mainfrom
syphar:build-prio

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented Apr 7, 2026

Fixes #3276

the current automatic workspace deprio groups crates by repository, counts the crates, and will trigger deprioritization when there are more than 20 crates in that repo.

This is what we want for (I assume) most workspaces, which are released together most of the time. These clog the queue and we want them on prio -1.

But there are exceptions we learned about in the recent "full queue" event: tokio, or rustcrypto/utils, where we have many crates in one repo, but they aren't released together, but only separately. So these we don't need to deprioritize, and in the situations where the queue is full, this is rather annoying for the maintainers.

So this PR will enable us to override the priority for a repository / workspace, for the current cases just to "revert it back" to high priority. I can also use that feature to deprioritize workspaces further down. We're doing this for swc_% at the moment, I think it was because it's a huge workspace and wasn't even in production, or self-hosts their docs. I could imagine we can even drop the old build-priorities thing and instead just use this.

@syphar syphar self-assigned this Apr 7, 2026
@syphar syphar requested a review from a team as a code owner April 7, 2026 17:34
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 7, 2026
@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 7, 2026

fyi @Darksonn @tarcieri

With this I can bump your workspaces back up so they are not getting sniped down.

Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs. :)

View changes since this review

@syphar syphar requested a review from GuillaumeGomez April 7, 2026 22:38
@syphar
Copy link
Copy Markdown
Member Author

syphar commented Apr 7, 2026

done

GuillaumeGomez
GuillaumeGomez approved these changes Apr 7, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member

Awesome, thanks!

@syphar syphar merged commit 81cf3c2 into rust-lang:main Apr 7, 2026
13 checks passed
@syphar syphar deleted the build-prio branch April 7, 2026 23:41
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Apr 7, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tokio 1.51.0 not built after 24 hours

2 participants