Clarify final expression return wording in ch09-02#4730
Open
NMJ27 wants to merge 1 commit intorust-lang:mainfrom
Open
Clarify final expression return wording in ch09-02#4730NMJ27 wants to merge 1 commit intorust-lang:mainfrom
NMJ27 wants to merge 1 commit intorust-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current wording says “this is the last expression in the function,” which may be read as referring to Err(e) in the Err arm rather than to the entire match expression. This change makes that more explicit for learners.
It rewords the sentence to:
However, we don’t need to explicitly say return before the final match, because the entire match expression is the last expression in the function, so its value is returned.
When reading this section, I initially interpreted the earlier Err(e) => return Err(e) as a pattern that also applied to the final match. In that reading, the omitted return can seem unclear, especially for the Ok(username) arm. This change clarifies that the omitted idiomatic return applies to the entire final match, not to an individual arm.