clippy: fix manual_option_zip lint#1098
Merged
phimuemue merged 1 commit intorust-itertools:masterfrom Apr 18, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
- Coverage 94.38% 93.92% -0.47%
==========================================
Files 48 51 +3
Lines 6665 6466 -199
==========================================
- Hits 6291 6073 -218
- Misses 374 393 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
225ed02 to
759bbeb
Compare
Member
|
Hi there, I think your transformation is correct, so thanks for this. However, it relies on evaluation order, i.e. this: From what I glean from https://doc.rust-lang.org/reference/expressions.html#evaluation-order-of-operands, one can rely on it, but I don't want to encourage to do it. Can you maybe change it to |
759bbeb to
db613dc
Compare
Contributor
Author
Yeah, that looks better: db613dc |
phimuemue
approved these changes
Apr 18, 2026
Merged
via the queue into
rust-itertools:master
with commit Apr 18, 2026
d36b378
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix warn-by-default lint in Rust 1.95
https://rust-lang.github.io/rust-clippy/master/index.html#manual_option_zip