Fix: AE-1371: poll for jobs while tasks are running#473
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a busy-wait issue in the job processing loop by implementing proper idle handling and concurrent task tracking. The changes ensure the worker efficiently polls for new jobs while existing tasks are running, preventing CPU waste when idle.
Key Changes:
- Modified
JobScaler.run_jobsto use a set for tracking tasks, added a timeout toasyncio.wait, and implemented idle sleep to prevent busy-spinning - Added comprehensive async test suite covering queue draining, concurrency limits, shutdown behavior, and end-to-end job processing workflows
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| runpod/serverless/modules/rp_scale.py | Changed task tracking from list to set, added timeout to asyncio.wait, and implemented idle sleep to eliminate busy-waiting |
| tests/test_serverless/test_rp_scale.py | New comprehensive test suite covering concurrency, queue management, shutdown behavior, and job processing workflows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1891de9 to
433b1da
Compare
Yhlong00
approved these changes
Jan 6, 2026
deanq
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified from #457