Infer HTML5 validation attributes from ActiveRecord validators#70
Draft
bradgessler wants to merge 1 commit intomainfrom
Draft
Infer HTML5 validation attributes from ActiveRecord validators#70bradgessler wants to merge 1 commit intomainfrom
bradgessler wants to merge 1 commit intomainfrom
Conversation
Adds HTML5::ValidationAttributes class that reads ActiveRecord validators and produces corresponding HTML5 attributes (required, minlength, maxlength, min, max, step). A thin Validations module prepends onto Field to merge these attributes into input, checkbox, textarea, select, and radio calls. User kwargs always win over inferred attributes. Conditional validators (if:, unless:, on:) are skipped since they can't be evaluated at render time. Forms can opt out via `def novalidate = true`, which suppresses attribute injection and adds the novalidate attribute to the <form> tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTML5::ValidationAttributesclass that reads ActiveRecord validators and produces corresponding HTML5 attributes (required,minlength,maxlength,min,max,step)Validationsmodule prepends onto Field to merge these attributes intoinput,checkbox,textarea,select, andradiocallsif:,unless:,on:) are skipped since they can't be evaluated at render timedef novalidate = trueTest plan