make clear that scope is ignored purposely in FileTask.scope_name#237
Open
rickhull wants to merge 1 commit intoruby:masterfrom
Open
make clear that scope is ignored purposely in FileTask.scope_name#237rickhull wants to merge 1 commit intoruby:masterfrom
rickhull wants to merge 1 commit intoruby:masterfrom
Conversation
rickhull
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% certain on whether this change is desirable or self-evidently so. But I definitely had to do a double-take when I looked at the method definition and saw that only the last argument was even considered. The existing comments somewhat explain it. I think the leading underscore on
_scopemakes the code more self-evident.Note, this PR was resubmitted from a non-master branch of my fork.