Skip to content

Forward-port Ractor change from ruby/ruby #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 2 commits into from
Jun 3, 2025
Merged

Forward-port Ractor change from ruby/ruby #814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f00b1
`Ractor::Port`
ko1 May 26, 2025
d42b369
Update `JSONInRactorTest` to handle Ruby 3.5 Ractors.
byroot Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion test/json/ractor_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@
end

class JSONInRactorTest < Test::Unit::TestCase
unless Ractor.method_defined?(:value)
module RactorBackport
refine Ractor do
alias_method :value, :take
end
end

using RactorBackport
end

def test_generate
pid = fork do
r = Ractor.new do
Expand All @@ -25,7 +35,7 @@ def test_generate
end
expected_json = JSON.parse('{"a":2,"b":3.141,"c":"c","d":[1,"b",3.14],"e":{"foo":"bar"},' +
'"g":"\\"\\u0000\\u001f","h":1000.0,"i":0.001}')
actual_json = r.take
actual_json = r.value
Copy link
Copy Markdown
Member

@byroot byroot Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't just change it, as tests have to pass on older versions. I'll take care of it.

Copy link
Copy Markdown
Member Author

@hsbt hsbt Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byroot Thanks! I remembered that after opened this.


if expected_json == actual_json
exit 0
Expand Down