Add termination char to every segment, even the last one.#60
Add termination char to every segment, even the last one.#60micred wants to merge 1 commit intoruby-hl7:masterfrom
Conversation
|
Hey @micred, this breaks a lot of test. Would you mind taking a look at that? My guess is that we would be needing to update the test if we decide to go with this change. Maybe we need to setup a different delimiter for test? |
|
Test are comparing to the wrong terminating segments: The is also a \n that should not be present, do you agree? |
|
This will generate HL7 that the gem won't be able to parse. #3 The parser has trouble with a trailing newline on the last segment, treating it like a new, empty segment and throwing a |
HL7 Inspector notifies:
The to_hl7 - and then to_mllp - methods does not terminate the last segment.
HL7 specification says that every segment should be terminated, even the last one.
With this simple PR every segment is terminated.