cmake: fallback to pkgconfig if the zstd cmake config is missing#158
Merged
Conversation
Upstream zstd only installs the zstd cmake config file when its built with cmake and several distros such as Gentoo use the official make build system instead. This makes depending on the cmake config file unreliable and for downstream projects. Its better to fallback to using the pkgconfig file when its not found. This solution is copied from cemu. Upstream-Issue: facebook/zstd#3271 Source: https://github.com/cemu-project/Cemu/blob/9b76b0e2d33725d37dc8c6137d8ea2fa9b991542/cmake/Findzstd.cmake
rtissera
approved these changes
May 3, 2026
Owner
|
Yeah, I falled into this trap a few times too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream zstd only installs the zstd cmake config file when its built with cmake and several distros such as Gentoo use the official make build system instead.
This makes depending on the cmake config file unreliable and for downstream projects. Its better to fallback to using the pkgconfig file when its not found.
This solution is copied from cemu.
Upstream-Issue: facebook/zstd#3271
Source: https://github.com/cemu-project/Cemu/blob/9b76b0e2d33725d37dc8c6137d8ea2fa9b991542/cmake/Findzstd.cmake