Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows to use newer action versions and adjusts Pandoc versions used in CI to cover newer and nightly builds.
Changes:
- Bumped
actions/checkoutreferences in workflows. - Updated
R-CMD-checkmatrix Pandoc versions (including adding anightlyrun and reintroducing3.1.1coverage on Ubuntu). - Switched daily Pandoc “devel” workflow to install Pandoc via
r-lib/actions/setup-pandoc@v2withpandoc-version: nightly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/update-examples.yaml | Updates the checkout action version used when building/deploying examples. |
| .github/workflows/R-CMD-check.yaml | Updates checkout action version; refreshes Pandoc matrix entries and coverage trigger Pandoc version. |
| .github/workflows/check-pandoc-daily.yaml | Updates checkout action version; changes Pandoc install step to setup-pandoc with nightly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@yihui it seems somehow that pagedown fails now in CI. Not sure why - but as you've made a new release to you see why ? Also I see you have fork or redo actions at: https://github.com/yihui/actions/ Should we use that ? Is this supposed to help us better in rmarkdown ecosystem rather than using r-lib/actions ? |
|
I don't know why from a quick look at the CI logs, either. It's failing on Windows and Ubuntu but not macOS. Perhaps you can let Claude have a quick look?
The benefit of using my actions for rmarkdown-related packages may not be significant. My actions are best for packages with a small number of deps, in which case using pak and rcmdcheck is often an overkill. I switched tinytex's actions over to mine mainly because tinytex has only one dependency. |
|
BTW, given that Pandoc 3.0 is more than 3 years old now, perhaps we can drop the workflows for pandoc 2.x? For bookdown, I'm only testing two versions now: one version used by RStudio/Quarto, and the other is the latest version (to catch problems early). |
|
yes good idea. I've kept some versions known to have regression. and historically because default on ubuntu was an old pandoc. I don't know which is it now. |
|
Ubuntu 24.04 has Pandoc 3.x: https://manpages.ubuntu.com/manpages/noble/man1/pandoc.1.html Older Ubuntu releases still have 2.x. |
|
Ok to do with Pandoc 3 has min ? |
|
I'm fine with that. We can always add a version back when users actually find bugs there. |
No description provided.