client: respond to KEEPALIVE(RESPOND) frame#912
Open
yuriykulikov wants to merge 1 commit intorsocket:masterfrom
Open
client: respond to KEEPALIVE(RESPOND) frame#912yuriykulikov wants to merge 1 commit intorsocket:masterfrom
yuriykulikov wants to merge 1 commit intorsocket:masterfrom
Conversation
Client sends KEEPALIVE(EMPTY) in this case. This change is required for the rsocket-cpp client to be able to work with current rsocket-java and rsocket-kotlin servers, which do send KEEPALIVE(RESPOND) to the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client sends KEEPALIVE(EMPTY) in this case.
Motivation and Context
This change is required for the rsocket-cpp client to be able to
work with current rsocket-java and rsocket-kotlin servers, which
do send KEEPALIVE(RESPOND) to the client.
How Has This Been Tested
Tested with rsocket-cpp, rsocket-kotlin and rsocket-java servers.
Types of changes
Checklist