Add tests isolation in test_rclcpp (backport #583)#589
Open
mergify[bot] wants to merge 1 commit intokiltedfrom
Open
Add tests isolation in test_rclcpp (backport #583)#589mergify[bot] wants to merge 1 commit intokiltedfrom
mergify[bot] wants to merge 1 commit intokiltedfrom
Conversation
* test_rclcpp: add test isolation Signed-off-by: Julien Enoch <julien.e@zettascale.tech> * test_rclcpp: add test isolation in test_sigterm.py.in and test_executable_output.py.in which are using a LaunchDescription Signed-off-by: Julien Enoch <julien.e@zettascale.tech> --------- Signed-off-by: Julien Enoch <julien.e@zettascale.tech> (cherry picked from commit 3d0fde9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in ros2/rmw_zenoh#881 (comment), this PR adds tests isolation to all tests initializing a Context or a Node, in order to start a Zenoh router in case of rmw_zenoh_cpp.
More specifically:
test_rclcpp/CMakeLists.txt:calls to
ament_add_gtest_testare replaced with call toament_add_ros_isolated_gtest_testtest_rclcpp/test/test_executable_output.py.inandtest_rclcpp/test/test_sigterm.py.inwhich are usingLaunchDescription:a
EnableRmwIsolation()is added, and the the way to update theenvfor output format is changed to not override that environment change made byEnableRmwIsolation()Is this user-facing behavior change?
No
Did you use Generative AI?
No
This is an automatic backport of pull request #583 done by Mergify.