Further enhancements to Deref implementation#149
Open
tbates-redarc wants to merge 3 commits intorootcause-rs:mainfrom
Open
Further enhancements to Deref implementation#149tbates-redarc wants to merge 3 commits intorootcause-rs:mainfrom
Deref implementation#149tbates-redarc wants to merge 3 commits intorootcause-rs:mainfrom
Conversation
For some reason this causes an ambiguity in type inference that wasn't there before, although the docs already warn about the potential for it. This could be a breaking change for downstream crates.
Allows Report to be used with methods that take `impl AsRef<dyn core::error::Error>` parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is likely to the the most controversial as it uncovers some latent type inference ambiguities, which might impact downstream crates.
The second commit adds unit tests.
The third commit, following
anyhow's lead, addsAsRefimpls in addition to theDerefs.