feat(report): suppress footer when --top is explicitly passed#628
Merged
rocketman-code merged 1 commit intomainfrom Apr 24, 2026
Merged
feat(report): suppress footer when --top is explicitly passed#628rocketman-code merged 1 commit intomainfrom
rocketman-code merged 1 commit intomainfrom
Conversation
The "N functions hidden" footer only shows when default truncation is active (user ran piano report with no --top flag). When --top N is explicitly passed, the footer is suppressed — the user already knows about the flag. --all continues to show no footer (nothing hidden). Add show_footer: bool parameter to format_table, threaded through resolve_display_limit and all CLI commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
piano reportwith no--topflag)--top Nis explicitly passed, the footer is suppressed--allcontinues to show no footer (nothing hidden)Adds
show_footer: booltoformat_table, threaded throughresolve_display_limitand all CLI commands.Test Plan
format_table_no_footer_when_show_footer_falseshow_footer: true(preserves behavior)--top 5suppresses it,--allno footer