Merged
Conversation
Support cargo example targets via --example flag, mutually exclusive with --bin. Generalize find_bin_target to find_target accepting a target kind parameter. Update build_instrumented to accept CargoTarget enum (Bin or Example). Extend find_latest_binary to scan the examples subdirectory. Add unit test for example target discovery.
rocketman-code
force-pushed
the
feat/example-target-clean
branch
from
7eb2b78 to
7905534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--exampleflag topiano buildandpiano profile, mutually exclusive with--binfind_bin_targettofind_targetaccepting a target kind parameterbuild_instrumentedto acceptCargoTargetenum for cargo flag dispatchfind_latest_binaryto scantarget/piano/release/examples/Test plan
piano profile --example clockon rake-core produces correct profiling output--binand--examplemutually exclusive via clapconflicts_with