Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 82 additions & 10 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ enum Commands {
#[arg(long)]
json: bool,

/// JSON output schema version (pin this in CI scripts)
#[arg(long, value_parser = clap::value_parser!(u8).range(1..=2))]
format_version: Option<u8>,

/// Max packages to show in diff output (-1 for all)
#[arg(long, default_value_t = report::DEFAULT_TOP, allow_hyphen_values = true)]
limit: i32,
Expand Down Expand Up @@ -127,6 +131,10 @@ struct TraceArgs {
#[arg(long)]
json: bool,

/// JSON output schema version (pin this in CI scripts)
#[arg(long, value_parser = clap::value_parser!(u8).range(1..=2))]
format_version: Option<u8>,

/// Force full re-parse, ignoring cache
#[arg(long)]
no_cache: bool,
Expand Down Expand Up @@ -157,6 +165,10 @@ struct PackagesArgs {
#[arg(long)]
json: bool,

/// JSON output schema version (pin this in CI scripts)
#[arg(long, value_parser = clap::value_parser!(u8).range(1..=2))]
format_version: Option<u8>,

/// Force full re-parse, ignoring cache
#[arg(long)]
no_cache: bool,
Expand Down Expand Up @@ -194,6 +206,28 @@ fn resolve_color(no_color: bool) -> bool {
)
}

fn resolve_format_version(
flag: Option<u8>,
json: bool,
sc: report::StderrColor,
) -> report::FormatVersion {
if !json {
return report::FormatVersion::V2;
}
match flag {
Some(1) => report::FormatVersion::V1,
Some(_) => report::FormatVersion::V2,
None => {
eprintln!(
"{} --format-version not specified, defaulting to 2. \
Pin --format-version 2 in scripts to avoid future breaks.",
sc.warning("warning:"),
);
report::FormatVersion::V2
}
}
}

/// Cap the rayon thread pool to avoid VFS lock contention in the kernel.
///
/// Filesystem-heavy workloads (stat, open, read) hit diminishing returns beyond
Expand Down Expand Up @@ -238,9 +272,13 @@ fn run(command: Commands, no_color: bool, sc: report::StderrColor) -> Result<Exi
b,
entry,
json,
format_version,
limit,
quiet,
} => run_diff(a, b, entry, json, limit, quiet, color, sc).map(|()| ExitCode::SUCCESS),
} => {
let fv = resolve_format_version(format_version, json, sc);
run_diff(a, b, entry, json, fv, limit, quiet, color, sc).map(|()| ExitCode::SUCCESS)
}

Commands::Packages(ref args) => run_packages(args, color, sc).map(|()| ExitCode::SUCCESS),

Expand All @@ -264,6 +302,7 @@ fn run(command: Commands, no_color: bool, sc: report::StderrColor) -> Result<Exi

fn run_trace(args: TraceArgs, color: bool, sc: report::StderrColor) -> Result<ExitCode, Error> {
let start = Instant::now();
let fv = resolve_format_version(args.format_version, args.json, sc);

// Validate mutually exclusive flags before loading graph
let query_flags: Vec<&str> = [
Expand Down Expand Up @@ -314,7 +353,11 @@ fn run_trace(args: TraceArgs, color: bool, sc: report::StderrColor) -> Result<Ex
return Err(Error::TargetIsEntryPoint("--chain".into()));
}
let report = session.chain_report(chain_arg, args.include_dynamic);
report::emit(args.json, || report.to_json(), || report.to_terminal(color));
report::emit(
args.json,
|| report.to_json_versioned(fv),
|| report.to_terminal(color),
);
if report.chains.is_empty() {
return Ok(ExitCode::FAILURE);
}
Expand All @@ -328,7 +371,11 @@ fn run_trace(args: TraceArgs, color: bool, sc: report::StderrColor) -> Result<Ex
return Err(Error::TargetIsEntryPoint("--cut".into()));
}
let report = session.cut_report(cut_arg, args.top, args.include_dynamic);
report::emit(args.json, || report.to_json(), || report.to_terminal(color));
report::emit(
args.json,
|| report.to_json_versioned(fv),
|| report.to_terminal(color),
);
if report.chain_count == 0 {
return Ok(ExitCode::FAILURE);
}
Expand All @@ -340,7 +387,11 @@ fn run_trace(args: TraceArgs, color: bool, sc: report::StderrColor) -> Result<Ex
let saved = load_snapshot(snapshot_path)?;
let diff = query::diff_snapshots(&saved, &result.to_snapshot(&entry_rel));
let report = report::DiffReport::from_diff(&diff, &saved.entry, &entry_rel, args.limit);
report::emit(args.json, || report.to_json(), || report.to_terminal(color));
report::emit(
args.json,
|| report.to_json_versioned(fv),
|| report.to_terminal(color),
);
return Ok(ExitCode::SUCCESS);
}

Expand All @@ -355,6 +406,7 @@ fn run_trace(args: TraceArgs, color: bool, sc: report::StderrColor) -> Result<Ex
args.no_cache,
args.limit,
args.json,
fv,
color,
sc,
)?;
Expand All @@ -363,7 +415,11 @@ fn run_trace(args: TraceArgs, color: bool, sc: report::StderrColor) -> Result<Ex

// Normal trace output
let report = session.trace_report(&opts, args.top_modules);
report::emit(args.json, || report.to_json(), || report.to_terminal(color));
report::emit(
args.json,
|| report.to_json_versioned(fv),
|| report.to_terminal(color),
);

if let Some(threshold) = args.max_weight.filter(|&t| report.static_weight_bytes > t) {
let kind = if args.include_dynamic {
Expand Down Expand Up @@ -401,6 +457,7 @@ fn handle_trace_diff(
no_cache: bool,
limit: i32,
json: bool,
fv: report::FormatVersion,
color: bool,
sc: report::StderrColor,
) -> Result<(), Error> {
Expand Down Expand Up @@ -429,7 +486,11 @@ fn handle_trace_diff(
let diff_output = query::diff_snapshots(&result.to_snapshot(entry_rel), &diff_snapshot);
let report =
report::DiffReport::from_diff(&diff_output, entry_rel, &diff_snapshot.entry, limit);
report::emit(json, || report.to_json(), || report.to_terminal(color));
report::emit(
json,
|| report.to_json_versioned(fv),
|| report.to_terminal(color),
);
Ok(())
}

Expand All @@ -454,14 +515,19 @@ fn run_packages(args: &PackagesArgs, color: bool, sc: report::StderrColor) -> Re
if args.top < -1 {
return Err(Error::InvalidTopValue("--top", args.top));
}
let fv = resolve_format_version(args.format_version, args.json, sc);
let start = Instant::now();
let session = Session::open(&args.entry, args.no_cache)?;
if !args.quiet {
print_session_status(&session, start, sc);
}

let report = session.packages_report(args.top);
report::emit(args.json, || report.to_json(), || report.to_terminal(color));
report::emit(
args.json,
|| report.to_json_versioned(fv),
|| report.to_terminal(color),
);
Ok(())
}

Expand Down Expand Up @@ -514,6 +580,7 @@ fn run_diff(
b: Option<String>,
entry: Option<PathBuf>,
json: bool,
fv: report::FormatVersion,
limit: i32,
quiet: bool,
color: bool,
Expand Down Expand Up @@ -556,13 +623,13 @@ fn run_diff(
let wt_snap = build_snapshot_from_working_tree(entry_path, quiet, sc)?;
let wt_label = wt_snap.entry.clone();
return finish_diff(
&snap_a, &label_a, &wt_snap, &wt_label, json, limit, color, start, quiet, sc,
&snap_a, &label_a, &wt_snap, &wt_label, json, fv, limit, color, start, quiet, sc,
);
}
};

finish_diff(
&snap_a, &label_a, &snap_b, &label_b, json, limit, color, start, quiet, sc,
&snap_a, &label_a, &snap_b, &label_b, json, fv, limit, color, start, quiet, sc,
)
}

Expand All @@ -573,6 +640,7 @@ fn finish_diff(
snap_b: &query::TraceSnapshot,
label_b: &str,
json: bool,
fv: report::FormatVersion,
limit: i32,
color: bool,
start: Instant,
Expand All @@ -581,7 +649,11 @@ fn finish_diff(
) -> Result<(), Error> {
let diff_output = query::diff_snapshots(snap_a, snap_b);
let report = report::DiffReport::from_diff(&diff_output, label_a, label_b, limit);
report::emit(json, || report.to_json(), || report.to_terminal(color));
report::emit(
json,
|| report.to_json_versioned(fv),
|| report.to_terminal(color),
);
if !quiet {
eprintln!(
"\n{} in {:.1}ms",
Expand Down
Loading
Loading