fix: restore correct metric for Smoothing Pool Balance panel (v1.4.0 regression)#1007
Open
4rc0s wants to merge 1 commit intorocket-pool:masterfrom
Open
fix: restore correct metric for Smoothing Pool Balance panel (v1.4.0 regression)#10074rc0s wants to merge 1 commit intorocket-pool:masterfrom
4rc0s wants to merge 1 commit intorocket-pool:masterfrom
Conversation
Panel 250 ("Smoothing Pool Balance") was accidentally changed to use
rocketpool_demand_deposit_pool_balance (the deposit pool metric) in v1.4.0.
Restore it to rocketpool_smoothing_pool_eth_balance, which was correct
in v1.3.3 and matches what the smartnode exporter exposes.
Panel 160 ("Staking Pool Balance") correctly continues to use
rocketpool_demand_deposit_pool_balance for the deposit pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Panel 250 ("Smoothing Pool Balance") in
Rocket Pool Dashboard v1.4.0.jsonwas accidentally usingrocketpool_demand_deposit_pool_balance— the deposit pool metric — instead ofrocketpool_smoothing_pool_eth_balance.This was correct in v1.3.3 and regressed in v1.4.0.
Before (v1.4.0):
After (this fix):
Context
rocketpool_demand_deposit_pool_balancefor the deposit pool — no change needed there.rocketpool_smoothing_pool_eth_balancemetric is exposed by the smartnode exporter viasmoothing-pool-collector.go.