[codex] fix recorder codec handling and bridge re-INVITE selection#193
Merged
shenjinti merged 2 commits intorestsend:mainfrom Apr 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This branch contains two local commits that are ahead of
upstream/main:Why
The re-INVITE fix addresses a WebRTC/RTP bridge failure where SIP session renegotiation looked only at caller/callee media peers for a local
PeerConnection, even when the active transport conversion state lived onmedia_bridge. That caused bridge-backed re-INVITEs to fail to build a local answer.Impact
PeerConnectionSipSessionunit testupstream/mainon this branchValidation
cargo test test_get_local_reinvite_pc_uses_bridge_when_present --lib