Support name-addr Refer-To headers#116
Merged
shenjinti merged 1 commit intorestsend:mainfrom Apr 20, 2026
Merged
Conversation
6121a72 to
20870e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates the dialog
refer()APIs to accept fullRefer-Toheader values instead of onlyUriinputs.refer()to acceptimpl Into<crate::sip::ReferTo>across dialog typesFrom<crate::sip::Uri> for ReferToso existing URI callers still serialize as<sip:...>Why it changed
Issue #115 points out that RFC 3515 allows
Refer-Toto carry the full name-addr form, including an optional display name and parameters. The previous API only acceptedUriand always forcedRefer-Tointo"<uri>", which prevented callers from supplying valid name-addr values.Impact
Uricontinue to work unchangedRefer-Tovalue such as"Display Name" <sip:user@domain.com;method=INVITE?Replaces=...>Root cause
The REFER helpers modeled
Refer-Toas a URI-only input even though the header syntax is wider than a bare URI.Validation
cargo test --libcargo test referinactive-callcargo test test_inbound_refer_success --libinrustpbxcargo test --test rwi_transfer_refer_e2e_testinrustpbxCloses #115.