This repository was archived by the owner on Nov 12, 2025. It is now read-only.
Fix TOML syntax for Kafka cluster configuration#662
Merged
slinkydeveloper merged 1 commit intorestatedev:mainfrom Nov 6, 2025
Merged
Fix TOML syntax for Kafka cluster configuration#662slinkydeveloper merged 1 commit intorestatedev:mainfrom
slinkydeveloper merged 1 commit intorestatedev:mainfrom
Conversation
Correct TOML syntax for SASL username and password.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
slinkydeveloper
approved these changes
Nov 6, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this docs page (https://docs.restate.dev/services/invocation/kafka#kafka-connection-configuration), the options that go to librdkafka need to be string, string, as they go to a
HashMap<String, String>.I had the misfortune of spending a day figuring this out, as I didn't pay close attention to the following line a few paras below - "The options field is optional and accepts any librdkafka configuration parameter."
Missed the implication that librdkafka options go in the subscription registration request, i.e.,