fix: sanitize untrusted email fields in remaining interactive receiving commands#216
Draft
bukinoshita wants to merge 1 commit into
Draft
fix: sanitize untrusted email fields in remaining interactive receiving commands#216bukinoshita wants to merge 1 commit into
bukinoshita wants to merge 1 commit into
Conversation
cursor
Bot
changed the title
Member
Author
|
@cursor fix the conflicts |
|
Conflicts resolved. Here's what I did:
  |
…ng commands Apply safeTerminalText (already on main) to the interactive output paths that were still printing raw untrusted fields: - get.ts: sanitize from, to, subject, and text body snippet - attachment.ts: sanitize filename - utils.ts: sanitize from, to, subject in table rows listen.ts was already sanitized on main. JSON output is unaffected. Resolves: BU-656 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
cursor
Bot
force-pushed
the
fix/sanitize-terminal-escape-sequences-38d8
branch
from
fb787eb to
bfd655e
Compare
cursor
Bot
changed the title
Member
Author
|
@cubic-dev-ai can you review? |
Contributor
@bukinoshita I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Sanitizes untrusted inbound email fields in interactive CLI output to strip ANSI/control escape sequences and prevent terminal spoofing or abuse. Addresses Linear BU-656; JSON output is unchanged.
src/lib/sanitize-for-terminal.tsto remove C0 (except tab/newline), DEL, C1, ESC, and CSI bytes.emails/receivinginteractive paths:get,listen, table rendering, andattachment.Written for commit fb787eb. Summary will update on new commits.