[bug] reflow v2 close ownership#159
Open
blast-hardcheese wants to merge 12 commits intoreplit:mainfrom
Open
Conversation
299d6df to
9fde4de
Compare
bf68171 to
4ead10e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Addressing some dangling work to hopefully advance the v2 client stability.
The main issue is that
Session.close()had this weird circular dependency withClientTransport.close()which increased the chance of error.It should have been
ClientTransport.close()->Session.close()with no backwards arrows.What changed
Session.close()responsibility intoClientTransportprint(...)tologging.debugto make it easier to--log-level=debugin pytest and see all the logs together.get_current_time()incorrectly used asyncio.Task's internal clock, instead of the wall clock, extending timeouts further than they should have been.Test plan
CI, manual testing with staff/explorers after releasing a new version