fix(namespaces): use caipNetworkId directly in createNamespaces#5666
Open
Khizr97 wants to merge 1 commit into
Open
fix(namespaces): use caipNetworkId directly in createNamespaces#5666Khizr97 wants to merge 1 commit into
Khizr97 wants to merge 1 commit into
Conversation
Both WCNamespaceUtil and WalletConnectUtil were reconstructing the CAIP network ID from chainNamespace + id instead of reading the existing caipNetworkId property. For standard chains these are equivalent, but for custom chains (Neo3, Stellar, etc.) where id differs from the CAIP-2 chain reference the wrong namespace was sent to wallets over WalletConnect. Also fixes rpcMap keys to use the full caipNetworkId. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
🦋 Changeset detectedLatest commit: be00c23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createNamespacesin bothWCNamespaceUtilandWalletConnectUtilwas reconstructing the CAIP network ID as`${chainNamespace}:${id}`instead of reading the existingcaipNetworkIdproperty on theCaipNetworkobjectid: 1,caipNetworkId: 'neo3:MainNet') or Stellar (caipNetworkId: 'stellar:pubnet'), the wrong chain ID was sent in the WalletConnect namespace, causing wallets to reject or mishandle the sessionrpcMapkeys to use the fullcaipNetworkIdinstead of the rawidTest plan
rpcMapexpectations in existingcreateNamespacestest to use full CAIP IDs ('eip155:1'instead of'1')id: 1andcaipNetworkId: 'neo3:MainNet'— verifies chains contain'neo3:MainNet'not'neo3:1'Closes REOWN-4474
🤖 Generated with Claude Code