Skip to content

Clarify sandbox GitHub auth failures#540

Merged
NagyVikt merged 1 commit intomainfrom
agent/codex/fix-gh-auth-network-diagnosis-2026-05-08-11-49
May 8, 2026
Merged

Clarify sandbox GitHub auth failures#540
NagyVikt merged 1 commit intomainfrom
agent/codex/fix-gh-auth-network-diagnosis-2026-05-08-11-49

Conversation

@NagyVikt
Copy link
Copy Markdown
Collaborator

@NagyVikt NagyVikt commented May 8, 2026

Automated by gx branch finish (PR flow).

gh auth status can report an invalid hosts.yml token when the real problem is blocked GitHub API connectivity in Codex or another sandbox. The release command and review bot now probe gh api user before asking for re-auth, continue when that probe succeeds, and report network/sandbox failure when the API is unreachable.

Constraint: Old gh auth status output can conflate API connectivity failure with invalid stored credentials

Rejected: Always tell users to run gh auth login | repeats a false fix when the token is valid but api.github.com is unreachable

Confidence: high

Scope-risk: narrow

Directive: Do not collapse GitHub auth failures back to one re-auth message without preserving API-connectivity diagnostics

Tested: bash -n scripts/review-bot-watch.sh

Tested: bash -n templates/scripts/review-bot-watch.sh

Tested: node --test test/release.test.js

Tested: node --test test/agents.test.js

Co-authored-by: OmX <omx@oh-my-codex.dev>
@NagyVikt NagyVikt merged commit 7f2b3c9 into main May 8, 2026
@NagyVikt NagyVikt deleted the agent/codex/fix-gh-auth-network-diagnosis-2026-05-08-11-49 branch May 8, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant