Conversation
`protectedLiveClaimConflict` used `listTasks(1_000_000)` to find protected-branch claim conflicts on every editor tool call, then linearly filtered by repo_root and isProtectedBranch. With the task table growing into the thousands, this dominated p95 latency on the hot path and violated the <150ms hook-handler budget. Added `Storage.listProtectedBranchTasksByRepo(repoRoot)`, a single index-backed query against the existing `UNIQUE(repo_root, branch)` constraint on `tasks`. Replaced the unbounded scan with the new method. Defensive `resolve()` and `isProtectedBranch()` checks remain inside the loop so storage path inconsistencies still get filtered. Also picks up automatic biome formatting on three @colony/core files that #498 left over the column wrap threshold; behavior unchanged. Verification: - pnpm --filter @colony/storage test (117 passed, +1 new) - pnpm --filter @colony/hooks test (189 passed) - pnpm typecheck (clean) - pnpm lint (clean) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protectedLiveClaimConflictin the PreToolUse hot-path hook usedlistTasks(1_000_000)then linearly filtered byrepo_root+isProtectedBranch(branch). With the task table growing into the thousands across agents, this dominated p95 latency and violated the <150ms hook-handler budget.Storage.listProtectedBranchTasksByRepo(repoRoot)— a single index-backed query against the existingUNIQUE(repo_root, branch)constraint ontasks. No new migration needed.packages/hooks/src/handlers/pre-tool-use.ts:436. Defensiveresolve()andisProtectedBranch()JS-side checks stay in place so storage path inconsistencies still get filtered.ALL_TASKS_LIMITconstant removed (was only used at the replaced site).The diff also picks up automatic biome formatting on three @colony/core files that #498 left over the column-wrap threshold (no behavior change). Without those,
pnpm lintfails on this branch.Test plan
pnpm --filter @colony/storage test— 117 passed (+1 new:listProtectedBranchTasksByRepo returns only tasks on protected branches at the given repo)pnpm --filter @colony/hooks test— 189 passedpnpm typecheck— cleanpnpm lint— clean🤖 Generated with Claude Code