Documentation updates for migrating from CRA to Vite#70
Open
ammaaraslam wants to merge 3 commits intomainfrom
Open
Documentation updates for migrating from CRA to Vite#70ammaaraslam wants to merge 3 commits intomainfrom
ammaaraslam wants to merge 3 commits intomainfrom
Conversation
✅ Deploy Preview for react-play-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
supminn
reviewed
Aug 9, 2023
|
|
||
| - Continue developing your play. Happy coding. | ||
|
|
||
| > **Note:** When creating different component files for your play _(A separate file to create a component that includes JSX elements, like a custom button component for example)_, please use either a `.jsx`, `.ts` or `.tsx` file extension. This is due to our platform now using Vite for building. |
Contributor
There was a problem hiding this comment.
Would .ts be fine? As far as I understand, when we use React components with Vite, the file extension should either be .jsx or .tsx right?
Member
There was a problem hiding this comment.
we can use .js & .ts but we should use .jsx & .tsx
Member
|
@ammaaraslam Can you update me on the progress of this particular issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.