Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/upload/apq9xmpet |
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 73.96% 79.59% +5.62%
==========================================
Files 6 6
Lines 242 245 +3
Branches 58 58
==========================================
+ Hits 179 195 +16
+ Misses 63 50 -13
Continue to review full report at Codecov.
|
|
这样的话,onStart 会在 transformFile 之前执行,没有问题么? |
|
逻辑里看 onStart 在 promise 里总是会执行,给予的参数也是原始文件,改后测试也是通的。唯一的问题是这么改,action 如果失败了,它和原来逻辑就不一样了。我在看看 antd 侧有没有办法绕过去。所以这里先 draft 之。 |
|
This pull request introduces 1 alert when merging 8982f6b into 953e36a - view on LGTM.com new alerts:
|
|
rebase 一下 master,换了 github actions |
|
加了一个合成事件 |
|
This pull request introduces 1 alert when merging b0dc0a8 into 06a2cf7 - view on LGTM.com new alerts:
|
|
干脆 Update: 也不行, |
|
|
两个的用处本身有点不一样,beforeUpload 返回的结果决定是否继续上传,transformFile 返回的时候转换后的新文件. |
嗯,字面上是这么理解。但代码里我发现 |
|
梳理了一遍,感觉要做大 breaking change 才能一劳永逸了:
|
|
This pull request introduces 1 alert when merging 74df040 into 06a2cf7 - view on LGTM.com new alerts:
|
ref ant-design/ant-design#26536
onStart改成同步触发,让列表先准备好。PS:先别合