sync to develop by santoshcomcast · Pull Request #841 · rdkcentral/meta-rdk-video

santoshcomcast · 2025-06-26T06:11:56Z

No description provided.

CLAassistant · 2025-07-08T21:21:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
23 out of 24 committers have signed the CLA.

✅ dkumar798
✅ dwolaver
✅ preeja33
✅ ssitar583
✅ anusree23
✅ viveksinghnarwaria
✅ Saranya2421
✅ suppal045
✅ tabbas651
✅ AkshayKumar2794
✅ karuna2git
✅ Dosakaya
✅ anand-ky
✅ yuvaramachandran-gurusamy
✅ apatel859
✅ divyang-public
✅ hgfell683
✅ melhar098
✅ npoltorapavlo
✅ emutavchi
✅ mukesh972
✅ asurdej-comcast
✅ cmuhammedrafi
❌ svc_rdkgerrit02

svc_rdkgerrit02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-advanced-security · 2025-07-16T15:17:00Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 178 out of 180 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 179 out of 181 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T16:01:43Z

 	else
 		install -m 0644 ${S}/tr69hostif.service ${D}${systemd_unitdir}/system
 	fi
+    sed -i 's/@DSMGR_DEPENDENCY@/iarmbusd.service/' ${D}${systemd_unitdir}/system/tr69hostif.service


The sed command uses hardcoded path and patterns. Consider adding a comment explaining why this replacement is needed, or use a more maintainable approach like a .in template file with variables that can be substituted during the build.

Copilot · 2026-01-15T16:01:43Z

+#libsoup3 not compatible with gdial
+#DEPENDS:append =  " ${@bb.utils.contains('DISTRO_FEATURES', 'enable_libsoup3', ' libsoup ', ' libsoup-2.4 ', d)}"
+DEPENDS:append = " libsoup-2.4"


The commented-out conditional libsoup dependency logic should either be removed entirely or properly documented with a ticket reference explaining when libsoup3 support will be added. Leaving commented code without clear justification reduces maintainability.

Copilot · 2026-01-15T16:01:43Z

 LIC_FILES_CHKSUM = "file://LICENSE;md5=85bcfede74b96d9a58c6ea5d4b607e58"

-DEPENDS = "zlib wpeframework-tools-native rfc thunderhangrecovery"
+DEPENDS = "zlib wpeframework-tools-native rfc thunder-hang-recovery"


The dependency name changed from 'thunderhangrecovery' to 'thunder-hang-recovery'. Ensure this naming is consistent across the codebase and that the referenced recipe actually uses hyphens.

Copilot · 2026-01-15T16:01:44Z

+PR = "r39"
+PV = "4.4.3"


PR was decreased from r46 to r39, which is unusual. Package revisions should typically increment. This suggests potential version control issues or incorrect merge. Verify this is intentional.

Copilot · 2026-01-15T16:01:44Z

-Description=wpeframework
-Wants=network-online.target local-fs.target
-After= network-online.target local-fs.target securemount.service
+Description=wpeframework-Thunder RPC version-R4.4.3


The version number is hardcoded in the service description. Consider using a variable substitution like '@pv@' to keep the version synchronized with the recipe's PV variable automatically.

Copilot · 2026-01-15T16:01:45Z

-PR ?= "r0"
 S = "${WORKDIR}/git"

+PV = "1.0.1"


The version was downgraded from 3.0.0 to 1.0.1. This is a significant version decrease that needs explanation. Verify this is intentional and not a merge error, as downgrades can cause dependency issues.

Copilot · 2026-01-15T16:01:45Z

+                                case Core::ERROR_FIRMWAREUPDATE_UPTODATE:
+                                    response->Error.SetError(Core::ERROR_FIRMWAREUPDATE_UPTODATE);
+                                    response->Error.Text = _T("Firmware is already upto date");


The text "upto date" should be two words: "up to date".

Copilot · 2026-01-15T16:01:45Z

+Subject: [PATCH] comcast - RDKEMW-2744 - BitmapTextureGL - Check EGL context
+ before destruction
+
+For iPlayer application, when the app gets closed beeing autostarted


"beeing" should be "being".

Copilot

Pull request overview

Copilot reviewed 179 out of 181 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T15:08:34Z

 	else
 		install -m 0644 ${S}/tr69hostif.service ${D}${systemd_unitdir}/system
 	fi
+    sed -i 's/@DSMGR_DEPENDENCY@/iarmbusd.service/' ${D}${systemd_unitdir}/system/tr69hostif.service


The sed command to replace @DSMGR_DEPENDENCY@ should be indented consistently with the surrounding code. Currently it uses spaces while the rest of the file uses tabs.

Copilot · 2026-01-16T15:08:35Z

 PACKAGECONFIG[fhd]               = "-DVIDEO_DECODING_LIMIT=1920x1080@60,,"

-PACKAGECONFIG:append = " vp9_hdr dolbyvision breakpad native_video woff2 serviceworker"
+PACKAGECONFIG:append = " vp9_hdr breakpad native_video woff2 serviceworker"


The removal of 'dolbyvision' from PACKAGECONFIG:append is good, as the duplicate PACKAGECONFIG[dolbyvision] definition has been removed. However, the vp9_hdr PACKAGECONFIG is still defined twice (lines 91 and 120), which creates ambiguity.

Copilot · 2026-01-16T15:08:35Z

 +set(VERSION_MAJOR 4)
 +set(VERSION_MINOR 4)
 +set(VERSION_PATCH 1)
+set(VERSION_REVISION 3)


The VERSION_REVISION is set to 3 but this variable doesn't appear to be used in the VERSION assignment on the next line. Consider either using it in the version string or removing it if not needed.

Copilot

Pull request overview

Copilot reviewed 179 out of 181 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

recipes-extended/wpe-framework/wpeframework/r4.4/WorkerPool_Increase.patch:1

The WorkerPool_Increase.patch has been removed, but the WPEFRAMEWORK_THREADPOOL_COUNT has been increased from 8 to 16 in the recipe. Verify that this configuration change adequately replaces the removed patch functionality.
recipes-extended/wpe-framework/wpeframework-clientlibraries/r4.4/0001-RDK-28534-Security-Agent-Utility-and-Logging-ClientLibs.patch:1
A large security-related patch (395 lines) has been completely removed. Verify that the security functionality provided by this patch is no longer needed or has been replaced by alternative implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T19:24:59Z

 PACKAGECONFIG[touchevents]       = "-DENABLE_TOUCH_EVENTS=ON,-DENABLE_TOUCH_EVENTS=OFF,"
 PACKAGECONFIG[remoteinspector]   = "-DENABLE_REMOTE_INSPECTOR=ON,-DENABLE_REMOTE_INSPECTOR=OFF,"
-PACKAGECONFIG[vp9_hdr]           = "-DENABLE_HDR=ON,-DENABLE_HDR=OFF,,gstreamer1.0-plugins-good-matroska"
+PACKAGECONFIG[vp9_hdr]           = "-DENABLE_HDR=ON,-DENABLE_HDR=OFF,,"


The vp9_hdr PACKAGECONFIG appears twice in the file (lines 91 and 120 based on context). This duplication should be removed to avoid configuration conflicts.

Copilot · 2026-01-16T19:24:59Z

 LIC_FILES_CHKSUM = "file://LICENSE;md5=85bcfede74b96d9a58c6ea5d4b607e58"

-DEPENDS = "zlib wpeframework-tools-native rfc thunderhangrecovery"
+DEPENDS = "zlib wpeframework-tools-native rfc thunder-hang-recovery"


The dependency name has changed from 'thunderhangrecovery' (no hyphens) to 'thunder-hang-recovery' (with hyphens). Ensure this naming change is consistent across all recipes that depend on this component and that the recipe with the hyphenated name exists.

Copilot · 2026-01-16T19:24:59Z

-ExecStart=-/usr/bin/WPEFramework -b
+ExecStartPre=-/usr/bin/rdkLogMileStone WPE_FRAMEWORK_START
+SyslogIdentifier=WPEFramework
+ExecStart=/usr/bin/WPEFramework -b


The ExecStart command no longer includes the conditional config path logic that was previously handled by wpeframework_config_path.conf. If custom configuration paths are needed, this functionality may need to be restored or documented elsewhere.

Copilot

Pull request overview

Copilot reviewed 181 out of 183 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-20T14:55:54Z

 LIC_FILES_CHKSUM = "file://${THISDIR}/files/Apache-2.0;md5=3b83ef96387f14655fc854ddc3c6bd57"

-DEPENDS = "westeros essos rapidjson rtcore libuv gstreamer1.0 uwebsockets javascriptcore aamp websocketpp"
+DEPENDS = "westeros essos rapidjson rtcore libuv gstreamer1.0 uwebsockets javascriptcore websocketpp cjson boost"


The dependency 'aamp' is being removed from line 7. This should be verified to ensure AAMP bindings are still functional with the new ENABLE_AAMP_JSBINDINGS_DYNAMIC=ON configuration, as the dependency may still be needed at runtime even if dynamically linked.

Copilot · 2026-01-20T14:55:55Z

+DEPENDS = "zlib wpeframework-tools-native rfc thunder-hang-recovery"
 DEPENDS:append:libc-musl = " libexecinfo"
 DEPENDS += "breakpad-wrapper"

 # Need gst-svp-ext which is an abstracting lib for metadata
 DEPENDS +=  "${@bb.utils.contains('DISTRO_FEATURES', 'rdk_svp', 'gst-svp-ext', '', d)}"

-PR = "r46"
-PV = "4.4.1"
+PR = "r39"
+PV = "4.4.3"
+PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"

 SRC_URI = "git://github.com/rdkcentral/Thunder.git;protocol=https;branch=R4_4;name=thunder"

-SRCREV_thunder = "b81d0f079345739cc2d8ee142b3499be7e4e6b15"
+SRCREV_thunder = "19100433e5517c743738bb2a9ed8ce2f79c10eaf"

-#default patches for compiling thunder
 SRC_URI += "file://wpeframework-init \


The wpeframework_config_path.conf file is being deleted, but the corresponding FILES entry on line 181 is not being removed. This will cause a build warning or error since the file no longer exists in the package.

Copilot · 2026-01-20T14:55:55Z

+PR = "r0"
 PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"

+SRCREV = "d05547a1e693171e77b0532128f9322775c468a4"


The SRCREV values for tr69hostif and tr69hostif-headers are different (c9706ae0969ff5f713ad2747f986834dd5589a0c vs d05547a1e693171e77b0532128f9322775c468a4). These recipes should typically point to the same repository commit since the headers are part of the same project. This discrepancy could lead to API mismatches between the headers and the implementation.

Copilot · 2026-01-20T14:55:55Z

+PR = "r0"

-SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;${CMF_GITHUB_SRC_URI_SUFFIX}"
+SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;${CMF_GITHUB_SRC_URI_SUFFIX};"


A trailing semicolon is added to SRC_URI on line 19, which appears to be a syntax error in Yocto/BitBake. The SRC_URI should not have a trailing semicolon after the parameters.

Copilot

Pull request overview

Copilot reviewed 181 out of 183 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 181 out of 183 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 210 out of 212 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-22T19:29:36Z

+
+void ForceStopMediaElements()
+{
+    for (auto mediaElement : HTMLMediaElement::allMediaElements()) {
+        WTFLogAlways("Force stop '%s'", mediaElement->currentSrc().string().utf8().data());
+        ActiveDOMObject* obj = mediaElement.ptr();
+        obj->stop();
+    }
+}


ForceStopMediaElements logs mediaElement->currentSrc() via WTFLogAlways, which will emit full media URLs for every playing element when an empty or "about:blank" document is loaded. These URLs frequently contain per-session tokens, CDN query parameters or other sensitive identifiers, so writing them unredacted into logs can leak credentials or playback URLs to anyone with log access. Remove or downgrade this logging and, if logging is required, strip or anonymize query parameters and other sensitive parts of currentSrc before emitting it.

- Revert rialto version - Revert rialto-gstreamer version

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

RDKEMW-16160: Handle widevine14 for xi6

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

RDK-61007: Updated new service file for networkconnectionstats plugin

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Reason for Change: NetworkManager release v2.2.0 with following fixes - Added new method to connection to specific known SSID - Extended WiFiConnect method to support BSSID and specific Band - Defaulted to use RDKLogger and avoided redundant logging for few methods - Added Minimal Ethernet Connection Profile for migration handling - General improvements on RPC methods & crash resilience Test Procedure: NA Priority:P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>

…ideo into topic/RDKEMW-10793

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

RDKEMW-17603: Subtec release 1.8.0

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

RDKEMW-10793: Networkmanager plugin release v2.2.0

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

santoshcomcast requested review from a team as code owners June 26, 2025 06:11

Copilot AI review requested due to automatic review settings January 13, 2026 12:11

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 16:26

Copilot started reviewing on behalf of anand-ky January 13, 2026 16:26 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 15, 2026 15:58

Copilot started reviewing on behalf of anand-ky January 15, 2026 15:59 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 15:06

Copilot started reviewing on behalf of anand-ky January 16, 2026 15:07 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 19:22

Copilot started reviewing on behalf of anand-ky January 16, 2026 19:23 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 20, 2026 14:53

Copilot started reviewing on behalf of Rocksta818 January 20, 2026 14:53 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 21, 2026 06:28

Copilot started reviewing on behalf of tdeva14 January 21, 2026 06:28 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 16:18

Copilot started reviewing on behalf of anand-ky January 22, 2026 16:18 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 19:24

Copilot started reviewing on behalf of anand-ky January 22, 2026 19:25 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

varatharajan568 and others added 8 commits May 4, 2026 16:34

Update rialto_revision.inc

e6f8826

Update rialto_revision.inc

8c89a4c

Update rialto_revision.inc

22eefde

Update rialto_revision.inc

d8cef88

- Revert rialto version - Revert rialto-gstreamer version

Merge branch 'develop' into topic/RDKMVE-2173

b91c1e0

Merge pull request #3797 from rdkcentral/topic/RDKMVE-2173

51ae571

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

Merge branch 'develop' into feature/RDKEMW-16160

0ab86d5

Merge pull request #3745 from rdkcentral/feature/RDKEMW-16160

dec8d5c

RDKEMW-16160: Handle widevine14 for xi6

Copilot AI reviewed May 4, 2026

View reviewed changes

plaksh002c-public added 4 commits May 5, 2026 10:49

Merge branch 'develop' into topic/RDK-59986

7359f41

Merge pull request #3789 from rdkcentral/topic/RDK-59986

eb63623

RDK-61007: Updated new service file for networkconnectionstats plugin

Merge branch 'develop' into feature/RDKEMW-17520_ctrlm-v1.1.14

4a5b232

Merge pull request #3741 from rdkcentral/feature/RDKEMW-17520_ctrlm-v…

40d75c2

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot AI reviewed May 5, 2026

View reviewed changes

gururaajar and others added 7 commits May 5, 2026 16:50

Merge branch 'topic/RDKEMW-10793' of github.com:rdkcentral/meta-rdk-v…

58d991d

…ideo into topic/RDKEMW-10793

Merge branch 'develop' into topic/RDKEMW-10793

b3c1c94

Merge branch 'develop' into topic/RDKEMW-17603

f489785

RDK-61211: google cast auth extension (#3827)

d543680

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

Merge branch 'develop' into topic/RDKEMW-17603

545d2fe

Merge pull request #3751 from rdkcentral/topic/RDKEMW-17603

f3e3458

RDKEMW-17603: Subtec release 1.8.0

Copilot AI reviewed May 6, 2026

View reviewed changes

plaksh002c-public and others added 5 commits May 6, 2026 15:30

Merge branch 'develop' into topic/RDKEMW-10793

b4ee97b

Merge pull request #3833 from rdkcentral/topic/RDKEMW-10793

c1630b4

RDKEMW-10793: Networkmanager plugin release v2.2.0

Merge branch 'develop' into feature/RDKEMW-17411

8a0c73e

Merge branch 'develop' into topic/RDKEMW-17675

d1449b5

Merge pull request #3812 from rdkcentral/topic/RDKEMW-17675

daa2195

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot AI reviewed May 7, 2026

View reviewed changes

plaksh002c-public added 2 commits May 7, 2026 20:56

Merge branch 'develop' into feature/RDKEMW-17411

7b0a8d4

Merge pull request #3712 from rdkcentral/feature/RDKEMW-17411

367eef9

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

Conversation

santoshcomcast commented Jun 26, 2025

Uh oh!

CLAassistant commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-advanced-security AI commented Jul 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2026

CLAassistant commented Jul 8, 2025 •

edited

Loading