rebase by sindhu-krishnan · Pull Request #433 · rdkcentral/meta-rdk-video

sindhu-krishnan · 2025-05-18T16:26:14Z

No description provided.

CLAassistant · 2025-07-08T21:21:40Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
23 out of 24 committers have signed the CLA.

✅ dkumar798
✅ ssitar583
✅ hgfell683
✅ anusree23
✅ preeja33
✅ tabbas651
✅ suppal045
✅ viveksinghnarwaria
✅ AkshayKumar2794
✅ asurdej-comcast
✅ anand-ky
✅ npoltorapavlo
✅ Dosakaya
✅ Saranya2421
✅ emutavchi
✅ yuvaramachandran-gurusamy
✅ melhar098
✅ cmuhammedrafi
✅ karuna2git
✅ mukesh972
✅ dwolaver
✅ apatel859
✅ divyang-public
❌ svc_rdkgerrit02

svc_rdkgerrit02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Copilot

Pull request overview

This pull request performs a rebase operation across multiple Yocto/OpenEmbedded recipe files in the RDK build system. The changes primarily update source revisions (SRCREV), package versions (PV/PR), add new patch files, and modify build dependencies.

Changes:

Updates SRCREV values for numerous components to pin specific git commits
Adds new patch files for WPE-WebKit (HDR support, bug fixes, performance improvements)
Restructures WPEFramework dependencies and removes inline thunderHangRecovery in favor of separate recipe
Updates version numbers across multiple graphics, multimedia, and framework components

Reviewed changes

Copilot reviewed 192 out of 194 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
recipes-thirdparty/tr69hostif/*.bb	Updates SRCREV, adds telemetry dependency, enables powercontroller and t2api
recipes-multimedia/gstreamer/gst-plugins-rdk_git.bb	Removes conditional PV/PR assignments, adds SRCREV
recipes-graphics/waymetric/waymetric.bb	Changes from AUTOREV to fixed SRCREV
recipes-graphics/rdknativescript/rdknativescript_git.bb	Version bump to 2.0.1, adds container support, dependency updates
recipes-graphics/javascriptcore/javascriptcore_git.bb	Enables WebAssembly support
recipes-extended/wpe-webkit/*.bb	Major patch additions for HDR/DV support, bug fixes, PR bump to r12
recipes-extended/wpe-framework/wpeframework_4.4.bb	Version changes, dependency restructuring, removes internal thunderHangRecovery
recipes-extended/wpe-framework/wpeframework-clientlibraries_4.4.bb	Version bump, adds new patches for security and cryptography
recipes-extended/xr-voice-sdk/*.bb	Refactors to use .inc file for version management
recipes-extended/xdial/xdial.bb	Updates SRCREV, adds security token support
thunder-hang-recovery.bb	New recipe for Thunder hang detection/recovery
entservices-apis.bb	Version bump to 2.10.0 with IAuthService updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T19:33:30Z

+PR = "r39"
+PV = "4.4.3"


The PR version is being decreased from r46 to r39, and PV from 4.4.1 to 4.4.3. This is inconsistent - typically a version increase (4.4.1 → 4.4.3) should be accompanied by a PR increase, not a decrease (r46 → r39). This suggests the changes may not be properly sequenced or there's a merge conflict.

Copilot · 2026-01-12T19:33:31Z

 LIC_FILES_CHKSUM = "file://LICENSE;md5=85bcfede74b96d9a58c6ea5d4b607e58"

-DEPENDS = "zlib wpeframework-tools-native rfc"
+DEPENDS = "zlib wpeframework-tools-native rfc thunder-hang-recovery"


The patch file 'thunderHangRecovery.patch' is being removed (lines show deletions only). However, the dependency on 'thunder-hang-recovery' is being added on line 8. Verify that the thunder-hang-recovery recipe provides the required functionality that was previously in this patch.

Copilot · 2026-01-12T19:33:31Z

+PR = "r20"
+PV = "4.4.2"


The PR revision for wpeframework-clientlibraries is increasing from r15 to r20, and PV from 4.4.1 to 4.4.2, which is correct. However, the corresponding wpeframework recipe shows PR decreasing (r46→r39). These two closely related components should have consistent version progression patterns.

Copilot

Pull request overview

Copilot reviewed 192 out of 194 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 193 out of 195 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 193 out of 195 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T19:16:19Z

+ExecStartPost=/bin/touch /tmp/wpeframeworkstarted
 KillSignal=SIGKILL
 Restart=always


The ExecStop and ExecStopPost directives have been removed from the service file. These were responsible for cleaning up WPEFramework and WPEProcess on service stop. Without these, orphaned processes may remain after stopping the service, potentially causing issues on restart or consuming system resources.

Copilot · 2026-01-16T19:16:20Z

 LIC_FILES_CHKSUM = "file://${THISDIR}/files/Apache-2.0;md5=3b83ef96387f14655fc854ddc3c6bd57"

-DEPENDS = "westeros essos rapidjson rtcore libuv gstreamer1.0 uwebsockets javascriptcore aamp websocketpp"
+DEPENDS = "westeros essos rapidjson rtcore libuv gstreamer1.0 uwebsockets javascriptcore websocketpp cjson boost"


The 'aamp' dependency has been removed from the DEPENDS list for rdknativescript. If the codebase still uses AAMP functionality, this will cause build failures. Verify that AAMP is no longer needed or that it's provided through another mechanism.

Copilot · 2026-01-16T19:16:20Z

 DEPENDS = "iarmbus iarmmgrs e2fsprogs libsoup libsyswrapper yajl \
           devicesettings procps glib-2.0 \
-           cjson libtinyxml2\
+           cjson telemetry libtinyxml2\


The dependency 'telemetry' has been added to the DEPENDS list. Ensure that this dependency is available in the build environment and properly defined in other recipes, otherwise the build will fail.

Copilot · 2026-01-16T19:16:20Z

+PR = "r0"
 PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"

+SRCREV = "d05547a1e693171e77b0532128f9322775c468a4"


Two tr69hostif recipe files have different SRCREV values (c9706ae0969ff5f713ad2747f986834dd5589a0c vs d05547a1e693171e77b0532128f9322775c468a4). These should typically be synchronized to ensure consistency across the main and headers packages unless there's a specific reason for the divergence.

Copilot

Pull request overview

Copilot reviewed 195 out of 197 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T21:59:42Z

+  DEFS=" -DUSE_LIBUV"
+  CFLAGS="$CFLAGS $DEFS"
+  make -f Makefile CFLAGS="$CFLAGS"


The DEFS variable and CFLAGS modification should use proper BitBake variable syntax. Use EXTRA_OEMAKE or CFLAGS:append instead of shell variable manipulation within do_compile.

Copilot · 2026-01-16T21:59:42Z

-PR ?= "r0"
 S = "${WORKDIR}/git"

+PV = "1.0.1"


The version appears to be downgraded from 3.0.0 to 1.0.1. This could indicate a breaking change or revert that should be documented in commit messages to explain the rationale.

Copilot · 2026-01-16T21:59:43Z

 WPEFRAMEWORK_BINDING = "127.0.0.1"
 WPEFRAMEWORK_IDLE_TIME = "0"
-WPEFRAMEWORK_THREADPOOL_COUNT ?= "8"
+WPEFRAMEWORK_THREADPOOL_COUNT ?= "16"


The worker pool count has been doubled from 8 to 16. Ensure this change has been tested on target hardware as it may impact memory usage and system resources significantly.

Copilot · 2026-01-16T21:59:43Z

 PACKAGECONFIG[touchevents]       = "-DENABLE_TOUCH_EVENTS=ON,-DENABLE_TOUCH_EVENTS=OFF,"
 PACKAGECONFIG[remoteinspector]   = "-DENABLE_REMOTE_INSPECTOR=ON,-DENABLE_REMOTE_INSPECTOR=OFF,"
-PACKAGECONFIG[vp9_hdr]           = "-DENABLE_HDR=ON,-DENABLE_HDR=OFF,,gstreamer1.0-plugins-good-matroska"
+PACKAGECONFIG[vp9_hdr]           = "-DENABLE_HDR=ON,-DENABLE_HDR=OFF,,"


The gstreamer1.0-plugins-good-matroska dependency was removed from vp9_hdr PACKAGECONFIG but added to RDEPS_VIDEO in wpe-webkit.inc. This change should be documented to explain why it moved from build-time to runtime dependency.

Copilot · 2026-01-16T21:59:43Z

 Environment="FORCE_SVP=TRUE"
 Environment="FORCE_SAP=TRUE"
-ExecStart=-/usr/bin/WPEFramework -b
+ExecStartPre=-/usr/bin/rdkLogMileStone WPE_FRAMEWORK_START


The minus prefix "-" before ExecStartPre makes the command failure non-fatal. If rdkLogMileStone is not found, the service will start anyway. Consider whether this is intentional or if the dependency should be explicit.

Copilot · 2026-01-16T21:59:43Z

 	else
 		install -m 0644 ${S}/tr69hostif.service ${D}${systemd_unitdir}/system
 	fi
+    sed -i 's/@DSMGR_DEPENDENCY@/iarmbusd.service/' ${D}${systemd_unitdir}/system/tr69hostif.service


This sed command modifies the service file in do_install, but the service file template is not shown in the diff. Ensure the @DSMGR_DEPENDENCY@ placeholder exists in tr69hostif.service template.

Copilot · 2026-01-16T21:59:44Z

             result = Core::ERROR_PRIVILIGED_REQUEST;
         }
-+        SYSLOG(Logging::Startup, (_T("Activating plugin [%u] returned code"),result));
+        SYSLOG(Logging::Startup, (_T("Activating plugin [%s] returned %u"),callsign.c_str(), result));


Missing space after comma in format string parameters for better code readability: should be ", result" instead of ",result".

Copilot

Pull request overview

Copilot reviewed 195 out of 197 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 195 out of 197 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 224 out of 226 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Revert rialto version - Revert rialto-gstreamer version

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

RDKEMW-16160: Handle widevine14 for xi6

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

RDK-61007: Updated new service file for networkconnectionstats plugin

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Reason for Change: NetworkManager release v2.2.0 with following fixes - Added new method to connection to specific known SSID - Extended WiFiConnect method to support BSSID and specific Band - Defaulted to use RDKLogger and avoided redundant logging for few methods - Added Minimal Ethernet Connection Profile for migration handling - General improvements on RPC methods & crash resilience Test Procedure: NA Priority:P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>

…ideo into topic/RDKEMW-10793

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

RDKEMW-17603: Subtec release 1.8.0

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

RDKEMW-10793: Networkmanager plugin release v2.2.0

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

sindhu-krishnan requested review from a team as code owners May 18, 2025 16:26

Copilot AI review requested due to automatic review settings January 12, 2026 19:28

Copilot started reviewing on behalf of anand-ky January 12, 2026 19:29 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 16:00

Copilot started reviewing on behalf of anand-ky January 13, 2026 16:01 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 14, 2026 15:21

Copilot AI reviewed Jan 14, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 14:57

Copilot started reviewing on behalf of anand-ky January 16, 2026 14:57 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 19:13

Copilot started reviewing on behalf of anand-ky January 16, 2026 19:14 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 21:57

Copilot started reviewing on behalf of anand-ky January 16, 2026 21:57 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 20, 2026 19:00

Copilot started reviewing on behalf of anand-ky January 20, 2026 19:03 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 14:26

Copilot started reviewing on behalf of anand-ky January 22, 2026 14:27 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 18:23

Copilot started reviewing on behalf of emutavchi January 22, 2026 18:24 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 23, 2026 17:03

varatharajan568 and others added 8 commits May 4, 2026 16:34

Update rialto_revision.inc

e6f8826

Update rialto_revision.inc

8c89a4c

Update rialto_revision.inc

22eefde

Update rialto_revision.inc

d8cef88

- Revert rialto version - Revert rialto-gstreamer version

Merge branch 'develop' into topic/RDKMVE-2173

b91c1e0

Merge pull request #3797 from rdkcentral/topic/RDKMVE-2173

51ae571

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

Merge branch 'develop' into feature/RDKEMW-16160

0ab86d5

Merge pull request #3745 from rdkcentral/feature/RDKEMW-16160

dec8d5c

RDKEMW-16160: Handle widevine14 for xi6

Copilot AI reviewed May 4, 2026

View reviewed changes

plaksh002c-public added 4 commits May 5, 2026 10:49

Merge branch 'develop' into topic/RDK-59986

7359f41

Merge pull request #3789 from rdkcentral/topic/RDK-59986

eb63623

RDK-61007: Updated new service file for networkconnectionstats plugin

Merge branch 'develop' into feature/RDKEMW-17520_ctrlm-v1.1.14

4a5b232

Merge pull request #3741 from rdkcentral/feature/RDKEMW-17520_ctrlm-v…

40d75c2

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot AI reviewed May 5, 2026

View reviewed changes

gururaajar and others added 7 commits May 5, 2026 16:50

Merge branch 'topic/RDKEMW-10793' of github.com:rdkcentral/meta-rdk-v…

58d991d

…ideo into topic/RDKEMW-10793

Merge branch 'develop' into topic/RDKEMW-10793

b3c1c94

Merge branch 'develop' into topic/RDKEMW-17603

f489785

RDK-61211: google cast auth extension (#3827)

d543680

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

Merge branch 'develop' into topic/RDKEMW-17603

545d2fe

Merge pull request #3751 from rdkcentral/topic/RDKEMW-17603

f3e3458

RDKEMW-17603: Subtec release 1.8.0

Copilot AI reviewed May 6, 2026

View reviewed changes

plaksh002c-public and others added 5 commits May 6, 2026 15:30

Merge branch 'develop' into topic/RDKEMW-10793

b4ee97b

Merge pull request #3833 from rdkcentral/topic/RDKEMW-10793

c1630b4

RDKEMW-10793: Networkmanager plugin release v2.2.0

Merge branch 'develop' into feature/RDKEMW-17411

8a0c73e

Merge branch 'develop' into topic/RDKEMW-17675

d1449b5

Merge pull request #3812 from rdkcentral/topic/RDKEMW-17675

daa2195

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot AI reviewed May 7, 2026

View reviewed changes

plaksh002c-public added 2 commits May 7, 2026 20:56

Merge branch 'develop' into feature/RDKEMW-17411

7b0a8d4

Merge pull request #3712 from rdkcentral/feature/RDKEMW-17411

367eef9

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

Conversation

sindhu-krishnan commented May 18, 2025

Uh oh!

CLAassistant commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

CLAassistant commented Jul 8, 2025 •

edited

Loading