RDKEMW-16580: Switch WPE gamepad to libmanette and backport upstream rumble#3920
Open
petartijanic01 wants to merge 2 commits intodevelopfrom
Open
RDKEMW-16580: Switch WPE gamepad to libmanette and backport upstream rumble#3920petartijanic01 wants to merge 2 commits intodevelopfrom
petartijanic01 wants to merge 2 commits intodevelopfrom
Conversation
added 2 commits
May 7, 2026 11:49
Change-Id: I7dfb2ded12e589a4731034cf1d926ea0c241fccd
…369350dab) Change-Id: Idbd7293c403c2b8b83fca353e36891a37de506c8
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WPE WebKit 2.46 Yocto recipe to switch gamepad handling from the libwpe backend to libmanette, and backports gamepad rumble (playEffect/stopEffects) support via libmanette.
Changes:
- Add two WebKit patch backports: (1) switch WPE gamepad backend to libmanette, (2) implement rumble via libmanette.
- Add a
gamepadPACKAGECONFIG entry that pulls inlibmanettewhen ENABLE_GAMEPAD is used. - Bump the recipe PR revision.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| recipes-extended/wpe-webkit/wpe-webkit_2.46.bb | Adds the new patch files to SRC_URI, bumps PR, and introduces a gamepad PACKAGECONFIG dependency on libmanette. |
| recipes-extended/wpe-webkit/files/2.46/comcast-RDKEMW-16580-WPE-Switch-gamepad-backend-from-libwpe-to-libmanette.patch | Switches WPE gamepad provider wiring to the manette implementation and adds Manette CMake wiring. |
| recipes-extended/wpe-webkit/files/2.46/comcast-RDKEMW-16580-Backport-Implement-playEffect-via-libmanette-rumble.patch | Backports rumble support into Manette gamepad classes and enables vibration actuator defaults for WPE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+92
to
+93
| + if (m_effectCompletionHandler) | ||
| + m_effectCompletionHandler(false); |
Comment on lines
+116
to
+122
| + else | ||
| + m_effectCompletionHandler(true); | ||
| +} | ||
| + | ||
| +void ManetteGamepad::effectDurationTimerFired() | ||
| +{ | ||
| + m_effectCompletionHandler(true); |
Comment on lines
+130
to
+139
| @@ -232,6 +232,14 @@ | ||
| message(FATAL_ERROR "libwpe>=1.16.2 is required for ENABLE_GAMEPAD") | ||
| endif () | ||
|
|
||
| +if (ENABLE_GAMEPAD) | ||
| + find_package(Manette 0.2.4) | ||
| + if (NOT Manette_FOUND) | ||
| + message(FATAL_ERROR "libmanette is required for ENABLE_GAMEPAD") | ||
| + endif () | ||
| + SET_AND_EXPOSE_TO_BUILD(USE_MANETTE TRUE) |
petartijanic01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings gamepad rumble / haptic feedback (
GamepadHapticActuator.playEffect)to the WPE port on WebKit 2.46. Two commits:
Switch WPE gamepad backend from libwpe to libmanette — aligns WPE
with what GTK already does, drops
GamepadProviderLibWPE/UIGamepadProviderLibWPEfrom the WPE build, wires up the manetteequivalents, and adds
find_package(Manette 0.2.4)inOptionsWPE.cmake.Required as a prerequisite for commit 2.
Backport upstream
2e1369350dab— implementsplayEffect/stopEffectson top oflibmanette's rumble API. Direct cherry-pickof the upstream change with three small adaptations for 2.46:
WTFMoveinstead ofWTF::moveRunLoop::current()+ unnamedRunLoop::Timerctor (2.46 predatesRunLoop::currentSingleton()and the named-timer overload)PLATFORM(WPE)sincecommit 1 puts WPE on libmanette