RDKEMW-17526: Disable GPU memory accounting for service workers#3912
Open
asurdej-comcast wants to merge 1 commit intosupport/8.5.3.0from
Open
RDKEMW-17526: Disable GPU memory accounting for service workers#3912asurdej-comcast wants to merge 1 commit intosupport/8.5.3.0from
asurdej-comcast wants to merge 1 commit intosupport/8.5.3.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the WPEWebKit 2.38.8 Yocto recipe to apply a downstream WebKit patch that prevents incorrect/overflowing memory pressure footprint calculations in service worker web processes by disabling GPU memory accounting for those processes.
Changes:
- Bumped the recipe PR from
r16tor17. - Added a new patch to
SRC_URIfor WPEWebKit 2.38.8. - Introduced the patch implementing GPU memory accounting disablement for service worker processes and adding an underflow guard in footprint calculation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| recipes-extended/wpe-webkit/wpe-webkit_2.38.8.bb | Bumps PR and adds the new patch to SRC_URI. |
| recipes-extended/wpe-webkit/files/2.38.8/1651_Disable_GPU_mem_check_for_service_workers.patch | Adds WebKit/WTF changes to disable GPU memory accounting for service worker processes and avoid footprint underflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
40
to
+41
| SRC_URI += "file://2.38.8/1626_Video_decoding_limit.patch" | ||
| SRC_URI += "file://2.38.8/1651_Disable_GPU_mem_check_for_service_workers.patch" |
| + // or footprint and footprintVideo are coming from two different processes | ||
| + // and shouldn't be compared with each other. Both cases are misconfigurations. | ||
| + WTFLogAlways("Video memory footprint (%zu MB) is larger than total memory footprint (%zu MB). " | ||
| + "Check MemoryPressureHandler configuration\n", footprintVideo / MB, footprint / MB); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.