RDKEMW-17313: populating appinfra_versions in /opt/logs.#3905
Open
RDKEMW-17313: populating appinfra_versions in /opt/logs.#3905
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the middleware layer to support writing AppInfra component version information into the device’s log area under /opt/logs, by adding a helper script and updating the thunder-startup-services source revision.
Changes:
- Bump
thunderstartupservicesto a newer upstream commit viaSRCREV. - Add
pop_appinfra_version.shscript intended to update/opt/logs/version.txtwith AppGateway/AppManagers/CPC version lines (without duplication). - Install/package the new script from the
entservices-appgatewayrecipe into/usr/bin.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
recipes-extended/thunderstartupservices/thunderstartupservices.bb |
Updates SRCREV to pick up newer thunder-startup-services behavior. |
recipes-extended/entservices/files/pop_appinfra_version.sh |
New script that cleans/rewrites plugin version lines in /opt/logs/version.txt. |
recipes-extended/entservices/entservices-appgateway.bb |
Installs and packages the version population script alongside the AppGateway plugin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/rdkcentral/meta-rdk-video/sessions/2df6730d-038b-45b0-a240-b032e2b2bcf4 Co-authored-by: kvfasil <82154972+kvfasil@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rdkcentral/meta-rdk-video/sessions/2df6730d-038b-45b0-a240-b032e2b2bcf4 Co-authored-by: kvfasil <82154972+kvfasil@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rdkcentral/meta-rdk-video/sessions/2df6730d-038b-45b0-a240-b032e2b2bcf4 Co-authored-by: kvfasil <82154972+kvfasil@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rdkcentral/meta-rdk-video/sessions/2df6730d-038b-45b0-a240-b032e2b2bcf4 Co-authored-by: kvfasil <82154972+kvfasil@users.noreply.github.com>
| inherit cmake pkgconfig | ||
|
|
||
| SRC_URI = "${CMF_GITHUB_ROOT}/entservices-appgateway;${CMF_GITHUB_SRC_URI_SUFFIX}" | ||
| SRC_URI += "file://pop_appinfra_version.sh" |
Comment on lines
+7
to
+9
| APPGATEWAY_VERSION="/etc/appgatewayversion.txt" | ||
| APPMANAGER_VERSION="/etc/appmanagersversion.txt" | ||
| APPGATEWAY_CPC_VERSION="/etc/appgatewaycpcversion.txt" |
Comment on lines
+12
to
+15
| if [ -f /etc/device.properties ]; then | ||
| BUILD_TYPE=$(grep -m 1 "^BUILD_TYPE=" /etc/device.properties | cut -d '=' -f 2- | sed 's/^[[:space:]]*//; s/[[:space:]]*$//; s/^"//; s/"$//') | ||
| else | ||
| echo "Warning: /etc/device.properties not found." |
| @@ -0,0 +1,53 @@ | |||
| #!/bin/bash | |||
| # Script to populate /opt/logs/version.txt with appgateway, appmanager, and cpc versions | |||
… compatible Agent-Logs-Url: https://github.com/rdkcentral/meta-rdk-video/sessions/b2a4edfc-a799-40aa-9b91-682ac5e9e9ef Co-authored-by: kvfasil <82154972+kvfasil@users.noreply.github.com>
…rom packaged script
Comment on lines
+6
to
+10
| VERSION_FILE="/opt/logs/version.txt" | ||
| APPGATEWAY_VERSION="/etc/appgatewayversion.txt" | ||
| APPMANAGER_VERSION="/etc/appmanagersversion.txt" | ||
| APPGATEWAY_CPC_VERSION="/etc/appgatewaycpcversion.txt" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.