rebase#2814
Conversation
There was a problem hiding this comment.
Pull request overview
Updates multiple Yocto/BitBake recipes to newer upstream revisions and adjusts Thunder client libraries defaults to support disabling the Security Agent via a distro feature.
Changes:
- Bump
tr69hostif(and headers) recipes to PV 1.3.2 with updatedSRCREV. - Update
entservices-apisto PV 3.0.0 with updated taggedSRCREV. - Bump
sysintto PV 4.3.1 with updatedSRCREV. - Make
securityagentinwpeframework-clientlibraries_4.4.bbconditional onDISTRO_FEATURES(thunder_security_disable).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-thirdparty/tr69hostif/tr69hostif_git.bb | Updates TR69 host interface source revision and package version. |
| recipes-thirdparty/tr69hostif/tr69hostif-headers_git.bb | Keeps headers recipe aligned with tr69hostif version and SRCREV. |
| recipes-extended/wpe-framework/wpeframework-clientlibraries_4.4.bb | Gates securityagent PACKAGECONFIG on thunder_security_disable distro feature. |
| recipes-extended/wpe-framework/entservices-apis.bb | Moves entservices-apis recipe to the 3.0.0 tag/revision. |
| recipes-extended/sysint/sysint_git.bb | Updates sysint source revision and package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| FILESEXTRAPATHS:prepend := "${THISDIR}:" | ||
| DEPENDS = "westeros wayland essos virtual/egl rapidjson jpeg libpng curl" | ||
|
|
||
| DEPENDS:append = "${@bb.utils.contains_any('DISTRO_FEATURES', 'prodlog-variant prod-variant', '', 'libsoup-2.4 boost libsyswrapper', d)}" |
There was a problem hiding this comment.
DEPENDS:append appends text verbatim, so when the conditional is non-empty this will concatenate onto the previous dependency (e.g., curllibsoup-2.4) and break dependency parsing. Add a leading space in the appended string (or use DEPENDS += / DEPENDS:append = " <deps>").
| DEPENDS:append = "${@bb.utils.contains_any('DISTRO_FEATURES', 'prodlog-variant prod-variant', '', 'libsoup-2.4 boost libsyswrapper', d)}" | |
| DEPENDS:append = " ${@bb.utils.contains_any('DISTRO_FEATURES', 'prodlog-variant prod-variant', '', 'libsoup-2.4 boost libsyswrapper', d)}" |
| install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir} | ||
| fi | ||
| if [ -d ${B}/extensions/firebolt_surface ]; then | ||
| install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/ | ||
| install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/ | ||
| install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir} | ||
| fi | ||
| if [ -d ${B}/extensions/firebolt_wm ]; then | ||
| install -m 755 ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ${D}/${libdir}/ | ||
| install -m 755 ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ${D}/${libdir}/plugins/westeros/ | ||
| install -m 644 ${S}/extensions/firebolt_wm/include/firebolt_wm_protocol_client.h ${D}/${includedir} |
There was a problem hiding this comment.
These extension protocol headers are being installed directly into ${includedir} (e.g., /usr/include) rather than a package-specific subdirectory, which increases the chance of header name collisions and makes ownership unclear. Install them under a namespaced path like ${includedir}/rdkwindowmanager/ (consistent with the later ${includedir}/rdkwindowmanager/include/ install).
| install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir} | |
| fi | |
| if [ -d ${B}/extensions/firebolt_surface ]; then | |
| install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/ | |
| install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/ | |
| install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir} | |
| fi | |
| if [ -d ${B}/extensions/firebolt_wm ]; then | |
| install -m 755 ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ${D}/${libdir}/ | |
| install -m 755 ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ${D}/${libdir}/plugins/westeros/ | |
| install -m 644 ${S}/extensions/firebolt_wm/include/firebolt_wm_protocol_client.h ${D}/${includedir} | |
| install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}${includedir}/rdkwindowmanager/include/ | |
| fi | |
| if [ -d ${B}/extensions/firebolt_surface ]; then | |
| install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/ | |
| install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/ | |
| install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}${includedir}/rdkwindowmanager/include/ | |
| fi | |
| if [ -d ${B}/extensions/firebolt_wm ]; then | |
| install -m 755 ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ${D}/${libdir}/ | |
| install -m 755 ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ${D}/${libdir}/plugins/westeros/ | |
| install -m 644 ${S}/extensions/firebolt_wm/include/firebolt_wm_protocol_client.h ${D}${includedir}/rdkwindowmanager/include/ |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -DSECAPI_LIB=sec_api \ | ||
| -DPLUGIN_NATIVEJS=ON \ | ||
| -DPLUGIN_NATIVEJS_CLIENTIDENTIFIER="${NATIVEJS_CLIENTIDENTIFIER}" \ | ||
| -DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=ON \ |
There was a problem hiding this comment.
-DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=ON is enabled unconditionally, even though telemetry metrics is controlled via PACKAGECONFIG[telemetrymetrics]. This makes it impossible to fully disable telemetry-metrics support via PACKAGECONFIG and can lead to unexpected build/runtime behavior when the option is turned off. Consider gating this CMake flag on the telemetrymetrics PACKAGECONFIG as well.
| -DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=ON \ | |
| ${@bb.utils.contains('PACKAGECONFIG', 'telemetrymetrics', '-DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=ON', '-DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=OFF', d)} \ |
| SRCREV = "17315e005519fa0100d6a43081429c5d53198ca3" | ||
|
|
||
| SRC_URI = "${CMF_GITHUB_ROOT}/tr69hostif;${CMF_GITHUB_SRC_URI_SUFFIX};name=tr69hostif" | ||
| PV = "1.3.0" | ||
| PV = "1.3.2" |
There was a problem hiding this comment.
The PR title is "rebase", but the changes include multiple version bumps, new recipes, and a new WPE WebKit patch. Consider updating the PR title/description to reflect the actual scope so reviewers and release tooling can track what is changing.
| LIC_FILES_CHKSUM = "file://LICENSE;md5=9adde9d5cb6e9c095d3e3abf0e9500f1" | ||
|
|
||
| PV ?= "1.0.0" | ||
| PV ?= "0.1.0.0" |
There was a problem hiding this comment.
PV is being changed from 1.0.0 to 0.1.0.0, which is a version downgrade from the package manager's perspective and can break upgrades/feed ordering. If this isn't intentional, keep PV monotonic (or align it to the upstream tag/version you’re tracking).
| PV ?= "0.1.0.0" | |
| PV ?= "1.0.0.1" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| LIC_FILES_CHKSUM = "file://LICENSE;md5=9adde9d5cb6e9c095d3e3abf0e9500f1" | ||
|
|
||
| PV ?= "1.0.0" | ||
| PV ?= "0.1.0.0" |
There was a problem hiding this comment.
This changes the default PV from 1.0.0 to 0.1.0.0, which is a version downgrade. If this package is delivered via feeds/package managers, a downgraded version can prevent upgrades or cause unexpected dependency resolution. If the intent is to align with an upstream tag, consider using a monotonically increasing PV (or append +git${SRCPV}) to avoid regressions.
| PV ?= "0.1.0.0" | |
| PV ?= "1.0.0+git${SRCPV}" |
| WPEFRAMEWORK_BINDING = "127.0.0.1" | ||
| WPEFRAMEWORK_IDLE_TIME = "0" | ||
| WPEFRAMEWORK_THREADPOOL_COUNT ?= "16" | ||
| WPEFRAMEWORK_THREADPOOL_COUNT ?= "32" |
There was a problem hiding this comment.
Doubling the default threadpool size from 16 to 32 can materially increase baseline CPU/memory usage and thread scheduling overhead across all builds that don’t override this variable. If this is targeting only certain devices, consider making it conditional (e.g., by MACHINE, CPU count, or a DISTRO_FEATURE) or documenting the rationale/expected impact next to the setting.
| WPEFRAMEWORK_THREADPOOL_COUNT ?= "32" | |
| # Default threadpool size is 16. Distros that opt-in to a larger pool | |
| # (and accept the additional baseline CPU/memory cost) can enable | |
| # 'wpe_threadpool_32' in DISTRO_FEATURES to use 32 threads instead. | |
| WPEFRAMEWORK_THREADPOOL_COUNT ?= "${@bb.utils.contains('DISTRO_FEATURES', 'wpe_threadpool_32', '32', '16', d)}" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
| if ${@bb.utils.contains('DISTRO_FEATURES', 'thunder_startup_services', 'true', 'false', d)} == 'true'; then | ||
| if [ -d "${D}/etc/WPEFramework/plugins" ]; then | ||
| find ${D}/etc/WPEFramework/plugins/ -type f | xargs sed -i -r 's/"autostart"[[:space:]]*:[[:space:]]*true/"autostart":false/g' |
There was a problem hiding this comment.
Using find … | xargs sed … without xargs -r/--no-run-if-empty (or an equivalent guard) can cause sed to be invoked with no input files when the plugins directory exists but contains no regular files, which can make do_install fail.
Suggestion: switch to find … -exec sed … {} + or add xargs -r (and ideally -print0/xargs -0) so the install step is robust when no files match.
| find ${D}/etc/WPEFramework/plugins/ -type f | xargs sed -i -r 's/"autostart"[[:space:]]*:[[:space:]]*true/"autostart":false/g' | |
| find ${D}/etc/WPEFramework/plugins/ -type f -exec sed -i -r 's/"autostart"[[:space:]]*:[[:space:]]*true/"autostart":false/g' {} + |
| @@ -0,0 +1,79 @@ | |||
| SUMMARY = "ENTServices MiraCast plugin" | |||
There was a problem hiding this comment.
The summary uses the capitalization "MiraCast"; the common spelling is "Miracast". Consider updating this to avoid inconsistent naming in package metadata/search.
| SUMMARY = "ENTServices MiraCast plugin" | |
| SUMMARY = "ENTServices Miracast plugin" |
| install -d ${D}${includedir}/rdkwindowmanager/include/ | ||
| install -m 644 ${S}/include/*.h ${D}${includedir}/rdkwindowmanager/include/ | ||
| } | ||
|
|
||
| INSANE_SKIP:${PN} = "installed-vs-shipped" | ||
| INSANE_SKIP:${PN} += "dev-so" |
There was a problem hiding this comment.
This recipe installs public headers into ${includedir}/rdkwindowmanager/include/ (do_install) but the headers aren’t added to any FILES:* entry. The current INSANE_SKIP:${PN}="installed-vs-shipped" masks the resulting QA issue and means the headers won’t be shipped in any package (e.g., ${PN}-dev), which can break consumers expecting them from the -dev package/SDK.
Suggestion: package the headers explicitly (typically in ${PN}-dev) and remove the installed-vs-shipped skip if possible (or at least limit it to the specific, unavoidable paths).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| + // Enable RDKAT to process WebKit event into real speech (if TTS enabled) | ||
| + WTFLogAlways("Enable RDKAT processing for WPE."); | ||
| + | ||
| + WebCore::AXObjectCache::enableAccessibility(); |
There was a problem hiding this comment.
WTFLogAlways("Enable RDKAT processing for WPE.") introduces an unconditional always-on log at WebProcess initialization time, which can add noise to production logs (and happens for every WebProcess start). Consider using an existing release/debug logging channel, making it conditional (e.g., behind a compile-time flag or runtime setting), or removing it once validated.
| if [ -d ${B}/extensions/firebolt_shell ]; then | ||
| install -m 755 ${B}/extensions/firebolt_shell/librdkwmextfireboltshell.so ${D}/${libdir}/ | ||
| install -m 755 ${B}/extensions/firebolt_shell/libwstplugin_rdkwmfireboltshell.so ${D}/${libdir}/plugins/westeros/ | ||
| install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir} | ||
| fi | ||
| if [ -d ${B}/extensions/firebolt_surface ]; then | ||
| install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/ | ||
| install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/ | ||
| install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir} | ||
| fi | ||
| if [ -d ${B}/extensions/firebolt_wm ]; then |
There was a problem hiding this comment.
do_install() checks only that the extension directory exists (-d ${B}/extensions/firebolt_shell) before installing shared objects from it. In CMake builds the directory can exist even when the library/plugin wasn't built, which would make install fail and break the recipe. Check for the specific output files (e.g., -f .../librdkwmextfireboltshell.so and -f .../libwstplugin_...so) before installing, or gate the whole block on the relevant CMake option being enabled.
| if [ -d ${B}/extensions/firebolt_shell ]; then | |
| install -m 755 ${B}/extensions/firebolt_shell/librdkwmextfireboltshell.so ${D}/${libdir}/ | |
| install -m 755 ${B}/extensions/firebolt_shell/libwstplugin_rdkwmfireboltshell.so ${D}/${libdir}/plugins/westeros/ | |
| install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir} | |
| fi | |
| if [ -d ${B}/extensions/firebolt_surface ]; then | |
| install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/ | |
| install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/ | |
| install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir} | |
| fi | |
| if [ -d ${B}/extensions/firebolt_wm ]; then | |
| if [ -f ${B}/extensions/firebolt_shell/librdkwmextfireboltshell.so ] && \ | |
| [ -f ${B}/extensions/firebolt_shell/libwstplugin_rdkwmfireboltshell.so ]; then | |
| install -m 755 ${B}/extensions/firebolt_shell/librdkwmextfireboltshell.so ${D}/${libdir}/ | |
| install -m 755 ${B}/extensions/firebolt_shell/libwstplugin_rdkwmfireboltshell.so ${D}/${libdir}/plugins/westeros/ | |
| install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir} | |
| fi | |
| if [ -f ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ] && \ | |
| [ -f ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ]; then | |
| install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/ | |
| install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/ | |
| install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir} | |
| fi | |
| if [ -f ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ] && \ | |
| [ -f ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ]; then |
| if [ -d ${B}/extensions/firebolt_surface ]; then | ||
| install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/ | ||
| install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/ | ||
| install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir} | ||
| fi | ||
| if [ -d ${B}/extensions/firebolt_wm ]; then | ||
| install -m 755 ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ${D}/${libdir}/ | ||
| install -m 755 ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ${D}/${libdir}/plugins/westeros/ | ||
| install -m 644 ${S}/extensions/firebolt_wm/include/firebolt_wm_protocol_client.h ${D}/${includedir} | ||
| fi |
There was a problem hiding this comment.
Same issue as above for the firebolt_surface/firebolt_wm extension blocks: checking -d on the build directory doesn’t guarantee the .so files exist, so install can fail. Prefer checking -f for each artifact (or a single condition that ensures the extension was built) before installing.
| install -m 644 ${S}/include/*.h ${D}${includedir}/rdkwindowmanager/include/ | ||
| } | ||
|
|
||
| INSANE_SKIP:${PN} = "installed-vs-shipped" |
There was a problem hiding this comment.
INSANE_SKIP:${PN} = "installed-vs-shipped" overwrites any existing INSANE_SKIP:${PN} values that may be set by inherited classes/includes. If the intent is only to add skips, use += for all entries (or explain why overriding is required).
| INSANE_SKIP:${PN} = "installed-vs-shipped" | |
| INSANE_SKIP:${PN} += "installed-vs-shipped" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| telemetrysupport \ | ||
| ledcontrol \ | ||
| " | ||
|
|
There was a problem hiding this comment.
The PACKAGECONFIG variable includes 'breakpadsupport' but there is no corresponding PACKAGECONFIG[breakpadsupport] definition. This definition is needed to specify how the build system should handle this configuration option. Other similar recipes in the codebase (e.g., entservices-miracast.bb, entservices-xcast.bb, entservices-peripherals.bb) include the definition: PACKAGECONFIG[breakpadsupport] = ",,breakpad-wrapper,breakpad-wrapper"
| PACKAGECONFIG[breakpadsupport] = ",,breakpad-wrapper,breakpad-wrapper" |
Signed-off-by: Varatharajan_Narayanan <Varatharajan_Narayanan@comcast.com>
- Revert rialto version - Revert rialto-gstreamer version
RDKEMW-17821 : Sceneset changes to include new preinstall changes.
RDKEMW-16160: Handle widevine14 for xi6
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 146 out of 146 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -12,17 +12,15 @@ SRC_URI = "${CMF_GITHUB_ROOT}/entservices-softwareupdate;${CMF_GITHUB_SRC_URI_SU | |||
| file://0001-RDKTV-20749-Revert-Merge-pull-request-3336-from-npol.patch \ | |||
| " | |||
|
|
|||
| # Release version - 1.9.0 | |||
| SRCREV = "4117d05afca7f884ed362d3a676294672c4a4217" | |||
| # Release version - 1.15.0 | |||
| SRCREV = "45480b833d5ec7662405affb0bf7c6902f4664cf" | |||
RDK-61007: Updated new service file for networkconnectionstats plugin
…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14
Reason for Change: NetworkManager release v2.2.0 with following fixes - Added new method to connection to specific known SSID - Extended WiFiConnect method to support BSSID and specific Band - Defaulted to use RDKLogger and avoided redundant logging for few methods - Added Minimal Ethernet Connection Profile for migration handling - General improvements on RPC methods & crash resilience Test Procedure: NA Priority:P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
…ideo into topic/RDKEMW-10793
Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8
RDKEMW-17603: Subtec release 1.8.0
RDKEMW-10793: Networkmanager plugin release v2.2.0
RDKEMW-17675: App Managers 0.4.0.1 Release Integration
RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1
No description provided.