Skip to content

rebase#2814

Open
Sonajeya31 wants to merge 719 commits intotopic/rdkemw-13233-1from
develop
Open

rebase#2814
Sonajeya31 wants to merge 719 commits intotopic/rdkemw-13233-1from
develop

Conversation

@Sonajeya31
Copy link
Copy Markdown
Contributor

No description provided.

@Sonajeya31 Sonajeya31 requested review from a team as code owners February 12, 2026 10:34
Copilot AI review requested due to automatic review settings February 12, 2026 10:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates multiple Yocto/BitBake recipes to newer upstream revisions and adjusts Thunder client libraries defaults to support disabling the Security Agent via a distro feature.

Changes:

  • Bump tr69hostif (and headers) recipes to PV 1.3.2 with updated SRCREV.
  • Update entservices-apis to PV 3.0.0 with updated tagged SRCREV.
  • Bump sysint to PV 4.3.1 with updated SRCREV.
  • Make securityagent in wpeframework-clientlibraries_4.4.bb conditional on DISTRO_FEATURES (thunder_security_disable).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
recipes-thirdparty/tr69hostif/tr69hostif_git.bb Updates TR69 host interface source revision and package version.
recipes-thirdparty/tr69hostif/tr69hostif-headers_git.bb Keeps headers recipe aligned with tr69hostif version and SRCREV.
recipes-extended/wpe-framework/wpeframework-clientlibraries_4.4.bb Gates securityagent PACKAGECONFIG on thunder_security_disable distro feature.
recipes-extended/wpe-framework/entservices-apis.bb Moves entservices-apis recipe to the 3.0.0 tag/revision.
recipes-extended/sysint/sysint_git.bb Updates sysint source revision and package version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 12, 2026 21:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 13, 2026 16:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FILESEXTRAPATHS:prepend := "${THISDIR}:"
DEPENDS = "westeros wayland essos virtual/egl rapidjson jpeg libpng curl"

DEPENDS:append = "${@bb.utils.contains_any('DISTRO_FEATURES', 'prodlog-variant prod-variant', '', 'libsoup-2.4 boost libsyswrapper', d)}"
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPENDS:append appends text verbatim, so when the conditional is non-empty this will concatenate onto the previous dependency (e.g., curllibsoup-2.4) and break dependency parsing. Add a leading space in the appended string (or use DEPENDS += / DEPENDS:append = " <deps>").

Suggested change
DEPENDS:append = "${@bb.utils.contains_any('DISTRO_FEATURES', 'prodlog-variant prod-variant', '', 'libsoup-2.4 boost libsyswrapper', d)}"
DEPENDS:append = " ${@bb.utils.contains_any('DISTRO_FEATURES', 'prodlog-variant prod-variant', '', 'libsoup-2.4 boost libsyswrapper', d)}"

Copilot uses AI. Check for mistakes.
Comment on lines +35 to +45
install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_surface ]; then
install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_wm ]; then
install -m 755 ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_wm/include/firebolt_wm_protocol_client.h ${D}/${includedir}
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extension protocol headers are being installed directly into ${includedir} (e.g., /usr/include) rather than a package-specific subdirectory, which increases the chance of header name collisions and makes ownership unclear. Install them under a namespaced path like ${includedir}/rdkwindowmanager/ (consistent with the later ${includedir}/rdkwindowmanager/include/ install).

Suggested change
install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_surface ]; then
install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_wm ]; then
install -m 755 ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_wm/include/firebolt_wm_protocol_client.h ${D}/${includedir}
install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}${includedir}/rdkwindowmanager/include/
fi
if [ -d ${B}/extensions/firebolt_surface ]; then
install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}${includedir}/rdkwindowmanager/include/
fi
if [ -d ${B}/extensions/firebolt_wm ]; then
install -m 755 ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_wm/include/firebolt_wm_protocol_client.h ${D}${includedir}/rdkwindowmanager/include/

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 13, 2026 18:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

-DSECAPI_LIB=sec_api \
-DPLUGIN_NATIVEJS=ON \
-DPLUGIN_NATIVEJS_CLIENTIDENTIFIER="${NATIVEJS_CLIENTIDENTIFIER}" \
-DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=ON \
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=ON is enabled unconditionally, even though telemetry metrics is controlled via PACKAGECONFIG[telemetrymetrics]. This makes it impossible to fully disable telemetry-metrics support via PACKAGECONFIG and can lead to unexpected build/runtime behavior when the option is turned off. Consider gating this CMake flag on the telemetrymetrics PACKAGECONFIG as well.

Suggested change
-DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=ON \
${@bb.utils.contains('PACKAGECONFIG', 'telemetrymetrics', '-DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=ON', '-DAIMANAGERS_TELEMETRY_METRICS_SUPPORT=OFF', d)} \

Copilot uses AI. Check for mistakes.
Comment on lines +7 to +10
SRCREV = "17315e005519fa0100d6a43081429c5d53198ca3"

SRC_URI = "${CMF_GITHUB_ROOT}/tr69hostif;${CMF_GITHUB_SRC_URI_SUFFIX};name=tr69hostif"
PV = "1.3.0"
PV = "1.3.2"
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is "rebase", but the changes include multiple version bumps, new recipes, and a new WPE WebKit patch. Consider updating the PR title/description to reflect the actual scope so reviewers and release tooling can track what is changing.

Copilot uses AI. Check for mistakes.
LIC_FILES_CHKSUM = "file://LICENSE;md5=9adde9d5cb6e9c095d3e3abf0e9500f1"

PV ?= "1.0.0"
PV ?= "0.1.0.0"
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PV is being changed from 1.0.0 to 0.1.0.0, which is a version downgrade from the package manager's perspective and can break upgrades/feed ordering. If this isn't intentional, keep PV monotonic (or align it to the upstream tag/version you’re tracking).

Suggested change
PV ?= "0.1.0.0"
PV ?= "1.0.0.1"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 17, 2026 15:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

LIC_FILES_CHKSUM = "file://LICENSE;md5=9adde9d5cb6e9c095d3e3abf0e9500f1"

PV ?= "1.0.0"
PV ?= "0.1.0.0"
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the default PV from 1.0.0 to 0.1.0.0, which is a version downgrade. If this package is delivered via feeds/package managers, a downgraded version can prevent upgrades or cause unexpected dependency resolution. If the intent is to align with an upstream tag, consider using a monotonically increasing PV (or append +git${SRCPV}) to avoid regressions.

Suggested change
PV ?= "0.1.0.0"
PV ?= "1.0.0+git${SRCPV}"

Copilot uses AI. Check for mistakes.
WPEFRAMEWORK_BINDING = "127.0.0.1"
WPEFRAMEWORK_IDLE_TIME = "0"
WPEFRAMEWORK_THREADPOOL_COUNT ?= "16"
WPEFRAMEWORK_THREADPOOL_COUNT ?= "32"
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubling the default threadpool size from 16 to 32 can materially increase baseline CPU/memory usage and thread scheduling overhead across all builds that don’t override this variable. If this is targeting only certain devices, consider making it conditional (e.g., by MACHINE, CPU count, or a DISTRO_FEATURE) or documenting the rationale/expected impact next to the setting.

Suggested change
WPEFRAMEWORK_THREADPOOL_COUNT ?= "32"
# Default threadpool size is 16. Distros that opt-in to a larger pool
# (and accept the additional baseline CPU/memory cost) can enable
# 'wpe_threadpool_32' in DISTRO_FEATURES to use 32 threads instead.
WPEFRAMEWORK_THREADPOOL_COUNT ?= "${@bb.utils.contains('DISTRO_FEATURES', 'wpe_threadpool_32', '32', '16', d)}"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 17, 2026 22:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 19, 2026 05:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fi
if ${@bb.utils.contains('DISTRO_FEATURES', 'thunder_startup_services', 'true', 'false', d)} == 'true'; then
if [ -d "${D}/etc/WPEFramework/plugins" ]; then
find ${D}/etc/WPEFramework/plugins/ -type f | xargs sed -i -r 's/"autostart"[[:space:]]*:[[:space:]]*true/"autostart":false/g'
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using find … | xargs sed … without xargs -r/--no-run-if-empty (or an equivalent guard) can cause sed to be invoked with no input files when the plugins directory exists but contains no regular files, which can make do_install fail.

Suggestion: switch to find … -exec sed … {} + or add xargs -r (and ideally -print0/xargs -0) so the install step is robust when no files match.

Suggested change
find ${D}/etc/WPEFramework/plugins/ -type f | xargs sed -i -r 's/"autostart"[[:space:]]*:[[:space:]]*true/"autostart":false/g'
find ${D}/etc/WPEFramework/plugins/ -type f -exec sed -i -r 's/"autostart"[[:space:]]*:[[:space:]]*true/"autostart":false/g' {} +

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,79 @@
SUMMARY = "ENTServices MiraCast plugin"
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The summary uses the capitalization "MiraCast"; the common spelling is "Miracast". Consider updating this to avoid inconsistent naming in package metadata/search.

Suggested change
SUMMARY = "ENTServices MiraCast plugin"
SUMMARY = "ENTServices Miracast plugin"

Copilot uses AI. Check for mistakes.
Comment on lines +60 to +65
install -d ${D}${includedir}/rdkwindowmanager/include/
install -m 644 ${S}/include/*.h ${D}${includedir}/rdkwindowmanager/include/
}

INSANE_SKIP:${PN} = "installed-vs-shipped"
INSANE_SKIP:${PN} += "dev-so"
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recipe installs public headers into ${includedir}/rdkwindowmanager/include/ (do_install) but the headers aren’t added to any FILES:* entry. The current INSANE_SKIP:${PN}="installed-vs-shipped" masks the resulting QA issue and means the headers won’t be shipped in any package (e.g., ${PN}-dev), which can break consumers expecting them from the -dev package/SDK.

Suggestion: package the headers explicitly (typically in ${PN}-dev) and remove the installed-vs-shipped skip if possible (or at least limit it to the specific, unavoidable paths).

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 19, 2026 14:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +49 to +52
+ // Enable RDKAT to process WebKit event into real speech (if TTS enabled)
+ WTFLogAlways("Enable RDKAT processing for WPE.");
+
+ WebCore::AXObjectCache::enableAccessibility();
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTFLogAlways("Enable RDKAT processing for WPE.") introduces an unconditional always-on log at WebProcess initialization time, which can add noise to production logs (and happens for every WebProcess start). Consider using an existing release/debug logging channel, making it conditional (e.g., behind a compile-time flag or runtime setting), or removing it once validated.

Copilot uses AI. Check for mistakes.
Comment on lines +32 to +42
if [ -d ${B}/extensions/firebolt_shell ]; then
install -m 755 ${B}/extensions/firebolt_shell/librdkwmextfireboltshell.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_shell/libwstplugin_rdkwmfireboltshell.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_surface ]; then
install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_wm ]; then
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do_install() checks only that the extension directory exists (-d ${B}/extensions/firebolt_shell) before installing shared objects from it. In CMake builds the directory can exist even when the library/plugin wasn't built, which would make install fail and break the recipe. Check for the specific output files (e.g., -f .../librdkwmextfireboltshell.so and -f .../libwstplugin_...so) before installing, or gate the whole block on the relevant CMake option being enabled.

Suggested change
if [ -d ${B}/extensions/firebolt_shell ]; then
install -m 755 ${B}/extensions/firebolt_shell/librdkwmextfireboltshell.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_shell/libwstplugin_rdkwmfireboltshell.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_surface ]; then
install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_wm ]; then
if [ -f ${B}/extensions/firebolt_shell/librdkwmextfireboltshell.so ] && \
[ -f ${B}/extensions/firebolt_shell/libwstplugin_rdkwmfireboltshell.so ]; then
install -m 755 ${B}/extensions/firebolt_shell/librdkwmextfireboltshell.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_shell/libwstplugin_rdkwmfireboltshell.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_shell/include/firebolt_shell_protocol_client.h ${D}/${includedir}
fi
if [ -f ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ] && \
[ -f ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ]; then
install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir}
fi
if [ -f ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ] && \
[ -f ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ]; then

Copilot uses AI. Check for mistakes.
Comment on lines +37 to +46
if [ -d ${B}/extensions/firebolt_surface ]; then
install -m 755 ${B}/extensions/firebolt_surface/librdkwmextfireboltsurface.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_surface/libwstplugin_rdkwmfireboltsurface.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_surface/include/firebolt_surface_protocol_client.h ${D}/${includedir}
fi
if [ -d ${B}/extensions/firebolt_wm ]; then
install -m 755 ${B}/extensions/firebolt_wm/librdkwmextfireboltwm.so ${D}/${libdir}/
install -m 755 ${B}/extensions/firebolt_wm/libwstplugin_rdkwmfireboltwm.so ${D}/${libdir}/plugins/westeros/
install -m 644 ${S}/extensions/firebolt_wm/include/firebolt_wm_protocol_client.h ${D}/${includedir}
fi
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as above for the firebolt_surface/firebolt_wm extension blocks: checking -d on the build directory doesn’t guarantee the .so files exist, so install can fail. Prefer checking -f for each artifact (or a single condition that ensures the extension was built) before installing.

Copilot uses AI. Check for mistakes.
install -m 644 ${S}/include/*.h ${D}${includedir}/rdkwindowmanager/include/
}

INSANE_SKIP:${PN} = "installed-vs-shipped"
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INSANE_SKIP:${PN} = "installed-vs-shipped" overwrites any existing INSANE_SKIP:${PN} values that may be set by inherited classes/includes. If the intent is only to add skips, use += for all entries (or explain why overriding is required).

Suggested change
INSANE_SKIP:${PN} = "installed-vs-shipped"
INSANE_SKIP:${PN} += "installed-vs-shipped"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 19, 2026 20:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

telemetrysupport \
ledcontrol \
"

Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PACKAGECONFIG variable includes 'breakpadsupport' but there is no corresponding PACKAGECONFIG[breakpadsupport] definition. This definition is needed to specify how the build system should handle this configuration option. Other similar recipes in the codebase (e.g., entservices-miracast.bb, entservices-xcast.bb, entservices-peripherals.bb) include the definition: PACKAGECONFIG[breakpadsupport] = ",,breakpad-wrapper,breakpad-wrapper"

Suggested change
PACKAGECONFIG[breakpadsupport] = ",,breakpad-wrapper,breakpad-wrapper"

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 20, 2026 13:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 146 out of 146 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 5 to +16
@@ -12,17 +12,15 @@ SRC_URI = "${CMF_GITHUB_ROOT}/entservices-softwareupdate;${CMF_GITHUB_SRC_URI_SU
file://0001-RDKTV-20749-Revert-Merge-pull-request-3336-from-npol.patch \
"

# Release version - 1.9.0
SRCREV = "4117d05afca7f884ed362d3a676294672c4a4217"
# Release version - 1.15.0
SRCREV = "45480b833d5ec7662405affb0bf7c6902f4664cf"
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

gururaajar and others added 14 commits May 5, 2026 16:50
Reason for Change: NetworkManager release v2.2.0 with following fixes
- Added new method to connection to specific known SSID
- Extended WiFiConnect method to support BSSID and specific Band
- Defaulted to use RDKLogger and avoided redundant logging for few methods
- Added Minimal Ethernet Connection Profile for migration handling
- General improvements on RPC methods & crash resilience
Test Procedure: NA
Priority:P1
Risks: Medium

Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8
RDKEMW-10793: Networkmanager plugin release v2.2.0
RDKEMW-17675: App Managers 0.4.0.1 Release Integration
RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.