Rebase by Abhinavpv28 · Pull Request #2346 · rdkcentral/meta-rdk-video

Abhinavpv28 · 2026-01-01T09:19:48Z

No description provided.

Copilot

Pull request overview

This PR performs a version rebase of the sysint component, updating it from version 4.2.0 to 4.2.1. The changes add support for dnsmasq configuration within NetworkManager by creating a new directory and installing a dnsmasq configuration file.

Key Changes:

Version bump from 4.2.0 to 4.2.1 with corresponding SRCREV update
Addition of NetworkManager dnsmasq.d directory and dnsmasq-dobby.conf configuration file
Updated package file list to include the new dnsmasq configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-01T09:22:04Z

 	install -m 0755 ${S}/lib/rdk/NM_Dispatcher.sh ${D}${sysconfdir}/NetworkManager/dispatcher.d
 	install -m 0755 ${S}/lib/rdk/NM_preDown.sh ${D}${sysconfdir}/NetworkManager/dispatcher.d/pre-down.d
 	install -m 0755 ${S}/etc/10-unmanaged-devices ${D}${sysconfdir}/NetworkManager/conf.d/10-unmanaged-devices.conf
+    install -m 0755 ${S}/etc/dnsmasq-dobby.conf ${D}${sysconfdir}/NetworkManager/dnsmasq.d/dnsmasq-dobby.conf


Inconsistent indentation detected. This line uses spaces for indentation, while the surrounding lines in this section use tabs. Please change the leading spaces to a tab character to match the indentation style of lines 251, 252, and 253. Additionally, the file mode 0755 (executable) is inappropriate for a configuration file. Configuration files should use mode 0644 (read-only for non-owners) instead.

Copilot · 2026-01-01T09:22:04Z

 FILES:${PN} += " /HrvInitScripts/*"
 FILES:${PN} += "${sysconfdir}/NetworkManager/dispatcher.d/NM_Dispatcher.sh"
 FILES:${PN} += "${sysconfdir}/NetworkManager/dispatcher.d/pre-down.d/NM_preDown.sh"
+FILES:${PN} += "${sysconfdir}/NetworkManager/dnsmasq.d/dnsmasq-dobby.conf"


This FILES:${PN} entry may be redundant since line 314 already includes '${sysconfdir}/*', which would encompass all files under ${sysconfdir}/NetworkManager/dnsmasq.d/. However, if this explicit entry is intentional for documentation or clarity purposes to match the pattern used for other NetworkManager files (lines 318-319), this is acceptable.

Suggested change

FILES:${PN} += "${sysconfdir}/NetworkManager/dnsmasq.d/dnsmasq-dobby.conf"

Copilot · 2026-01-01T09:22:05Z

 	# For NetworkManager
 	install -d ${D}${sysconfdir}/NetworkManager
 	install -d ${D}${sysconfdir}/NetworkManager/conf.d
+    install -d ${D}${sysconfdir}/NetworkManager/dnsmasq.d


Inconsistent indentation detected. This line uses spaces for indentation, while the surrounding lines in this section use tabs. Please change the leading spaces to a tab character to match the indentation style of lines 246, 247, 249, and 250.

Suggested change

install -d ${D}${sysconfdir}/NetworkManager/dnsmasq.d

install -d ${D}${sysconfdir}/NetworkManager/dnsmasq.d

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-07T15:35:00Z

 	install -m 0755 ${S}/lib/rdk/NM_Dispatcher.sh ${D}${sysconfdir}/NetworkManager/dispatcher.d
 	install -m 0755 ${S}/lib/rdk/NM_preDown.sh ${D}${sysconfdir}/NetworkManager/dispatcher.d/pre-down.d
 	install -m 0755 ${S}/etc/10-unmanaged-devices ${D}${sysconfdir}/NetworkManager/conf.d/10-unmanaged-devices.conf
+    install -m 0755 ${S}/etc/dnsmasq-dobby.conf ${D}${sysconfdir}/NetworkManager/dnsmasq.d/dnsmasq-dobby.conf


The indentation uses spaces instead of tabs, which is inconsistent with the surrounding code in this section. The file uses tabs for indentation elsewhere (see lines 246-247, 249-253, 255-256), so this line should use tabs to maintain consistency.

github-actions · 2026-01-09T01:51:44Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-09T01:55:50Z

+DEPENDS:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' bluetooth-mgr', '', d)}"
+LDFLAGS:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -lBTMgr', '', d)}"
+
+EXTRA_OECMAKE:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', ' -DBLE_ENABLED=OFF', d)}"


The introduction of the BLE_ENABLED variable provides better control over BLE support independently from general DISTRO_FEATURES bluetooth. However, line 106 now adds '-DBLE_ENABLED=OFF' when BLE_ENABLED is not 'true', which is a behavior change. Previously, when bluetooth was not in DISTRO_FEATURES, the -DBLE_ENABLED flag was simply omitted. Ensure that explicitly setting -DBLE_ENABLED=OFF doesn't cause any build or runtime issues if the CMake build system previously assumed the absence of the flag meant OFF.

Suggested change

EXTRA_OECMAKE:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', ' -DBLE_ENABLED=OFF', d)}"

EXTRA_OECMAKE:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', '', d)}"

Copilot · 2026-01-09T01:55:51Z

+    if [ "${MACHINE}" = "es1-rtk-xumo" ]; then
+          if [ -f ${D}${base_libdir}/rdk/startStunnel.sh ]; then
+                bbnote "Disabling SHORTS"
+               sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh


The bbnote message "Disabling SHORTS" will be logged during the build, but the actual sed command result is not checked for success or failure. Consider adding error checking after the sed command to verify that the modification was successful, for example: 'if grep -q '"false"' ${D}${base_libdir}/rdk/startStunnel.sh; then bbnote "Successfully disabled SHORTS"; else bbwarn "Failed to disable SHORTS"; fi'

Suggested change

sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh

sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh

if grep -q '"false"' ${D}${base_libdir}/rdk/startStunnel.sh; then

bbnote "Successfully disabled SHORTS"

else

bbwarn "Failed to disable SHORTS in ${D}${base_libdir}/rdk/startStunnel.sh"

fi

Copilot · 2026-01-09T01:55:51Z

+    if [ "${MACHINE}" = "es1-rtk-xumo" ]; then
+          if [ -f ${D}${base_libdir}/rdk/startStunnel.sh ]; then
+                bbnote "Disabling SHORTS"
+               sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh


The sed command uses single quotes around the replacement text which contains a backtick-enclosed command substitution. The escaped backticks within the single-quoted string may not work as intended. Consider using double quotes with proper escaping or testing this sed command to ensure it correctly replaces the tr181 command with the literal string "false".

Suggested change

sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh

sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/false/' ${D}${base_libdir}/rdk/startStunnel.sh

Copilot · 2026-01-09T01:55:51Z

    ${@bb.utils.contains('DISTRO_FEATURES', 'DAC-sec',              'ocicontainersec', '', d)} \
    ${@bb.utils.contains('DISTRO_FEATURES', 'rdkshell',             'rdkshell', '', d)} \
    ${@bb.utils.contains('DISTRO_FEATURES', 'rdkshell enable_rialto', 'rdkshellrialto', '', d)} \


The fbsettings plugin configuration was removed from entservices-infra.bb (line 76 in the old code), and the corresponding service file wpeframework-fbsettings.service was replaced with wpeframework-appgatewaycommon.service in thunderstartupservices.bb. However, the new entservices-appgateway.bb file includes appgateway, appnotifications, and appgatewaycommon plugins, but not fbsettings. Verify that fbsettings functionality is either deprecated, merged into appgatewaycommon, or intentionally removed, and that all dependent services are correctly updated.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T19:33:16Z

-    appmanager \
-    texttospeechmonitor \
-    preinstallmanager \
+    javascriptcore \          


There is trailing whitespace at the end of this line. Trailing whitespace should be removed to maintain clean code formatting.

Copilot · 2026-01-12T19:33:16Z

-    texttospeechmonitor \
-    preinstallmanager \
+    javascriptcore \          
+    texttospeechmonitor \    


There is trailing whitespace at the end of this line. Trailing whitespace should be removed to maintain clean code formatting.

Copilot · 2026-01-12T19:33:16Z

    ${@bb.utils.contains('DISTRO_FEATURES', 'opencdm', 'opencdmi', '', d)} \
-    ${@bb.utils.contains('DISTRO_FEATURES', 'rialto_in_dac', 'rialtodac', '', d)} \
-    downloadmanager \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'rialto_in_dac', 'rialtodac', '', d)} \    


There is trailing whitespace at the end of this line. Trailing whitespace should be removed to maintain clean code formatting.

Copilot · 2026-01-12T19:33:17Z

    usersettings \
-    ocicontainer \
-    runtimemanager \
+    ocicontainer \  


There is trailing whitespace at the end of this line. Trailing whitespace should be removed to maintain clean code formatting.

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T16:07:14Z

    usersettings \
-    ocicontainer \
-    runtimemanager \
+    ocicontainer \  


Line 62 has trailing whitespace after the backslash. This should be removed as trailing whitespace after line continuation characters can cause parsing issues in BitBake recipes.

Copilot · 2026-01-13T16:07:15Z

-    appmanager \
-    texttospeechmonitor \
-    preinstallmanager \
+    javascriptcore \          


Line 65 has trailing whitespace after the backslash. This should be removed as trailing whitespace after line continuation characters can cause parsing issues in BitBake recipes.

Copilot · 2026-01-13T16:07:15Z

-    texttospeechmonitor \
-    preinstallmanager \
+    javascriptcore \          
+    texttospeechmonitor \    


Line 66 has trailing whitespace after the backslash. This should be removed as trailing whitespace after line continuation characters can cause parsing issues in BitBake recipes.

Copilot · 2026-01-13T16:07:15Z

    ${@bb.utils.contains('DISTRO_FEATURES', 'opencdm', 'opencdmi', '', d)} \
-    ${@bb.utils.contains('DISTRO_FEATURES', 'rialto_in_dac', 'rialtodac', '', d)} \
-    downloadmanager \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'rialto_in_dac', 'rialtodac', '', d)} \    


Line 73 has trailing whitespace after the backslash. This should be removed as trailing whitespace after line continuation characters can cause parsing issues in BitBake recipes.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T15:00:47Z

 # BLE support BEGIN

-RDEPENDS:${PN}:append = "${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', ' bluez5', '', d)}"
+BLE_ENABLED      ??= "true"


The default value for BLE_ENABLED is set to 'true', but this changes the previous behavior where BLE was only enabled when 'bluetooth' was in DISTRO_FEATURES. This unconditional default could enable BLE on systems that don't have bluetooth in DISTRO_FEATURES, which may not be the intended behavior. Consider setting the default based on DISTRO_FEATURES to maintain backward compatibility: BLE_ENABLED ??= \"${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'true', 'false', d)}\"

Suggested change

BLE_ENABLED ??= "true"

BLE_ENABLED ??= "${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'true', 'false', d)}"

Copilot · 2026-01-16T15:00:48Z


 S = "${WORKDIR}/git"
 inherit cmake pkgconfig



Setting SRCREV to ${PV} assumes that git tags exactly match the PV value. This is fragile and will break if the tag format differs (e.g., 'v3.18.2' vs '3.18.2'). Consider using an explicit SRCREV hash or adding a comment documenting the tag naming convention.

Suggested change

# Upstream git tags match PV exactly (e.g. "3.18.2", not "v3.18.2"); keep SRCREV tied to PV.

Copilot · 2026-01-16T15:00:48Z

@@ -0,0 +1,59 @@
+SUMMARY = "ENTServices AVOutput plugin"
+LICENSE = "CLOSED"


The LICENSE is set to 'CLOSED', but there's no LIC_FILES_CHKSUM for this closed license. For closed-source software, you should typically still provide a LIC_FILES_CHKSUM or document why it's omitted. This is inconsistent with the other entservices recipes which use Apache-2.0.

Suggested change

LICENSE = "CLOSED"

LICENSE = "CLOSED"

# Closed-source component; no distributable license file is present in the source tree.

# LIC_FILES_CHKSUM is intentionally left empty to document this exception.

LIC_FILES_CHKSUM = ""

Copilot · 2026-01-16T15:00:49Z

+DEPENDS:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' bluetooth-mgr', '', d)}"
+LDFLAGS:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -lBTMgr', '', d)}"
+
+EXTRA_OECMAKE:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', ' -DBLE_ENABLED=OFF', d)}"


The CMake flag includes both ON and OFF cases explicitly. However, the OFF case is redundant - if the flag isn't passed, CMake will default to OFF. Consider simplifying to only pass the flag when enabled: EXTRA_OECMAKE:append = \"${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', '', d)}\"

Suggested change

EXTRA_OECMAKE:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', ' -DBLE_ENABLED=OFF', d)}"

EXTRA_OECMAKE:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', '', d)}"

Copilot · 2026-01-16T15:00:49Z

-
-AUDIO_CONTROL         ?= "false"
-EXTRA_OECMAKE:append   = "${@bb.utils.contains('AUDIO_CONTROL', 'true', ' -DFACTORY_AUDIO_CONTROL=ON', '', d)}"
+EXTRA_OECMAKE:append = "${@bb.utils.contains('BUILD_FACTORY_TEST', 'true', ' -DBUILD_FACTORY_TEST=ON', ' -DBUILD_FACTORY_TEST=OFF', d)}"


Similar to BLE_ENABLED, explicitly passing OFF is redundant. Consider simplifying to only pass ON when needed: EXTRA_OECMAKE:append = \"${@bb.utils.contains('BUILD_FACTORY_TEST', 'true', ' -DBUILD_FACTORY_TEST=ON', '', d)}\"

Suggested change

EXTRA_OECMAKE:append = "${@bb.utils.contains('BUILD_FACTORY_TEST', 'true', ' -DBUILD_FACTORY_TEST=ON', ' -DBUILD_FACTORY_TEST=OFF', d)}"

EXTRA_OECMAKE:append = "${@bb.utils.contains('BUILD_FACTORY_TEST', 'true', ' -DBUILD_FACTORY_TEST=ON', '', d)}"

Copilot · 2026-01-16T15:00:49Z

+    if [ "${MACHINE}" = "es1-rtk-xumo" ]; then
+          if [ -f ${D}${base_libdir}/rdk/startStunnel.sh ]; then
+                bbnote "Disabling SHORTS"
+               sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh


The sed command uses complex escaping and backtick substitution patterns. This is fragile and hard to maintain. Consider using a simpler approach or adding a comment explaining what SHORTS feature is being disabled and why it's necessary for es1-rtk-xumo specifically.

Copilot

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T19:18:40Z

 inherit cmake pkgconfig

-SRCREV = "c0587d76355e53401ac8370c88b5b7c3415fbc4c"
+SRCREV = "${PV}"


Using PV as SRCREV (line 11) assumes that the git repository uses version tags (e.g., '3.18.2') as commit references. This pattern can be fragile if the repository uses different tagging conventions or if tags are moved/deleted. Consider using an explicit git commit hash for SRCREV to ensure build reproducibility.

Suggested change

SRCREV = "${PV}"

SRCREV = "0123456789abcdef0123456789abcdef01234567"

Copilot · 2026-01-16T19:18:40Z

+    ocicontainer \  
    messagecontrol \
    rdknativescript \
-    javascriptcore \
-    packagemanager \
-    lifecyclemanager \
-    storagemanager \
-    appmanager \
-    texttospeechmonitor \
-    preinstallmanager \
+    javascriptcore \          
+    texttospeechmonitor \    
    migration \


Lines 62, 65, and 66 have trailing whitespace after the backslash continuation characters. While this doesn't break functionality in BitBake, it's inconsistent with the rest of the PACKAGECONFIG list and violates best practices for clean code formatting.

Copilot · 2026-01-16T19:18:40Z

+    if [ "${MACHINE}" = "es1-rtk-xumo" ]; then
+          if [ -f ${D}${base_libdir}/rdk/startStunnel.sh ]; then
+                bbnote "Disabling SHORTS"
+               sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh
+          fi
+    fi


The sed command on line 62 uses a complex regex to replace a backtick-enclosed command with a hardcoded string. This is fragile and could break if the source file format changes. Consider documenting why SHORTS needs to be disabled for es1-rtk-xumo, and whether this should be a configurable feature rather than a machine-specific hardcode.

Copilot · 2026-01-16T19:18:41Z

@@ -0,0 +1,59 @@
+SUMMARY = "ENTServices AVOutput plugin"
+LICENSE = "CLOSED"


The new entservices-avoutput.bb recipe uses 'CLOSED' license (line 2), which indicates proprietary/closed-source code. However, it depends on multiple open-source components. Ensure this is intentional and complies with your organization's licensing policies, especially since other entservices recipes use 'Apache-2.0'.

Suggested change

LICENSE = "CLOSED"

LICENSE = "Apache-2.0"

- Revert rialto version - Revert rialto-gstreamer version

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

RDKEMW-16160: Handle widevine14 for xi6

Copilot

Pull request overview

Copilot reviewed 208 out of 208 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RDK-61007: Updated new service file for networkconnectionstats plugin

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Reason for Change: NetworkManager release v2.2.0 with following fixes - Added new method to connection to specific known SSID - Extended WiFiConnect method to support BSSID and specific Band - Defaulted to use RDKLogger and avoided redundant logging for few methods - Added Minimal Ethernet Connection Profile for migration handling - General improvements on RPC methods & crash resilience Test Procedure: NA Priority:P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>

…ideo into topic/RDKEMW-10793

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

RDKEMW-17603: Subtec release 1.8.0

Copilot

Pull request overview

Copilot reviewed 208 out of 208 changed files in this pull request and generated no new comments.

RDKEMW-10793: Networkmanager plugin release v2.2.0

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot

Pull request overview

Copilot reviewed 208 out of 208 changed files in this pull request and generated 1 comment.

+            # If autostart was not found, set default startmode to Deactivated
+            if not autostart_found:
+                result.add('startmode', 'Deactivated')
+             if isEmpty:


RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

Copilot AI review requested due to automatic review settings January 1, 2026 09:19

Abhinavpv28 requested review from a team as code owners January 1, 2026 09:19

Copilot started reviewing on behalf of Abhinavpv28 January 1, 2026 09:20 View session

Copilot AI reviewed Jan 1, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 5, 2026 15:46

Copilot AI reviewed Jan 5, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 7, 2026 15:30

Copilot started reviewing on behalf of pstroffolino January 7, 2026 15:30 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 9, 2026 01:51

Copilot started reviewing on behalf of plaksh002c-public January 9, 2026 01:51 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 9, 2026 18:32

Copilot AI reviewed Jan 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 12, 2026 19:28

Copilot started reviewing on behalf of anand-ky January 12, 2026 19:29 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 16:01

Copilot started reviewing on behalf of anand-ky January 13, 2026 16:01 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 14, 2026 15:21

Copilot AI reviewed Jan 14, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 14:57

Copilot started reviewing on behalf of anand-ky January 16, 2026 14:57 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 19:14

Copilot started reviewing on behalf of anand-ky January 16, 2026 19:14 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

varatharajan568 and others added 8 commits May 4, 2026 16:34

Update rialto_revision.inc

e6f8826

Update rialto_revision.inc

8c89a4c

Update rialto_revision.inc

22eefde

Update rialto_revision.inc

d8cef88

- Revert rialto version - Revert rialto-gstreamer version

Merge branch 'develop' into topic/RDKMVE-2173

b91c1e0

Merge pull request #3797 from rdkcentral/topic/RDKMVE-2173

51ae571

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

Merge branch 'develop' into feature/RDKEMW-16160

0ab86d5

Merge pull request #3745 from rdkcentral/feature/RDKEMW-16160

dec8d5c

RDKEMW-16160: Handle widevine14 for xi6

Copilot AI reviewed May 4, 2026

View reviewed changes

plaksh002c-public added 4 commits May 5, 2026 10:49

Merge branch 'develop' into topic/RDK-59986

7359f41

Merge pull request #3789 from rdkcentral/topic/RDK-59986

eb63623

RDK-61007: Updated new service file for networkconnectionstats plugin

Merge branch 'develop' into feature/RDKEMW-17520_ctrlm-v1.1.14

4a5b232

Merge pull request #3741 from rdkcentral/feature/RDKEMW-17520_ctrlm-v…

40d75c2

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot AI reviewed May 5, 2026

View reviewed changes

gururaajar and others added 7 commits May 5, 2026 16:50

Merge branch 'topic/RDKEMW-10793' of github.com:rdkcentral/meta-rdk-v…

58d991d

…ideo into topic/RDKEMW-10793

Merge branch 'develop' into topic/RDKEMW-10793

b3c1c94

Merge branch 'develop' into topic/RDKEMW-17603

f489785

RDK-61211: google cast auth extension (#3827)

d543680

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

Merge branch 'develop' into topic/RDKEMW-17603

545d2fe

Merge pull request #3751 from rdkcentral/topic/RDKEMW-17603

f3e3458

RDKEMW-17603: Subtec release 1.8.0

Copilot AI reviewed May 6, 2026

View reviewed changes

plaksh002c-public and others added 5 commits May 6, 2026 15:30

Merge branch 'develop' into topic/RDKEMW-10793

b4ee97b

Merge pull request #3833 from rdkcentral/topic/RDKEMW-10793

c1630b4

RDKEMW-10793: Networkmanager plugin release v2.2.0

Merge branch 'develop' into feature/RDKEMW-17411

8a0c73e

Merge branch 'develop' into topic/RDKEMW-17675

d1449b5

Merge pull request #3812 from rdkcentral/topic/RDKEMW-17675

daa2195

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread recipes-thunder/thunder/wpeframework-tools/0006-Autostart-startmode-deactivated.patch

Comment on lines +38 to +41

+ # If autostart was not found, set default startmode to Deactivated

+ if not autostart_found:

+ result.add('startmode', 'Deactivated')

if isEmpty:

plaksh002c-public added 2 commits May 7, 2026 20:56

Merge branch 'develop' into feature/RDKEMW-17411

7b0a8d4

Merge pull request #3712 from rdkcentral/feature/RDKEMW-17411

367eef9

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

	install -d ${D}${sysconfdir}/NetworkManager/dnsmasq.d
	install -d ${D}${sysconfdir}/NetworkManager/dnsmasq.d

	EXTRA_OECMAKE:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', ' -DBLE_ENABLED=OFF', d)}"
	EXTRA_OECMAKE:append = "${@bb.utils.contains('BLE_ENABLED', 'true', ' -DBLE_ENABLED=ON', '', d)}"

-               sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh
+               sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh
+               if grep -q '"false"' ${D}${base_libdir}/rdk/startStunnel.sh; then
+                   bbnote "Successfully disabled SHORTS"
+               else
+                   bbwarn "Failed to disable SHORTS in ${D}${base_libdir}/rdk/startStunnel.sh"
+               fi

	sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh
	sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/false/' ${D}${base_libdir}/rdk/startStunnel.sh

	BLE_ENABLED ??= "true"
	BLE_ENABLED ??= "${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'true', 'false', d)}"



	# Upstream git tags match PV exactly (e.g. "3.18.2", not "v3.18.2"); keep SRCREV tied to PV.

		@@ -0,0 +1,59 @@
		SUMMARY = "ENTServices AVOutput plugin"
		LICENSE = "CLOSED"

-LICENSE = "CLOSED"
+LICENSE = "CLOSED"
+# Closed-source component; no distributable license file is present in the source tree.
+# LIC_FILES_CHKSUM is intentionally left empty to document this exception.
+LIC_FILES_CHKSUM = ""

	SRCREV = "${PV}"
	SRCREV = "0123456789abcdef0123456789abcdef01234567"

Conversation

Abhinavpv28 commented Jan 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 9, 2026 •

edited

Loading