sync to develop by santoshcomcast · Pull Request #1770 · rdkcentral/meta-rdk-video

santoshcomcast · 2025-09-29T12:45:27Z

No description provided.

CLAassistant · 2025-09-29T12:45:44Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
23 out of 24 committers have signed the CLA.

✅ dwolaver
✅ anusree23
✅ preeja33
✅ dkumar798
✅ tabbas651
✅ AkshayKumar2794
✅ viveksinghnarwaria
✅ anand-ky
✅ suppal045
✅ hgfell683
✅ npoltorapavlo
✅ Saranya2421
✅ Dosakaya
✅ ssitar583
✅ melhar098
✅ yuvaramachandran-gurusamy
✅ asurdej-comcast
✅ karuna2git
✅ apatel859
✅ emutavchi
✅ mukesh972
✅ cmuhammedrafi
✅ divyang-public
❌ svc_rdkgerrit02

svc_rdkgerrit02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 151 out of 154 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 152 out of 155 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

recipes-extended/wpe-framework/wpeframework/r4.4/Removed_Autostart_Check_From_WPEFramework.patch:26

The patch wraps the autostart logic in #if 0, effectively disabling it. The commit message indicates this is intentional for systemd-based plugin activation, but the commented-out code should eventually be removed rather than left disabled with preprocessor directives. Consider adding a comment explaining why this code is disabled and when it can be safely removed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T16:02:29Z

 PACKAGECONFIG[touchevents]       = "-DENABLE_TOUCH_EVENTS=ON,-DENABLE_TOUCH_EVENTS=OFF,"
 PACKAGECONFIG[remoteinspector]   = "-DENABLE_REMOTE_INSPECTOR=ON,-DENABLE_REMOTE_INSPECTOR=OFF,"
-PACKAGECONFIG[vp9_hdr]           = "-DENABLE_HDR=ON,-DENABLE_HDR=OFF,,gstreamer1.0-plugins-good-matroska"
+PACKAGECONFIG[vp9_hdr]           = "-DENABLE_HDR=ON,-DENABLE_HDR=OFF,,"


The vp9_hdr PACKAGECONFIG option has been defined twice in the file (lines 91 and a removed duplicate). The duplicate definition has been removed, but verify that the remaining definition at line 91 no longer has the runtime dependency on gstreamer1.0-plugins-good-matroska, which has been moved to wpe-webkit.inc as a general RDEPS_VIDEO dependency. This change may affect systems that don't enable vp9_hdr but still need matroska support.

Copilot · 2026-01-15T16:02:30Z

 LIC_FILES_CHKSUM = "file://LICENSE;md5=85bcfede74b96d9a58c6ea5d4b607e58"

-DEPENDS = "zlib wpeframework-tools-native rfc thunderhangrecovery"
+DEPENDS = "zlib wpeframework-tools-native rfc thunder-hang-recovery"


The dependency has been renamed from "thunderhangrecovery" to "thunder-hang-recovery" (with hyphens). Ensure this naming change is consistent across all references and that the actual recipe file name matches this new naming convention.

Copilot · 2026-01-15T16:02:30Z

 ExecStartPre=-/usr/bin/rdkLogMileStone WPE_FRAMEWORK_START
 SyslogIdentifier=WPEFramework
-ExecStart=/bin/bash -c 'if [ -f /opt/WPEFramework/config.json ]; then exec /usr/bin/WPEFramework -b -c /opt/WPEFramework/config.json; else exec /usr/bin/WPEFramework -b; fi'
+ExecStart=/usr/bin/WPEFramework -b


The ExecStart command has been simplified to remove the conditional logic that checked for /opt/WPEFramework/config.json. This assumes the configuration file location is now handled differently. Verify that WPEFramework can locate its configuration file correctly without this explicit path specification.

Copilot · 2026-01-15T16:02:30Z

+                            // New range > 2000 is added for pass through for a temporary fix for ContentProtection range
 +
-+                            if( frameworkError <= 999 ) {
+                            if( frameworkError <= 999  || frameworkError > 2000 ) {


The comment indicates this is a "temporary fix" for ContentProtection range handling. Temporary fixes should be tracked and eventually replaced with proper solutions. Consider adding a TODO or ticket reference to ensure this gets properly addressed in a future release.

Copilot · 2026-01-15T16:02:31Z

+    if [ "${MACHINE}" = "es1-rtk-xumo" ]; then
+          if [ -f ${D}${base_libdir}/rdk/startStunnel.sh ]; then
+                bbnote "Disabling SHORTS"
+               sed -i 's/`tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.SHORTS.Enable 2>&1 > \/dev\/null`/\"false\"/' ${D}${base_libdir}/rdk/startStunnel.sh
+          fi
+    fi


This machine-specific workaround disables SHORTS feature for the "es1-rtk-xumo" machine. This type of hard-coded machine check can be difficult to maintain. Consider using a DISTRO_FEATURE or MACHINE_FEATURE instead to make this more maintainable and extensible to other machines that may need the same configuration.

Copilot

Pull request overview

Copilot reviewed 152 out of 155 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T15:09:53Z

 	else
 		install -m 0644 ${S}/tr69hostif.service ${D}${systemd_unitdir}/system
 	fi
+    sed -i 's/@DSMGR_DEPENDENCY@/iarmbusd.service/' ${D}${systemd_unitdir}/system/tr69hostif.service


The sed command modifying the service file at install time is fragile. This substitution assumes the service file contains the literal string '@DSMGR_DEPENDENCY@', but there's no verification. If the template changes or doesn't contain this placeholder, the sed command will silently succeed without making any changes. Consider adding validation or using a more robust templating mechanism (e.g., configure_file in CMake or a dedicated templating tool).

Copilot · 2026-01-16T15:09:54Z

 EXTRA_OECONF += "--disable-silent-rules --enable-InterfaceStack --enable-IPv6 --enable-notification --enable-yocto --enable-SpeedTest"
 EXTRA_OECONF += " --enable-parodus"
-EXTRA_OECONF:append = " --enable-libsoup3=yes"
+EXTRA_OECONF:append = " --enable-powercontroller=yes"


The configuration option change from --enable-libsoup3=yes to --enable-powercontroller=yes appears to be unrelated functionality. If libsoup3 is no longer needed, this should be documented in the commit message. If both are needed, both flags should be present. This change may break existing functionality that depends on libsoup3.

Copilot · 2026-01-16T15:09:54Z

 PACKAGECONFIG[fhd]               = "-DVIDEO_DECODING_LIMIT=1920x1080@60,,"

-PACKAGECONFIG:append = " vp9_hdr dolbyvision breakpad native_video woff2 serviceworker"
+PACKAGECONFIG:append = " vp9_hdr breakpad native_video woff2 serviceworker"


The removal of 'dolbyvision' from PACKAGECONFIG:append without removing the corresponding PACKAGECONFIG[dolbyvision] definitions on lines 120 (now deleted) creates dead configuration code. The dolbyvision PACKAGECONFIG option definitions should also be removed for consistency.

Copilot · 2026-01-16T15:09:54Z

-         for (auto service : configured_services)
-+            SYSLOG(Logging::Startup, (_T("Activation of plugin [%s]:[%s] handled by systemd"),
-+                service->ClassName().c_str(), service->Callsign().c_str()));
 +#if 0


Using #if 0 to disable code is a code smell. If the autostart functionality is no longer needed, the code should be removed entirely rather than commented out with preprocessor directives. This leaves dead code in the codebase.

Copilot · 2026-01-16T15:09:55Z

@@ -120,21 +126,6 @@ do_install:append() {
        # Converts: "Description=WPEFramework SystemMode Initialiser"
        # To:      "Description=WPE SystemMode"
        sed -i 's/^Description=WPEFramework \(.*\) Initialiser$/Description=WPE \1/' "$SERVICE_FILE"


The removal of the ExecStop logic that adds deactivation commands for PluginActivator suggests a significant change in plugin lifecycle management. This appears to be related to removing the pluginactivator PACKAGECONFIG option, but the implications of this change for plugin shutdown during service restart should be carefully considered.

Copilot · 2026-01-16T15:09:55Z

+    if ! grep -q "wowlan_triggers=" "$WPA_SUPP_CONF_FILE"; then
+        echo "wowlan_triggers=any" >> "$WPA_SUPP_CONF_FILE"


The wowlan_triggers setting is added unconditionally with value "any". This might not be appropriate for all devices or configurations. Consider making this configurable through a variable that can be set per machine or distro feature.

Copilot · 2026-01-16T15:09:55Z

-PV ?= "3.0"
-PR ?= "r1"
+PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"
+PV = "1.0.0"


The PV changed from "3.0" to "1.0.0", which appears to be a version downgrade. This is unusual and might indicate an error. Version numbers should typically increase over time. Verify this change is intentional.

Copilot · 2026-01-16T15:09:56Z

+XR_VOICE_SDK_SRCREV = "c514ed32351fe1327b7e46f460f200686c1f6f2f"
+XR_VOICE_SDK_PV     = "1.0.9"
+XR_VOICE_SDK_PR     = "r0"


While creating a .inc file for shared version information is good practice, this file has no license header or copyright information, which should be added for consistency with other recipe files in the project.

Copilot

Pull request overview

Copilot reviewed 152 out of 155 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

recipes-extended/sysint/sysint_git.bb:1

Machine-specific hardcoded logic for "es1-rtk-xumo" disabling SHORTS feature. This should ideally be moved to a machine-specific bbappend or controlled via a DISTRO_FEATURE for better maintainability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T19:25:00Z

-
-# Aug 06, 2025
-SRCREV = "3202ca6bbf15d9567f3ab746ba37ce7eccd18c85"
+SRCREV = "3da15c8c1d2d3bbc6f341f6451ce52ae019e4a4d"


The comment "# Aug 06, 2025" has been removed. While this is an improvement (removing a future date), the SRCREV has also changed significantly. Ensure this commit hash is the correct intended version.

Copilot · 2026-01-16T19:25:01Z

 LIC_FILES_CHKSUM = "file://LICENSE;md5=85bcfede74b96d9a58c6ea5d4b607e58"

-DEPENDS = "zlib wpeframework-tools-native rfc thunderhangrecovery"
+DEPENDS = "zlib wpeframework-tools-native rfc thunder-hang-recovery"


The dependency name changed from "thunderhangrecovery" to "thunder-hang-recovery" (adding hyphen). Ensure this matches the actual recipe name and is consistently used throughout.

Copilot · 2026-01-16T19:25:01Z

 ExecStartPre=-/usr/bin/rdkLogMileStone WPE_FRAMEWORK_START
 SyslogIdentifier=WPEFramework
-ExecStart=/bin/bash -c 'if [ -f /opt/WPEFramework/config.json ]; then exec /usr/bin/WPEFramework -b -c /opt/WPEFramework/config.json; else exec /usr/bin/WPEFramework -b; fi'
+ExecStart=/usr/bin/WPEFramework -b


The conditional config.json check has been removed. This changes behavior - previously it would use /opt/WPEFramework/config.json if available, now it always uses default. Ensure this is intentional and documented.

Copilot · 2026-01-16T19:25:01Z

    "

-PACKAGECONFIG:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'thunder_startup_services', 'com pluginactivator', '', d)}"
+PACKAGECONFIG:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'thunder_startup_services', 'com', '', d)}"


The 'pluginactivator' option has been removed from PACKAGECONFIG. Ensure this functionality is properly replaced or no longer needed, as there are related changes removing pluginactivator build support.

Copilot · 2026-01-16T19:25:01Z

@@ -1,4 +1,4 @@
-From 8af1da7acbc0e1874c500f2f69e4cd94e2663623 Mon Sep 17 00:00:00 2001
+From 96cf5315ea63c5f4a26564492ae62d783434b49f Mon Sep 17 00:00:00 2001


This is a large patch (2000+ lines) for PowerManager client implementation. The patch removes several API functions (SetWakeupSrcConfig, GetWakeupSrcConfig, SetSystemMode) which could be breaking changes. Ensure dependent code is updated accordingly.

Copilot · 2026-01-16T19:25:01Z


-SRC_URI:append = "${@bb.utils.contains('DISTRO_FEATURES', 'disable_mfr_read_hdcpkey', ' file://0001-tenablehdcp-remove-mfr-dependency.patch file://0002-start-hdcp-service-after-hdmi-service.patch ', '', d)}"
-
+SRC_URI:append = "${@bb.utils.contains('DISTRO_FEATURES', 'disable_mfr_read_hdcpkey', ' file://0001-tenablehdcp-remove-mfr-dependency.patch file://0002-Fix-for-tenableHDCP-crash-and-added-hdmiservice.patch ', '', d)}"


Patch file 0002-start-hdcp-service-after-hdmi-service.patch has been replaced with 0002-Fix-for-tenableHDCP-crash-and-added-hdmiservice.patch. The new patch includes additional exception handling and retry logic beyond just the service dependency change.

Copilot · 2026-01-16T19:25:02Z

        # Converts: "Description=WPEFramework SystemMode Initialiser"
        # To:      "Description=WPE SystemMode"
        sed -i 's/^Description=WPEFramework \(.*\) Initialiser$/Description=WPE \1/' "$SERVICE_FILE"


Large block of PluginActivator ExecStop logic (15+ lines) has been removed. This appears to be related to removing the pluginactivator dependency, but ensure services can properly deactivate plugins without this mechanism.

Copilot

Pull request overview

Copilot reviewed 154 out of 157 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 154 out of 157 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 154 out of 157 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 183 out of 186 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-22T19:32:57Z

+EXTRA_OECMAKE += " -DENABLE_AAMP_JSBINDINGS_STATIC=OFF"
+EXTRA_OECMAKE += " -DENABLE_AAMP_JSBINDINGS_DYNAMIC=ON"


The variable assignment '-DENABLE_AAMP_JSBINDINGS_STATIC=ON' is being changed to 'OFF' while '-DENABLE_AAMP_JSBINDINGS_DYNAMIC=OFF' is changed to 'ON'. This switches from static to dynamic linking for AAMP JS bindings. Ensure that: 1) The runtime has the necessary shared libraries available, 2) No other build configurations depend on static linking, and 3) This change is intentional and tested.

Copilot · 2026-01-22T19:32:57Z

 LIC_FILES_CHKSUM = "file://${THISDIR}/files/Apache-2.0;md5=3b83ef96387f14655fc854ddc3c6bd57"

-DEPENDS = "westeros essos rapidjson rtcore libuv gstreamer1.0 uwebsockets javascriptcore aamp websocketpp"
+DEPENDS = "westeros essos rapidjson rtcore libuv gstreamer1.0 uwebsockets javascriptcore websocketpp cjson boost"


The comment indicates this change is related to removing AAMP dependency, but the actual change replaces 'aamp' with 'websocketpp' in the DEPENDS list. The comment should clearly explain why websocketpp replaces aamp, or the variable naming might be misleading.

Copilot · 2026-01-22T19:32:57Z

+PACKAGECONFIG:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'wpe-webkit-debugfission', 'debugfission uselld','', d)}"
+SELECTED_OPTIMIZATION:remove =  "${@bb.utils.contains('DISTRO_FEATURES', 'wpe-webkit-debugfission', '-g1', '-g', d)}"
+SELECTED_OPTIMIZATION:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'wpe-webkit-debugfission', '-g', '-g1', d)}"
+WPE_WEBKIT_LTO:remove = "${@bb.utils.contains('DISTRO_FEATURES', 'wpe-webkit-debugfission', '-flto=auto', '', d)}"


The conditional logic mixing SELECTED_OPTIMIZATION:remove and SELECTED_OPTIMIZATION:append with the same distro feature check could lead to unexpected behavior. When 'wpe-webkit-debugfission' is enabled, line 149 removes '-g1' but line 150 appends '-g', and line 151 removes '-flto=auto' from WPE_WEBKIT_LTO. Ensure this ordering and logic produces the intended compilation flags.

Copilot · 2026-01-22T19:32:58Z

        # Converts: "Description=WPEFramework SystemMode Initialiser"
        # To:      "Description=WPE SystemMode"
        sed -i 's/^Description=WPEFramework \(.*\) Initialiser$/Description=WPE \1/' "$SERVICE_FILE"
-
-        if grep -q '^ExecStart=.*PluginActivator' "$SERVICE_FILE"; then
-            CALLSIGN=$(sed -n -E 's/.*PluginActivator.*[[:space:]]+([A-Za-z0-9_.-]+)$/\1/p' "$SERVICE_FILE")
-
-            if [ -n "$CALLSIGN" ]; then
-                if ! grep -q "^ExecStop=/usr/bin/PluginActivator.*$CALLSIGN" "$SERVICE_FILE"; then
-                    if grep -q '^ExecStartPost=' "$SERVICE_FILE"; then
-                        sed -i "/^ExecStartPost=/a ExecStop=/usr/bin/PluginActivator -r 5 -x $CALLSIGN" "$SERVICE_FILE"
-                    else
-                        sed -i "/^ExecStart=.*PluginActivator/a ExecStop=/usr/bin/PluginActivator -r 5 -x $CALLSIGN" "$SERVICE_FILE"
-                    fi
-                fi
-            fi
-        fi
-
    done


Removing the entire do_install:append logic that added ExecStop directives to service files with PluginActivator could break plugin deactivation functionality during service shutdown. If these ExecStop commands were necessary for proper cleanup, their removal could lead to resource leaks or improper shutdown behavior.

Copilot · 2026-01-22T19:32:58Z

 PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"
-DEPENDS = " openssl rdk-logger zlib boost curl glib-2.0 wpeframework entservices-apis wpeframework-tools-native libsoup-2.4 gupnp gssdp telemetry  ${@bb.utils.contains('DISTRO_FEATURES', 'ENABLE_NETWORKMANAGER', ' networkmanager ', ' iarmbus iarmmgrs ', d)} "
-RDEPENDS:${PN} += " wpeframework rdk-logger curl ${@bb.utils.contains('DISTRO_FEATURES', 'ENABLE_NETWORKMANAGER', ' networkmanager ', ' iarmbus iarmmgrs ', d)} "
+DEPENDS = " openssl rdk-logger zlib boost curl glib-2.0 wpeframework entservices-apis wpeframework-tools-native libsoup-2.4 gupnp gssdp telemetry iarmbus iarmmgrs ${@bb.utils.contains('DISTRO_FEATURES', 'ENABLE_NETWORKMANAGER', ' networkmanager ', '', d)} "


The DEPENDS line has inconsistent spacing with an extra space after 'iarmbus iarmmgrs' and a trailing space before the comma. This doesn't affect functionality but should be cleaned up for code consistency.

Copilot · 2026-01-22T19:32:59Z

+PR = "r0"

-SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;${CMF_GITHUB_SRC_URI_SUFFIX}"
+SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;${CMF_GITHUB_SRC_URI_SUFFIX};"


There's a trailing semicolon added to the SRC_URI which appears unintentional. This could cause build issues as BitBake SRC_URI syntax doesn't typically end with a semicolon when there are no additional parameters.

Copilot · 2026-01-22T19:32:59Z

     libwpe \
     bison-native ccache-native glib-2.0-native gperf-native libxml2-native ninja-native ruby-native chrpath-replacement-native \
-     cairo pixman freetype glib-2.0 gnutls harfbuzz icu jpeg pcre sqlite3 zlib \
+     freetype glib-2.0 gnutls harfbuzz icu jpeg pcre sqlite3 zlib \


Removing both 'cairo' and 'pixman' dependencies could cause build failures if they are actually required. These are common dependencies for graphics rendering. Ensure that these libraries are not needed by any of the remaining dependencies or that they're pulled in transitively.

Copilot · 2026-01-22T19:32:59Z

    "

-PACKAGECONFIG:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'thunder_startup_services', 'com pluginactivator', '', d)}"
+PACKAGECONFIG:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'thunder_startup_services', 'com', '', d)}"


Removing the PACKAGECONFIG for 'pluginactivator' but keeping it in the conditional append means systems with 'thunder_startup_services' distro feature will still try to add 'pluginactivator' to PACKAGECONFIG, which will now fail since the PACKAGECONFIG definition was removed. This could cause build errors.

Copilot · 2026-01-22T19:32:59Z

+    install -d ${D}${systemd_unitdir}/system
+    install -m 0644 ${WORKDIR}/wpeframework.service.in  ${D}${systemd_unitdir}/system/wpeframework.service


The do_install:append() function was significantly simplified by removing conditional systemd vs sysvinit installation logic. The new version only handles systemd. If this build system still supports non-systemd configurations, this change will cause installation failures. Verify that systemd is mandatory for all target platforms.

Copilot · 2026-01-22T19:33:00Z

+        boottypeLog "changed the permission of $migrationDir by +x"
+        chmod +x "$migrationDir"
+    fi
+
+    # Check if the file exists
+    if [ -f "$migrationDSFile" ]; then
+        boottypeLog "changed the permission of $migrationDSFile by +r"
+        chmod +r "$migrationDSFile"


The new code unconditionally relaxes permissions on the migrationDir and migration_data_store.json by calling chmod +x on /opt/secure/migration and chmod +r on /opt/secure/migration/migration_data_store.json whenever the boot type is BOOT_MIGRATION. This changes a directory and file under a supposedly secure path to be world-traversable and world-readable, so any local process or user can read migration state, which may include sensitive configuration or credentials. Remove these broad chmod calls or restrict them to the owning user only (e.g., keep directory and file modes owner-only) so that non-privileged processes cannot enumerate or read the migration data store.

Suggested change

boottypeLog "changed the permission of $migrationDir by +x"

chmod +x "$migrationDir"

fi

# Check if the file exists

if [ -f "$migrationDSFile" ]; then

boottypeLog "changed the permission of $migrationDSFile by +r"

chmod +r "$migrationDSFile"

# Ensure only the owner can traverse/read the secure migration directory

boottypeLog "setting secure permissions on $migrationDir (u+rx,go-rwx)"

chmod u+rx,go-rwx "$migrationDir"

fi

# Check if the file exists

if [ -f "$migrationDSFile" ]; then

# Ensure only the owner can read the migration data store

boottypeLog "setting secure permissions on $migrationDSFile (u+r,go-rwx)"

chmod u+r,go-rwx "$migrationDSFile"

- Revert rialto version - Revert rialto-gstreamer version

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

RDKEMW-16160: Handle widevine14 for xi6

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

RDK-61007: Updated new service file for networkconnectionstats plugin

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Reason for Change: NetworkManager release v2.2.0 with following fixes - Added new method to connection to specific known SSID - Extended WiFiConnect method to support BSSID and specific Band - Defaulted to use RDKLogger and avoided redundant logging for few methods - Added Minimal Ethernet Connection Profile for migration handling - General improvements on RPC methods & crash resilience Test Procedure: NA Priority:P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>

…ideo into topic/RDKEMW-10793

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

RDKEMW-17603: Subtec release 1.8.0

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

RDKEMW-10793: Networkmanager plugin release v2.2.0

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

santoshcomcast requested review from a team as code owners September 29, 2025 12:45

Copilot AI review requested due to automatic review settings January 13, 2026 12:11

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 16:26

Copilot started reviewing on behalf of anand-ky January 13, 2026 16:26 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 15, 2026 15:59

Copilot started reviewing on behalf of anand-ky January 15, 2026 15:59 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 15:06

Copilot started reviewing on behalf of anand-ky January 16, 2026 15:07 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 19:22

Copilot started reviewing on behalf of anand-ky January 16, 2026 19:23 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 20, 2026 14:53

Copilot started reviewing on behalf of Rocksta818 January 20, 2026 14:53 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 21, 2026 06:28

Copilot started reviewing on behalf of tdeva14 January 21, 2026 06:28 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 16:18

Copilot started reviewing on behalf of anand-ky January 22, 2026 16:18 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 19:24

Copilot started reviewing on behalf of anand-ky January 22, 2026 19:25 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 23, 2026 17:37

varatharajan568 and others added 8 commits May 4, 2026 16:34

Update rialto_revision.inc

e6f8826

Update rialto_revision.inc

8c89a4c

Update rialto_revision.inc

22eefde

Update rialto_revision.inc

d8cef88

- Revert rialto version - Revert rialto-gstreamer version

Merge branch 'develop' into topic/RDKMVE-2173

b91c1e0

Merge pull request #3797 from rdkcentral/topic/RDKMVE-2173

51ae571

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

Merge branch 'develop' into feature/RDKEMW-16160

0ab86d5

Merge pull request #3745 from rdkcentral/feature/RDKEMW-16160

dec8d5c

RDKEMW-16160: Handle widevine14 for xi6

Copilot AI reviewed May 4, 2026

View reviewed changes

plaksh002c-public added 4 commits May 5, 2026 10:49

Merge branch 'develop' into topic/RDK-59986

7359f41

Merge pull request #3789 from rdkcentral/topic/RDK-59986

eb63623

RDK-61007: Updated new service file for networkconnectionstats plugin

Merge branch 'develop' into feature/RDKEMW-17520_ctrlm-v1.1.14

4a5b232

Merge pull request #3741 from rdkcentral/feature/RDKEMW-17520_ctrlm-v…

40d75c2

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot AI reviewed May 5, 2026

View reviewed changes

gururaajar and others added 7 commits May 5, 2026 16:50

Merge branch 'topic/RDKEMW-10793' of github.com:rdkcentral/meta-rdk-v…

58d991d

…ideo into topic/RDKEMW-10793

Merge branch 'develop' into topic/RDKEMW-10793

b3c1c94

Merge branch 'develop' into topic/RDKEMW-17603

f489785

RDK-61211: google cast auth extension (#3827)

d543680

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

Merge branch 'develop' into topic/RDKEMW-17603

545d2fe

Merge pull request #3751 from rdkcentral/topic/RDKEMW-17603

f3e3458

RDKEMW-17603: Subtec release 1.8.0

Copilot AI reviewed May 6, 2026

View reviewed changes

plaksh002c-public and others added 5 commits May 6, 2026 15:30

Merge branch 'develop' into topic/RDKEMW-10793

b4ee97b

Merge pull request #3833 from rdkcentral/topic/RDKEMW-10793

c1630b4

RDKEMW-10793: Networkmanager plugin release v2.2.0

Merge branch 'develop' into feature/RDKEMW-17411

8a0c73e

Merge branch 'develop' into topic/RDKEMW-17675

d1449b5

Merge pull request #3812 from rdkcentral/topic/RDKEMW-17675

daa2195

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot AI reviewed May 7, 2026

View reviewed changes

plaksh002c-public added 2 commits May 7, 2026 20:56

Merge branch 'develop' into feature/RDKEMW-17411

7b0a8d4

Merge pull request #3712 from rdkcentral/feature/RDKEMW-17411

367eef9

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

		if ! grep -q "wowlan_triggers=" "$WPA_SUPP_CONF_FILE"; then
		echo "wowlan_triggers=any" >> "$WPA_SUPP_CONF_FILE"

		@@ -1,4 +1,4 @@
		From 8af1da7acbc0e1874c500f2f69e4cd94e2663623 Mon Sep 17 00:00:00 2001
		From 96cf5315ea63c5f4a26564492ae62d783434b49f Mon Sep 17 00:00:00 2001


		SRC_URI:append = "${@bb.utils.contains('DISTRO_FEATURES', 'disable_mfr_read_hdcpkey', ' file://0001-tenablehdcp-remove-mfr-dependency.patch file://0002-start-hdcp-service-after-hdmi-service.patch ', '', d)}"

		SRC_URI:append = "${@bb.utils.contains('DISTRO_FEATURES', 'disable_mfr_read_hdcpkey', ' file://0001-tenablehdcp-remove-mfr-dependency.patch file://0002-Fix-for-tenableHDCP-crash-and-added-hdmiservice.patch ', '', d)}"

		EXTRA_OECMAKE += " -DENABLE_AAMP_JSBINDINGS_STATIC=OFF"
		EXTRA_OECMAKE += " -DENABLE_AAMP_JSBINDINGS_DYNAMIC=ON"

		install -d ${D}${systemd_unitdir}/system
		install -m 0644 ${WORKDIR}/wpeframework.service.in ${D}${systemd_unitdir}/system/wpeframework.service

Conversation

santoshcomcast commented Sep 29, 2025

Uh oh!

CLAassistant commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

CLAassistant commented Sep 29, 2025 •

edited

Loading