sync with develop by agampa263 · Pull Request #1688 · rdkcentral/meta-rdk-video

agampa263 · 2025-09-21T08:35:55Z

No description provided.

CLAassistant · 2025-09-21T08:36:04Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
23 out of 24 committers have signed the CLA.

✅ dkumar798
✅ preeja33
✅ ssitar583
✅ suppal045
✅ viveksinghnarwaria
✅ anusree23
✅ anand-ky
✅ tabbas651
✅ AkshayKumar2794
✅ Saranya2421
✅ Dosakaya
✅ hgfell683
✅ yuvaramachandran-gurusamy
✅ karuna2git
✅ mukesh972
✅ melhar098
✅ asurdej-comcast
✅ divyang-public
✅ emutavchi
✅ npoltorapavlo
✅ apatel859
✅ cmuhammedrafi
✅ dwolaver
❌ svc_rdkgerrit02

svc_rdkgerrit02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 147 out of 147 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 148 out of 148 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

recipes-extended/xdial/xdial.bb:1

The comment indicates a future date (August 06, 2025). This should be corrected to reflect the actual date of the commit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T16:01:12Z

 	else
 		install -m 0644 ${S}/tr69hostif.service ${D}${systemd_unitdir}/system
 	fi
+    sed -i 's/@DSMGR_DEPENDENCY@/iarmbusd.service/' ${D}${systemd_unitdir}/system/tr69hostif.service


The sed command has inconsistent indentation. It uses spaces instead of tabs like the surrounding lines. This should use tabs to match the file's indentation style.

Copilot · 2026-01-15T16:01:12Z

 PACKAGECONFIG[pdfjs]             = "-DENABLE_PDFJS=ON,-DENABLE_PDFJS=OFF,,"
-PACKAGECONFIG[dolbyvision]       = "-DENABLE_DV=ON,-DENABLE_DV=OFF,,"
-PACKAGECONFIG[vp9_hdr]           = "-DENABLE_HDR=ON,-DENABLE_HDR=OFF,,gstreamer1.0-plugins-good-matroska"
 PACKAGECONFIG[instantratechange] = "-DENABLE_INSTANT_RATE_CHANGE=ON,-DENABLE_INSTANT_RATE_CHANGE=OFF,"


Line 119 appears to be a duplicate entry of line 119 that was already present in the file (PACKAGECONFIG[pdfjs] appears twice at lines 119). One of these duplicate PACKAGECONFIG entries should be removed.

Copilot

Pull request overview

Copilot reviewed 148 out of 148 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

recipes-extended/xdial/xdial.bb:1

The comment contains a future date "Aug 06, 2025" which appears to be incorrect. This date is approximately 7 months in the future from the current date (January 2026).
recipes-extended/wpe-framework/wpeframework/r4.4/Activating_plugins_Logs_COMRPC.patch:1
The patch file contains malformed diff markers with incorrect line number prefixes. The lines starting with - | should not have the extra pipe character which makes the patch format inconsistent. This could potentially cause issues with patch application.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T15:08:55Z

+PR = "r0"

-SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;${CMF_GITHUB_SRC_URI_SUFFIX}"
+SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;${CMF_GITHUB_SRC_URI_SUFFIX};"


Trailing semicolon added to SRC_URI appears unnecessary and inconsistent with other similar definitions in the codebase. This could be unintentional.

Copilot · 2026-01-16T15:08:56Z

 SRC_URI += "file://2.38/comcast-RDKTV-17737-play-pause-mapping.patch"
-SRC_URI += "file://2.38.5/comcast-XRE-15382-XIONE-4595-RDKTV-17736-HDR-DV-conf.patch"
 SRC_URI += "file://2.38/comcast-RDKTV-17281-RDKTV-17781-Workaround-for-AppleTV-rende.patch"


The patch filename appears to be truncated: "Workaround-for-AppleTV-rende.patch" is missing the end of the word "rendering" or "render".

Copilot · 2026-01-16T15:08:56Z

+ExecStart=/bin/sh -c '/usr/bin/tenableHDCP true >> /opt/logs/hdcp.log 2>&1'
+RestartSec=5s
+Restart=on-failure


The RestartSec value uses "5s" format, but systemd accepts plain numbers as seconds. While this works, it's more common in systemd to use "RestartSec=5" without the 's' suffix for consistency.

Copilot

Pull request overview

Copilot reviewed 148 out of 148 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

recipes-extended/xdial/xdial.bb:1

The comment references August 06, 2025, which is a future date. This appears to be an error as the current date is January 16, 2026. The comment should either be removed or corrected to reflect the actual commit date.
recipes-extended/entservices/entservices-rdkappmanagers.bb:1
The appgatewaycommon plugin has a runtime dependency on networkmanager-plugin but this is only specified in DEPENDS (build-time), not RDEPENDS (runtime). If this plugin requires networkmanager-plugin at runtime, it should be added to RDEPENDS as well.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T19:25:22Z

 	else
 		install -m 0644 ${S}/tr69hostif.service ${D}${systemd_unitdir}/system
 	fi
+    sed -i 's/@DSMGR_DEPENDENCY@/iarmbusd.service/' ${D}${systemd_unitdir}/system/tr69hostif.service


The sed command uses leading spaces/tabs for indentation, which is inconsistent with the surrounding shell code that uses tabs. This should use consistent indentation (tabs) to match the rest of the do_install:append() function.

Copilot

Pull request overview

Copilot reviewed 151 out of 151 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 151 out of 151 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 151 out of 151 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-22T16:27:03Z

 do_install:append() {
-    if ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "true", "false", d)}
-    then
-        install -d ${D}${systemd_unitdir}/system
-        cp ${WORKDIR}/wpeframework.service.in  ${D}${systemd_unitdir}/system/wpeframework.service
-    else
-        install -d ${D}${sysconfdir}/init.d
-        install -m 0755 ${WORKDIR}/wpeframework-init ${D}${sysconfdir}/init.d/wpeframework
-    fi
-
-    install -d ${D}${systemd_unitdir}/system/wpeframework.service.d
-    install -m 0644 ${WORKDIR}/network_manager_migration.conf ${D}${systemd_unitdir}/system/wpeframework.service.d
+    install -d ${D}${systemd_unitdir}/system
+    install -m 0644 ${WORKDIR}/wpeframework.service.in  ${D}${systemd_unitdir}/system/wpeframework.service
 }


This recipe now always installs the systemd unit and no longer supports the non-systemd path (sysvinit init script). If this layer is expected to build for distros without the 'systemd' feature, this will break installation. Please restore the conditional systemd/sysvinit install logic (or add REQUIRED_DISTRO_FEATURES = "systemd" to make the assumption explicit).

Copilot · 2026-01-22T16:27:03Z

+           if [ -n "${NM_CONNECTIVITY_CHECK_RESPONSE}" ]; then
+               sed -i "s|response=|response=${NM_CONNECTIVITY_CHECK_RESPONSE}|g" ${D}${sysconfdir}/NetworkManager/conf.d/nm-connectivity.conf
+           fi


The sed replacement for the connectivity response only matches the "response=" prefix. If the template file ever has an existing value (e.g., response=foo), this will produce "response=foo" instead of replacing the whole line. Please replace using a whole-line match (e.g., ^response=.*) to make it robust.

Copilot · 2026-01-22T16:27:04Z

+    install -d ${D}${sysconfdir}/NetworkManager/dnsmasq.d
 	install -d ${D}${sysconfdir}/NetworkManager/dispatcher.d
 	install -d ${D}${sysconfdir}/NetworkManager/dispatcher.d/pre-down.d
 	install -m 0755 ${S}/lib/rdk/NM_Dispatcher.sh ${D}${sysconfdir}/NetworkManager/dispatcher.d
 	install -m 0755 ${S}/lib/rdk/NM_preDown.sh ${D}${sysconfdir}/NetworkManager/dispatcher.d/pre-down.d
 	install -m 0755 ${S}/etc/10-unmanaged-devices ${D}${sysconfdir}/NetworkManager/conf.d/10-unmanaged-devices.conf
+    install -m 0755 ${S}/etc/dnsmasq-dobby.conf ${D}${sysconfdir}/NetworkManager/dnsmasq.d/dnsmasq-dobby.conf


dnsmasq-dobby.conf is installed with mode 0755, but it's a configuration file under /etc/NetworkManager/dnsmasq.d and should not be executable. Please install it as 0644.

Copilot · 2026-01-22T16:27:04Z

 PR = "r0"
-PV = "1.3.0"
+PV = "v1.12.0"
 S = "${WORKDIR}/git"

 SRC_URI = "git://github.com/rdkcentral/networkmanager.git;protocol=https;branch=main"

-# Sep 17, 2025
-SRCREV = "9709dd5f5ed714bf6f6f41e0c368dcd804b16e71"
+SRCREV = "7326cf227b110da6f45c234d3f97ad728ce6fc2b"


Setting PV to "v1.12.0" (with a leading 'v') is unusual for BitBake recipes and can cause unexpected version sorting/upgrade behavior compared to numeric versions. Prefer using a numeric PV (e.g., "1.12.0") and keep the 'v' only in tags/notes if needed.

Copilot · 2026-01-22T16:27:04Z

+SRC_URI = "${CMF_GITHUB_ROOT}/rdkNativeScript;${CMF_GITHUB_SRC_URI_SUFFIX};"

-#Release 1.0.6
-SRCREV = "9824e773153631519f818e1c2380b3719a32007d"
+#Release 2.0.1
+SRCREV = "fd658c7612f006e384946f167db03caf454ab399"


SRC_URI now ends with an extra ';' ("...${CMF_GITHUB_SRC_URI_SUFFIX};"). BitBake treats ';' as the parameter delimiter inside a URI; leaving a trailing delimiter can cause parse issues or create an empty parameter. Please drop the trailing ';'.

Copilot · 2026-01-22T16:27:05Z

 SyslogIdentifier=WPEFramework
-ExecStart=/bin/bash -c 'if [ -f /opt/WPEFramework/config.json ]; then exec /usr/bin/WPEFramework -b -c /opt/WPEFramework/config.json; else exec /usr/bin/WPEFramework -b; fi'
+ExecStart=/usr/bin/WPEFramework -b
 # Manually adding PID file support. This is used by Thunder clients to know if


ExecStart was simplified to always run "WPEFramework -b", dropping the previous logic that preferred /opt/WPEFramework/config.json when present. If deployments rely on runtime config overrides via that path, this change will silently ignore them. Consider restoring the conditional ExecStart (or adding an ExecStartPre that selects the config file) so overrides keep working.

Copilot · 2026-01-22T16:27:05Z

+    install -d ${D}${sysconfdir}/NetworkManager/conf.d/
+    install -m 0755 ${WORKDIR}/nm-connectivity.conf ${D}${sysconfdir}/NetworkManager/conf.d/nm-connectivity.conf
+    if [ -f "${D}${sysconfdir}/NetworkManager/conf.d/nm-connectivity.conf" ]; then


This installs nm-connectivity.conf with mode 0755, but it's a config file and should not be executable. Please change to 0644 to match typical /etc configuration permissions.

Copilot · 2026-01-22T16:27:05Z

+    install -d ${D}${systemd_unitdir}/system/NetworkManager.service.d
+    install -m 0755 ${S}/systemd_units/NetworkManager_ecfs.conf ${D}${systemd_unitdir}/system/NetworkManager.service.d


NetworkManager_ecfs.conf is being installed with mode 0755 into NetworkManager.service.d. Drop-in .conf files should be non-executable (0644) to avoid confusing permissions and potential QA warnings.

Copilot · 2026-01-22T16:27:06Z

    gstreamer1.0-plugins-base-playback \
    gstreamer1.0-plugins-good-soup \
    gstreamer1.0-plugins-bad-opusparse \
+    gstreamer1.0-plugins-good-matroska \
 "


gstreamer1.0-plugins-good-matroska was removed from PACKAGECONFIG[vp9_hdr] deps, but RDEPS_VIDEO now pulls it in unconditionally. That makes the runtime dependency unconditional even when vp9_hdr is removed via HAS_HDR_SUPPORT. Consider making the matroska runtime dep conditional on vp9_hdr/HDR support to avoid unnecessary installs.

Copilot · 2026-01-22T16:27:06Z

   cp -a ${B}/JSRuntimeJSC ${D}/home/root/JSRuntimeJSC
-
+   cp -a ${B}/JSRuntimeContainer ${D}/home/root/JSRuntimeContainer
+


The new install step copies ${B}/JSRuntimeContainer into ${D}/home/root/JSRuntimeContainer, but this assumes ${D}/home/root exists and that JSRuntimeContainer is always produced by the build. Please ensure the destination directory is created (install -d) and guard the copy (or fail with a clear error) if the build artifact is absent.

- Revert rialto version - Revert rialto-gstreamer version

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

RDKEMW-16160: Handle widevine14 for xi6

Copilot

Pull request overview

Copilot reviewed 272 out of 273 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RDK-61007: Updated new service file for networkconnectionstats plugin

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Reason for Change: NetworkManager release v2.2.0 with following fixes - Added new method to connection to specific known SSID - Extended WiFiConnect method to support BSSID and specific Band - Defaulted to use RDKLogger and avoided redundant logging for few methods - Added Minimal Ethernet Connection Profile for migration handling - General improvements on RPC methods & crash resilience Test Procedure: NA Priority:P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>

…ideo into topic/RDKEMW-10793

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

RDKEMW-17603: Subtec release 1.8.0

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

RDKEMW-10793: Networkmanager plugin release v2.2.0

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

agampa263 requested review from a team as code owners September 21, 2025 08:35

Copilot AI review requested due to automatic review settings January 12, 2026 14:40

Copilot started reviewing on behalf of anand-ky January 12, 2026 14:41 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 12:11

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 16:26

Copilot started reviewing on behalf of anand-ky January 13, 2026 16:26 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 15, 2026 15:59

Copilot started reviewing on behalf of anand-ky January 15, 2026 15:59 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 15:06

Copilot started reviewing on behalf of anand-ky January 16, 2026 15:07 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 16, 2026 19:22

Copilot started reviewing on behalf of anand-ky January 16, 2026 19:23 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 20, 2026 14:53

Copilot started reviewing on behalf of Rocksta818 January 20, 2026 14:53 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 21, 2026 06:28

Copilot started reviewing on behalf of tdeva14 January 21, 2026 06:28 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 16:18

Copilot started reviewing on behalf of anand-ky January 22, 2026 16:18 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 22, 2026 19:24

varatharajan568 and others added 8 commits May 4, 2026 16:34

Update rialto_revision.inc

e6f8826

Update rialto_revision.inc

8c89a4c

Update rialto_revision.inc

22eefde

Update rialto_revision.inc

d8cef88

- Revert rialto version - Revert rialto-gstreamer version

Merge branch 'develop' into topic/RDKMVE-2173

b91c1e0

Merge pull request #3797 from rdkcentral/topic/RDKMVE-2173

51ae571

RDKEMW-17821 : Sceneset changes to include new preinstall changes.

Merge branch 'develop' into feature/RDKEMW-16160

0ab86d5

Merge pull request #3745 from rdkcentral/feature/RDKEMW-16160

dec8d5c

RDKEMW-16160: Handle widevine14 for xi6

Copilot AI reviewed May 4, 2026

View reviewed changes

plaksh002c-public added 4 commits May 5, 2026 10:49

Merge branch 'develop' into topic/RDK-59986

7359f41

Merge pull request #3789 from rdkcentral/topic/RDK-59986

eb63623

RDK-61007: Updated new service file for networkconnectionstats plugin

Merge branch 'develop' into feature/RDKEMW-17520_ctrlm-v1.1.14

4a5b232

Merge pull request #3741 from rdkcentral/feature/RDKEMW-17520_ctrlm-v…

40d75c2

…1.1.14 RDKEMW-17520: Control Manager component release v1.1.14

Copilot AI reviewed May 5, 2026

View reviewed changes

gururaajar and others added 7 commits May 5, 2026 16:50

Merge branch 'topic/RDKEMW-10793' of github.com:rdkcentral/meta-rdk-v…

58d991d

…ideo into topic/RDKEMW-10793

Merge branch 'develop' into topic/RDKEMW-10793

b3c1c94

Merge branch 'develop' into topic/RDKEMW-17603

f489785

RDK-61211: google cast auth extension (#3827)

d543680

Change-Id: I01fce7da85f78bf1597f30f63f527c59ea3fa1e8

Merge branch 'develop' into topic/RDKEMW-17603

545d2fe

Merge pull request #3751 from rdkcentral/topic/RDKEMW-17603

f3e3458

RDKEMW-17603: Subtec release 1.8.0

Copilot AI reviewed May 6, 2026

View reviewed changes

plaksh002c-public and others added 5 commits May 6, 2026 15:30

Merge branch 'develop' into topic/RDKEMW-10793

b4ee97b

Merge pull request #3833 from rdkcentral/topic/RDKEMW-10793

c1630b4

RDKEMW-10793: Networkmanager plugin release v2.2.0

Merge branch 'develop' into feature/RDKEMW-17411

8a0c73e

Merge branch 'develop' into topic/RDKEMW-17675

d1449b5

Merge pull request #3812 from rdkcentral/topic/RDKEMW-17675

daa2195

RDKEMW-17675: App Managers 0.4.0.1 Release Integration

Copilot AI reviewed May 7, 2026

View reviewed changes

plaksh002c-public added 2 commits May 7, 2026 20:56

Merge branch 'develop' into feature/RDKEMW-17411

7b0a8d4

Merge pull request #3712 from rdkcentral/feature/RDKEMW-17411

367eef9

RDKEMW-17411 : [develop] Rialto version upgradation v0.19.1

		install -d ${D}${systemd_unitdir}/system/NetworkManager.service.d
		install -m 0755 ${S}/systemd_units/NetworkManager_ecfs.conf ${D}${systemd_unitdir}/system/NetworkManager.service.d

		cp -a ${B}/JSRuntimeJSC ${D}/home/root/JSRuntimeJSC

		cp -a ${B}/JSRuntimeContainer ${D}/home/root/JSRuntimeContainer

Conversation

agampa263 commented Sep 21, 2025

Uh oh!

CLAassistant commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

CLAassistant commented Sep 21, 2025 •

edited

Loading