-
Notifications
You must be signed in to change notification settings - Fork 26
Update to latestCommit #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: topic/RDKEMW-7133-SW-CI-Verification
Are you sure you want to change the base?
Update to latestCommit #1663
Changes from all commits
19c5150
633a801
db17f90
77fb374
036afa5
907e7e3
1665433
67d32ac
d1ba508
ac8b608
7158a51
fa0da5d
117b4d8
94f1027
5ae866c
7f857bc
cedb79b
5f8993d
1451462
31838f1
50fb24f
03474db
b8481d8
8b8fc94
ea60930
e03472b
248e150
bc77c96
318db9f
28c7aa2
23920ab
5d9af98
37de855
bdb0543
8739c34
05d0103
27386a5
69ad83a
e601cb8
80b699d
e8033be
30f7612
e215450
9a7d0ca
83474d0
b7edbb4
fe4d2de
9568890
49d0749
da24b73
1e0cacb
ac1ee99
5a3b58b
18ae6b2
ebcd004
eb5dd85
460ca10
a393fcd
d6eacb4
5f1f2ea
5d26ef1
3775b56
5298ff1
3ca583f
2fa42b6
bd865eb
a6b5a33
f3b435c
fbdf0bd
bb21be9
6432ffd
57c64d3
e25a8a1
e740f29
ac96acd
3a51a6b
f394474
aa83f04
7b40d0b
e7823c7
7b8ee45
f8150ae
24a247d
c8562a4
1bbb2ad
f9a2c8c
a1a1af8
07dc15e
1c22444
2314c4d
354f18f
66ea4af
77565c6
8da2c4c
6dd2985
6ff3f96
6e6f1fe
ef1555c
5202b72
e961b5e
2de7c42
cb62a30
fd73b8c
6a0d5a7
91e859e
ce5f84c
ca64721
8ba97e7
3b39818
4ea0df2
d17bf46
ca0eee8
89609af
ef62d17
2582abb
85c30ba
1c4afae
86afc95
8d6fd35
00811a5
6ab9b01
43a9a8b
2651905
f2321ba
2a10433
d46660f
f649155
23c08f5
f402d42
26589ac
12b1736
01d81aa
8d834fb
5d8097f
6552189
165461a
da11017
f7811a5
bef347d
1c33390
adfb49e
e3f907f
ddfaf34
8d7fd1d
ac25408
ae4aa17
68f8907
0bf4bc4
87dad19
75f7be2
d166900
d425083
20657a1
cf7612b
9af143d
1f721c9
54c37ab
c33a0a0
816e403
77a13b6
09f201e
b85c31f
1219e21
a2a35af
49ef7de
013c92b
5d051c7
6e437ab
53f8923
ff86287
173b1b2
8a03ceb
f5114b5
c64401f
ac37f69
d9198d0
a31683d
5338836
5d8beb4
3bf4dd4
3d46e89
d0c63f0
b2b4fad
82dff3a
3f66020
2a01292
d14afa9
7145e6e
8f0f8db
13afa17
b66ba38
92e7e2e
b51933c
88d75ad
56dc618
b1c903e
88dc640
51e72ef
e75e2c9
a3357a8
cc5ff12
8d8ce67
917bc02
fd84584
70693ca
3b3c895
056d190
576a519
51e3d58
2f5cdac
1bf3f27
c175f6b
9f681b8
9cb53d7
1a9370c
e6f8826
8c89a4c
22eefde
d8cef88
b91c1e0
51ae571
2827ce8
868a6cc
d4a30dc
8c2c6d3
5345d1b
0ab86d5
dec8d5c
7359f41
eb63623
4a5b232
40d75c2
6be8e94
58d991d
b3c1c94
f489785
b73f0d1
21e23cb
d543680
545d2fe
f3e3458
b4ee97b
c1630b4
8a0c73e
d1449b5
daa2195
7b0a8d4
367eef9
bf667a4
99a467b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| name: RDK-E Middleware Change Request | ||
| description: Change Request for RDK-E Middleware | ||
| title: "<JIRA TICKET>:<Ticket Title> " | ||
| labels: ["MW Change Request"] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Change Request for RDK-E Middleware | ||
|
|
||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Description | ||
| description: Provide a clear and concise description of the feature or bug ticket | ||
| placeholder: Describe the changes you are bringing | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: additional-context | ||
| attributes: | ||
| label: Additional Context | ||
| description: Add any other context, screenshots, or examples about the feature request | ||
| placeholder: Any other relevant information | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: textarea | ||
| id: dod-checklist | ||
| attributes: | ||
| label: Definition of Done (DoD) | ||
| description: Mark items with [x] and replace the placeholder text on Details lines with actual information. | ||
| value: | | ||
| Please complete the following Middleware Layer Integration checklist items to ensure all requirements for changes to be merged. | ||
|
|
||
| **IMPORTANT:** Do NOT provide any proprietary information including: | ||
| - Links to internal Automatics/CI builds | ||
| - Links to internal Confluence pages | ||
| - Any other Comcast/Sky proprietary or confidential information | ||
| - Development Build/Setup Details | ||
|
|
||
| Only provide publicly accessible information and links. All proprietary information should be added to JIRA Ticket. | ||
|
|
||
| --- | ||
|
|
||
| - [ ] **Middleware component tags with changelog** | ||
| - Details: For instance https://github.com/rdkcentral/hdmicec/blob/1.0.7/CHANGELOG.md. Include all components that need to go together for Builds to work. | ||
|
|
||
| - [ ] **Tested on STBs** | ||
|
|
||
| - [ ] **Tested on TVs** | ||
|
|
||
| - [ ] **Dependent Layer tags (App Layer, OSS, Product, Halif Headers, Vendor Layers)** | ||
| - Details: (e.g. https://github.com/rdk-e/meta-image-support/blob/4.1.1/CHANGELOG.md) | ||
|
|
||
| - [ ] **Do Widgets Need Publishing** | ||
| - Details: (Provide context if widgets are involved) | ||
|
|
||
| - [ ] **Copilot review for Components** | ||
| - Details: (Any comments on the review) | ||
|
|
||
| - [ ] **Component Test** | ||
| - Details: Share Testing done as part of components release | ||
|
|
||
| - [ ] **Integration Testing** | ||
| - Details: Provide details on Integration testing done within Middleware layer | ||
|
|
||
| - [ ] **E2E Testing** | ||
| - Details: Provide details on end to end testing done across all layers | ||
|
|
||
| - [ ] **Performance Testing** | ||
| - Details: Provide details on performance testing done | ||
|
|
||
| - [ ] **Static code analysis/Coverity** | ||
| - Details: Share Coverity runs for components affected | ||
|
|
||
| - [ ] **Manual Functional Test** | ||
|
|
||
| validations: | ||
| required: true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: "CLA" | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| actions: write | ||
| statuses: write | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_target: | ||
| types: [opened, closed, synchronize] | ||
|
Comment on lines
+12
to
+13
|
||
|
|
||
| jobs: | ||
| CLA-Lite: | ||
| name: "Signature" | ||
| uses: rdkcentral/cmf-actions/.github/workflows/cla.yml@v1 | ||
|
||
| secrets: | ||
| PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_ASSISTANT }} | ||
|
Comment on lines
+3
to
+20
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,19 @@ | ||||||||||||||||||
| name: Fossid Stateless Diff Scan | ||||||||||||||||||
|
|
||||||||||||||||||
| on: | ||||||||||||||||||
| pull_request: | ||||||||||||||||||
| types: [opened, synchronize, reopened] | ||||||||||||||||||
|
Comment on lines
+1
to
+5
|
||||||||||||||||||
|
|
||||||||||||||||||
| permissions: | ||||||||||||||||||
| contents: read | ||||||||||||||||||
| pull-requests: read | ||||||||||||||||||
|
|
||||||||||||||||||
| jobs: | ||||||||||||||||||
| call-fossid-workflow: | ||||||||||||||||||
| if: ${{ ! github.event.pull_request.head.repo.fork }} | ||||||||||||||||||
| uses: rdkcentral/build_tools_workflows/.github/workflows/fossid_integration_stateless_diffscan.yml@1.0.0 | ||||||||||||||||||
| secrets: | ||||||||||||||||||
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | ||||||||||||||||||
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | ||||||||||||||||||
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | ||||||||||||||||||
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} | ||||||||||||||||||
|
Comment on lines
+16
to
+19
|
||||||||||||||||||
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | |
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | |
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | |
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} | |
| FOSSID_CONTAINER_USERNAME: ${{ secrets.FOSSID_CONTAINER_USERNAME }} | |
| FOSSID_CONTAINER_PASSWORD: ${{ secrets.FOSSID_CONTAINER_PASSWORD }} | |
| FOSSID_HOST_USERNAME: ${{ secrets.FOSSID_HOST_USERNAME }} | |
| FOSSID_HOST_TOKEN: ${{ secrets.FOSSID_HOST_TOKEN }} |
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,126 @@ | ||||||||||||
| name: PR Title Validation | ||||||||||||
|
|
||||||||||||
| on: | ||||||||||||
| pull_request: | ||||||||||||
| branches: [develop] | ||||||||||||
| types: [opened, edited, synchronize] | ||||||||||||
|
|
||||||||||||
| jobs: | ||||||||||||
| validate-pr-title: | ||||||||||||
| runs-on: ubuntu-latest | ||||||||||||
| steps: | ||||||||||||
| - name: Checkout code | ||||||||||||
| uses: actions/checkout@v4 | ||||||||||||
|
|
||||||||||||
| - name: Validate PR Title | ||||||||||||
| env: | ||||||||||||
| PR_TITLE: ${{ github.event.pull_request.title }} | ||||||||||||
| PR_BODY: ${{ github.event.pull_request.body }} | ||||||||||||
| run: | | ||||||||||||
| # Define valid ticket IDs | ||||||||||||
| VALID_TICKET_IDS=("RDKEMW" "RDKEVD" "IMMUI" "RDK" "RDKMVE" "RDKDEV") | ||||||||||||
|
|
||||||||||||
| # Function to validate ticket format and ID(s) | ||||||||||||
| validate_ticket() { | ||||||||||||
| local text="$1" | ||||||||||||
| local field_name="$2" | ||||||||||||
|
|
||||||||||||
| echo "Validating $field_name: $text" | ||||||||||||
|
|
||||||||||||
| # Check if text matches the pattern <TICKETID>-<ticketno.>[, <TICKETID>-<ticketno.>] : <desc> | ||||||||||||
| if [[ ! "$text" =~ ^([A-Z0-9]+-[0-9]+)([[:space:]]*,[[:space:]]*[A-Z0-9]+-[0-9]+)*[[:space:]]*:[[:space:]]*.+ ]]; then | ||||||||||||
| echo "ERROR: $field_name format is invalid." | ||||||||||||
| echo "Expected format: <TICKETID>-<ticketno.>[, <TICKETID>-<ticketno.>] : <description>" | ||||||||||||
| echo "Example (single): RDKEMW-123 : Fix playbook issue" | ||||||||||||
| echo "Example (multiple): RDKEMW-123, RDKDEV-45 : Fix playbook issue" | ||||||||||||
| echo "" | ||||||||||||
|
||||||||||||
| echo "" | |
| echo "" | |
| echo "Current $field_name is: '$text'" | |
| echo "Please update the $field_name to follow the required format before merging this PR." | |
| echo "" |
Copilot
AI
Feb 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow blocks PRs whose titles don’t match the strict <TICKETID>-<number> : <description> pattern. That will make CI fail for any PR that intentionally doesn’t use a ticketed title (including the current PR title shown in metadata). If strict enforcement is intended, the PR title must be updated; otherwise consider adding an allowlist or making this check non-blocking.
| exit 1 | |
| echo "NOTE: This is a non-blocking validation; CI will continue even if the PR title does not match the expected pattern." | |
| exit 0 |
Copilot
AI
Feb 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow enforces a strict <TICKETID>-<number> : <description> format on PR titles targeting develop. With the current PR title ("Update to latestCommit"), this check will fail once the workflow is added. Either update the PR title to the required format, or consider adding an explicit allowlist/escape hatch (e.g. for automated PRs) if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_request_targetruns in the context of the base repository and can access secrets; combined with broad permissions in this workflow, this increases blast radius if the called reusable workflow checks out or executes PR-controlled code. Consider tightening permissions to the minimum required and adding an explicit guard (e.g., only run for non-fork PRs or only for trusted actors), depending on howrdkcentral/cmf-actions/.github/workflows/cla.yml@v1operates.