Adjust clientlibs to new Thunder/interfaces#336
Open
nxtum wants to merge 1 commit intordkcentral:masterfrom
Open
Adjust clientlibs to new Thunder/interfaces#336nxtum wants to merge 1 commit intordkcentral:masterfrom
nxtum wants to merge 1 commit intordkcentral:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Windows/MSBuild project include paths and one header include to align these client libraries with the newer Thunder “interfaces” contract layout.
Changes:
- Add
$(ContractsPath)to include directories for projects that now depend on Thunder interface contracts. - Reorder include directory search order to prefer
$(ContractsPath)before$(FrameworkPath)across several clientlib projects. - Switch VirtualInput’s interface include from
plugins/IVirtualInput.htointerfaces/IVirtualInput.h.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Source/virtualinput/virtualinput.vcxproj | Adds $(ContractsPath) to include dirs for all configs so Thunder interface headers can be resolved. |
| Source/virtualinput/virtualinput.cpp | Updates include to #include <interfaces/IVirtualInput.h> to match new interface header location. |
| Source/securityagent/securityagent.vcxproj | Adds $(ContractsPath) to include dirs for all configs. |
| Source/displayinfo/displayinfo.vcxproj | Reorders include dirs to prefer $(ContractsPath) before $(FrameworkPath) across configs. |
| Source/deviceinfo/device_info/DeviceInfoTest.vcxproj | Reorders include dirs to prefer $(ContractsPath) before $(FrameworkPath) across configs. |
| Source/deviceinfo/DeviceInfo.vcxproj | Reorders include dirs to prefer $(ContractsPath) before $(FrameworkPath) across configs. |
| Source/cryptography/Cryptography.vcxproj | Reorders include dirs to prefer $(ContractsPath) before $(FrameworkPath) across configs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with:
rdkcentral/ThunderNanoServices#966
WebPlatformForEmbedded/ThunderNanoServicesRDK#379
rdkcentral/ThunderInterfaces#476
rdkcentral/Thunder#2102