feat(matter): add SBMD thermostat driver with optional fan control#213
Draft
feat(matter): add SBMD thermostat driver with optional fan control#213
Conversation
Add Matter Thermostat device type (0x0301) support via SBMD spec with: - Thermostat cluster (0x0201) read/write mappers for temperature setpoints, system mode, and control sequence - Optional Fan Control cluster (0x0202) resources (fanMode, fanOn) gated by prerequisite presence checks - Fix readableAttributeLookup to use unordered_multimap so multiple resources can read from the same cluster attribute Testing: - ThermostatDevice.js virtual device with side-band operations - ThermostatWithFanDevice.js subclass adding Fan Control cluster - Python fixtures (MatterThermostat, MatterThermostatWithFan) - Integration tests for commission, read, write, and sideband updates - Fan-specific tests for fanMode and fanOn resource reads Refs: BARTON-376
Contributor
Author
|
@copilot review this PR |
- Move null-cache guard before the loop in OnAttributeChanged; use continue instead of return on per-binding cache Get failure so a single miss does not abort remaining bindings - Remove dead `var schema` from heatSetpoint write script - Add null-value guards to setpoint-limit and controlSequenceOfOperation read scripts, matching the pattern used in localTemperature/setpoint scripts - Pass matterjs_entry_point through MatterThermostat.__init__ so MatterThermostatWithFan can pass it cleanly rather than patching internal state after construction Agent-Logs-Url: https://github.com/rdkcentral/BartonCore/sessions/e0e8d2c0-6174-418d-8b19-4d934b4087fe Co-authored-by: tleacmcsa <35579828+tleacmcsa@users.noreply.github.com>
Contributor
Review complete. Four issues were found and fixed in 86c2e9b:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Matter Thermostat device type (0x0301) support via SBMD spec with:
Testing:
Refs: BARTON-376