Skip to content

test: remove log truncation in subprocess tests#206

Draft
kfundecmcsa wants to merge 1 commit intomainfrom
kfun/dev/fix-test-log-truncation
Draft

test: remove log truncation in subprocess tests#206
kfundecmcsa wants to merge 1 commit intomainfrom
kfun/dev/fix-test-log-truncation

Conversation

@kfundecmcsa
Copy link
Copy Markdown
Contributor

The subprocess test runner was truncating captured output to 160 lines, hiding important failure details. Show the full output so developers can diagnose test failures without re-running locally.

The subprocess test runner was truncating captured output to
160 lines, hiding important failure details. Show the full
output so developers can diagnose test failures without
re-running locally.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves debuggability of requires_matterjs tests that run under the subprocess harness by removing output truncation, ensuring full child-process stdout/stderr is shown on failures.

Changes:

  • Removed the 160-line truncation logic for captured subprocess output in failure assertions.
  • Always includes the full captured output in the raised AssertionError to aid diagnosis.

Copy link
Copy Markdown
Contributor

@cleithner-comcast cleithner-comcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where the change we talked about to make all the tests not output unless failed (and not some tests)?

@kfundecmcsa
Copy link
Copy Markdown
Contributor Author

kfundecmcsa commented Apr 14, 2026

Where the change we talked about to make all the tests not output unless failed (and not some tests)?

Cause I forgot...

I looked into it, it's a bit more complicated than this fix, I'll keep at it

@tleacmcsa
Copy link
Copy Markdown
Contributor

Where the change we talked about to make all the tests not output unless failed (and not some tests)?

Cause I forgot...

I looked into it, it's a bit more complicated than this fix, I'll keep at it

Should this PR go back to draft?

@kfundecmcsa kfundecmcsa marked this pull request as draft April 17, 2026 15:59
@kfundecmcsa
Copy link
Copy Markdown
Contributor Author

Where the change we talked about to make all the tests not output unless failed (and not some tests)?

Cause I forgot...
I looked into it, it's a bit more complicated than this fix, I'll keep at it

Should this PR go back to draft?

yes - done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants