Fix: Correct Optax Adam state index out of bounds in notebook 01#5
Open
monsur161 wants to merge 1 commit intorcrowe-google:mainfrom
Open
Fix: Correct Optax Adam state index out of bounds in notebook 01#5monsur161 wants to merge 1 commit intorcrowe-google:mainfrom
monsur161 wants to merge 1 commit intorcrowe-google:mainfrom
Conversation
Updated hardcoded index from [1] to [0] to correctly access the ScaleByAdamState, as the Optax internal state tuple currently returns EmptyState() at index [1].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working through the
01 - JAX AI Stack.ipynbnotebook, I noticed a minor bug in the Optax optimizer state verification block.Currently, the script checks
adam_optax_internal_state[1]for the Adammustate. However, becauseoptax.adamchainsScaleByAdamandScaleByLearningRate, the momentum tracking variables (count,mu,nu) are actually located in theScaleByAdamStateat index[0]. Index[1]currently returns anEmptyState(), which causes thehasattrcheck to fail and triggers the warning block.I updated the hardcoded indices from
[1]to[0]so the state validation correctly passes.