Fix dynamic handling of view op in OpenVINO backend and enable get_row#162
Merged
zhaixuejun1993 merged 3 commits intoMay 13, 2026
Merged
Conversation
17c1563
into
ravi9:dev_backend_openvino
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of "view" inputs in the OpenVINO backend, specifically for the
get_rowsoperation. The update introduces a more robust and unified approach for processing view inputs, enabling more efficient slicing when possible and simplifying the overall logic. The most important changes are grouped below:Improved handling of view inputs
openvino/op/get_rows.cppto always process bothdataandindicesinputs using the newprocess_view_input_newfunction, ensuring consistent handling regardless of input source.process_view_input_newinopenvino/utils.cppto detect when a view can be represented as a simple slice along a single dimension, and to generate an efficientSlicenode in those cases, improving performance and clarity.Cleanup and compatibility
GGML_OP_GET_ROWSfrom the set of operations that do not support view inputs inggml-openvino.cpp, reflecting the improved support for views in the updated logic.…enable view + get_rowOverview
Additional information
Requirements